The bootstrapping feature was accidentally kept disabled behind a command switch: --oobe-bootstrapping-slave. For now, we plan to add a command switch to ChromeBit in M49. And enable the feature by default in M50 and later.
Add a command switch to ChromeBit: https://chromium-review.googlesource.com/#/c/333668/ Enable the feature by default: https://codereview.chromium.org/1829453002/
Also see the feature bug Issue 564370 and the launch bug Issue 537354.
LGTM, thanks Daisy. For reference, this was approved in issue 537354
ah,ha :) you beat me to it
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfe59845e307f126b25d555ef576e2968aa5d7b9 commit cfe59845e307f126b25d555ef576e2968aa5d7b9 Author: xdai <xdai@chromium.org> Date: Tue Mar 29 17:54:04 2016 Enable bootstrapping feature by default. Currently it was kept disabled behind a command switch --oobe-bootstrapping-slave. BUG= 597039 Review URL: https://codereview.chromium.org/1829453002 Cr-Commit-Position: refs/heads/master@{#383764} [modify] https://crrev.com/cfe59845e307f126b25d555ef576e2968aa5d7b9/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/cfe59845e307f126b25d555ef576e2968aa5d7b9/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc [modify] https://crrev.com/cfe59845e307f126b25d555ef576e2968aa5d7b9/chrome/browser/chromeos/login/startup_utils.cc [modify] https://crrev.com/cfe59845e307f126b25d555ef576e2968aa5d7b9/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/cfe59845e307f126b25d555ef576e2968aa5d7b9/chrome/browser/chromeos/login/wizard_controller.h [modify] https://crrev.com/cfe59845e307f126b25d555ef576e2968aa5d7b9/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc [modify] https://crrev.com/cfe59845e307f126b25d555ef576e2968aa5d7b9/chrome/browser/ui/webui/chromeos/login/controller_pairing_screen_handler.cc [modify] https://crrev.com/cfe59845e307f126b25d555ef576e2968aa5d7b9/chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.cc [modify] https://crrev.com/cfe59845e307f126b25d555ef576e2968aa5d7b9/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc [modify] https://crrev.com/cfe59845e307f126b25d555ef576e2968aa5d7b9/chrome/common/pref_names.cc [modify] https://crrev.com/cfe59845e307f126b25d555ef576e2968aa5d7b9/chrome/common/pref_names.h [modify] https://crrev.com/cfe59845e307f126b25d555ef576e2968aa5d7b9/chromeos/chromeos_switches.cc [modify] https://crrev.com/cfe59845e307f126b25d555ef576e2968aa5d7b9/chromeos/chromeos_switches.h [modify] https://crrev.com/cfe59845e307f126b25d555ef576e2968aa5d7b9/components/pairing/bluetooth_host_pairing_controller.cc [modify] https://crrev.com/cfe59845e307f126b25d555ef576e2968aa5d7b9/components/pairing/bluetooth_host_pairing_controller.h
[Automated comment] GRD changes detected, less than 3 weeks to before stable release of M50, manual review required.
ping this？
Approving merge to M50.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/086d377e0758cfdf3976985616f3afaf9940f1a9 commit 086d377e0758cfdf3976985616f3afaf9940f1a9 Author: xdai <xdai@chromium.org> Date: Tue Apr 12 00:34:54 2016 [Merge to M50] Enable bootstrapping feature by default. Currently it was kept disabled behind a command switch --oobe-bootstrapping-slave. BUG= 597039 TBR=dzhioev@chromium.org, achuith@chromium.org, emaxx@chromium.org Review URL: https://codereview.chromium.org/1829453002 Cr-Commit-Position: refs/heads/master@{#383764} (cherry picked from commit cfe59845e307f126b25d555ef576e2968aa5d7b9) Review URL: https://codereview.chromium.org/1875363002 . Cr-Commit-Position: refs/branch-heads/2661@{#562} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/086d377e0758cfdf3976985616f3afaf9940f1a9/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/086d377e0758cfdf3976985616f3afaf9940f1a9/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc [modify] https://crrev.com/086d377e0758cfdf3976985616f3afaf9940f1a9/chrome/browser/chromeos/login/startup_utils.cc [modify] https://crrev.com/086d377e0758cfdf3976985616f3afaf9940f1a9/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/086d377e0758cfdf3976985616f3afaf9940f1a9/chrome/browser/chromeos/login/wizard_controller.h [modify] https://crrev.com/086d377e0758cfdf3976985616f3afaf9940f1a9/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc [modify] https://crrev.com/086d377e0758cfdf3976985616f3afaf9940f1a9/chrome/browser/ui/webui/chromeos/login/controller_pairing_screen_handler.cc [modify] https://crrev.com/086d377e0758cfdf3976985616f3afaf9940f1a9/chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.cc [modify] https://crrev.com/086d377e0758cfdf3976985616f3afaf9940f1a9/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc [modify] https://crrev.com/086d377e0758cfdf3976985616f3afaf9940f1a9/chrome/common/pref_names.cc [modify] https://crrev.com/086d377e0758cfdf3976985616f3afaf9940f1a9/chrome/common/pref_names.h [modify] https://crrev.com/086d377e0758cfdf3976985616f3afaf9940f1a9/chromeos/chromeos_switches.cc [modify] https://crrev.com/086d377e0758cfdf3976985616f3afaf9940f1a9/chromeos/chromeos_switches.h [modify] https://crrev.com/086d377e0758cfdf3976985616f3afaf9940f1a9/components/pairing/bluetooth_host_pairing_controller.cc [modify] https://crrev.com/086d377e0758cfdf3976985616f3afaf9940f1a9/components/pairing/bluetooth_host_pairing_controller.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64388f359bc939e5742daeb7cac674427be8aa7d commit 64388f359bc939e5742daeb7cac674427be8aa7d Author: wez <wez@chromium.org> Date: Thu Apr 14 07:30:16 2016 Revert of [Merge to M50] Enable bootstrapping feature by default. (patchset #1 id:1 of https://codereview.chromium.org/1875363002/ ) Reason for revert: Appears to have broken PFQ for M50. Reverting at request of ketakid@. Original issue's description: > [Merge to M50] Enable bootstrapping feature by default. > > Currently it was kept disabled behind a command switch --oobe-bootstrapping-slave. > > BUG= 597039 > TBR=dzhioev@chromium.org, achuith@chromium.org, emaxx@chromium.org > > Review URL: https://codereview.chromium.org/1829453002 > > Cr-Commit-Position: refs/heads/master@{#383764} > (cherry picked from commit cfe59845e307f126b25d555ef576e2968aa5d7b9) > > Committed: https://chromium.googlesource.com/chromium/src/+/086d377e0758cfdf3976985616f3afaf9940f1a9 TBR=xdai@chromium.org NOPRESUBMIT=true NOTRY=true BUG= 597039 Review URL: https://codereview.chromium.org/1887953002 Cr-Commit-Position: refs/branch-heads/2661@{#579} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/64388f359bc939e5742daeb7cac674427be8aa7d/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/64388f359bc939e5742daeb7cac674427be8aa7d/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc [modify] https://crrev.com/64388f359bc939e5742daeb7cac674427be8aa7d/chrome/browser/chromeos/login/startup_utils.cc [modify] https://crrev.com/64388f359bc939e5742daeb7cac674427be8aa7d/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/64388f359bc939e5742daeb7cac674427be8aa7d/chrome/browser/chromeos/login/wizard_controller.h [modify] https://crrev.com/64388f359bc939e5742daeb7cac674427be8aa7d/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc [modify] https://crrev.com/64388f359bc939e5742daeb7cac674427be8aa7d/chrome/browser/ui/webui/chromeos/login/controller_pairing_screen_handler.cc [modify] https://crrev.com/64388f359bc939e5742daeb7cac674427be8aa7d/chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.cc [modify] https://crrev.com/64388f359bc939e5742daeb7cac674427be8aa7d/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc [modify] https://crrev.com/64388f359bc939e5742daeb7cac674427be8aa7d/chrome/common/pref_names.cc [modify] https://crrev.com/64388f359bc939e5742daeb7cac674427be8aa7d/chrome/common/pref_names.h [modify] https://crrev.com/64388f359bc939e5742daeb7cac674427be8aa7d/chromeos/chromeos_switches.cc [modify] https://crrev.com/64388f359bc939e5742daeb7cac674427be8aa7d/chromeos/chromeos_switches.h [modify] https://crrev.com/64388f359bc939e5742daeb7cac674427be8aa7d/components/pairing/bluetooth_host_pairing_controller.cc [modify] https://crrev.com/64388f359bc939e5742daeb7cac674427be8aa7d/components/pairing/bluetooth_host_pairing_controller.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2b06fb0e319bb4b5ad27779f06fac8e593ae51f commit c2b06fb0e319bb4b5ad27779f06fac8e593ae51f Author: xdai <xdai@chromium.org> Date: Thu Apr 14 17:44:37 2016 [Retry to merge into M50] Enable bootstrapping feature by default. Currently it was kept disabled behind a command switch --oobe-bootstrapping-slave. BUG= 597039 TBR=dzhioev@chromium.org, achuith@chromium.org, emaxx@chromium.org Review URL: https://codereview.chromium.org/1829453002 Cr-Commit-Position: refs/heads/master@{#383764} (cherry picked from commit cfe59845e307f126b25d555ef576e2968aa5d7b9) Review URL: https://codereview.chromium.org/1879233008 . Cr-Commit-Position: refs/branch-heads/2661@{#581} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/c2b06fb0e319bb4b5ad27779f06fac8e593ae51f/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/c2b06fb0e319bb4b5ad27779f06fac8e593ae51f/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc [modify] https://crrev.com/c2b06fb0e319bb4b5ad27779f06fac8e593ae51f/chrome/browser/chromeos/login/startup_utils.cc [modify] https://crrev.com/c2b06fb0e319bb4b5ad27779f06fac8e593ae51f/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/c2b06fb0e319bb4b5ad27779f06fac8e593ae51f/chrome/browser/chromeos/login/wizard_controller.h [modify] https://crrev.com/c2b06fb0e319bb4b5ad27779f06fac8e593ae51f/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc [modify] https://crrev.com/c2b06fb0e319bb4b5ad27779f06fac8e593ae51f/chrome/browser/ui/webui/chromeos/login/controller_pairing_screen_handler.cc [modify] https://crrev.com/c2b06fb0e319bb4b5ad27779f06fac8e593ae51f/chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.cc [modify] https://crrev.com/c2b06fb0e319bb4b5ad27779f06fac8e593ae51f/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc [modify] https://crrev.com/c2b06fb0e319bb4b5ad27779f06fac8e593ae51f/chrome/common/pref_names.cc [modify] https://crrev.com/c2b06fb0e319bb4b5ad27779f06fac8e593ae51f/chrome/common/pref_names.h [modify] https://crrev.com/c2b06fb0e319bb4b5ad27779f06fac8e593ae51f/chromeos/chromeos_switches.cc [modify] https://crrev.com/c2b06fb0e319bb4b5ad27779f06fac8e593ae51f/chromeos/chromeos_switches.h [modify] https://crrev.com/c2b06fb0e319bb4b5ad27779f06fac8e593ae51f/components/pairing/bluetooth_host_pairing_controller.cc [modify] https://crrev.com/c2b06fb0e319bb4b5ad27779f06fac8e593ae51f/components/pairing/bluetooth_host_pairing_controller.h
Comment 1 by x...@chromium.org
, Mar 22 2016