New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 597035 link

Starred by 1 user
Status: Fixed
Owner:
fmalita@chromium.org
Closed: Mar 2016
Cc:
█ mbarowsky+blinkimage@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 249382
issue 439655



Sign in to add a comment

ImageDecoder AlphaOption is not reflected in the frame SkBitmap alpha type

Project Member Reported by fmalita@chromium.org, Mar 22 2016 
Currently ImageDecoder/ImageFrame always sets kPremul_SkAlphatype on the frame SkBitmap, even when the values are unpremultiplied (e.g. when using ImageDecoder::AlphaNotPremultiplied).
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18a861d65e82a16f8cfbc7d3f160cfb3746523e2

commit 18a861d65e82a16f8cfbc7d3f160cfb3746523e2
Author: fmalita <fmalita@chromium.org>
Date: Tue Mar 22 21:16:43 2016

Propagate the decoder frame premul info to SkBitmap

Currently ImageFrame always sets up the resulting SkBitmap as
kPremul_SkAlphaType (or kOpaque_SkAlphaType in some cases), even
when AlphaOption == AlphaNotPremultiplied.

Update to set the correct bitmap alpha type.

R=noel@chromium.org,reed@google.com,xidachen@chromium.org
BUG= 597035 

Review URL: https://codereview.chromium.org/1820733004

Cr-Commit-Position: refs/heads/master@{#382680}

[modify] https://crrev.com/18a861d65e82a16f8cfbc7d3f160cfb3746523e2/third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp
[modify] https://crrev.com/18a861d65e82a16f8cfbc7d3f160cfb3746523e2/third_party/WebKit/Source/platform/image-decoders/ImageFrame.h
[modify] https://crrev.com/18a861d65e82a16f8cfbc7d3f160cfb3746523e2/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

Comment 2 by noel@chromium.org, Mar 22 2016

Blocking: 439655
Components: Blink>Image
Status: Fixed (was: Started)
►

Sign in to add a comment