New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 597032 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Mar 2016
Cc:
piman@chromium.org
dgozman@chromium.org
█ brettw@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Win8 GN build is broken

Project Member Reported by dgozman@chromium.org, Mar 22 2016 
https://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29

Error:
browser_main_runner.obj : error LNK2019: unresolved external symbol _ImmDisableTextFrameService@4 referenced in function "public: virtual int __thiscall content::BrowserMainRunnerImpl::Initialize(struct content::MainFunctionParams const &)" (?Initialize@BrowserMainRunnerImpl@content@@UAEHABUMainFunctionParams@2@@Z)

I didn't find anything related in revision range (https://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/23009).
Could be a bot configuration problem?

Comment 1 by dgozman@chromium.org, Mar 22 2016 

Same happened to Win x64 GN (dbg): https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/19683
Maybe not a bot problem then.

Comment 2 by aga...@chromium.org, Mar 22 2016

Labels: -Infra-Troopers
Seems like an actual compile failure.

Comment 3 by dgozman@chromium.org, Mar 22 2016

Cc: brettw@chromium.org
Could be this patch: https://codereview.chromium.org/1798273002

Comment 4 by dgozman@chromium.org, Mar 22 2016

Cc: piman@chromium.org
Another reason could be this: https://codereview.chromium.org/1813143002

Comment 5 by dgozman@chromium.org, Mar 22 2016

Status: Fixed (was: Available)

Comment 6 by brettw@chromium.org, Mar 23 2016 

This is marked fixed but my patch was reverted with a message "speculative revert." In the future, can you update the patch you reverted when you close the bug? It would save me poking around to see the state of my patch.

Comment 7 by brettw@chromium.org, Mar 23 2016 

Also, there was extensive discussion on IRC about this. Sheriffs are really supposed to be on IRC and should check before reverting, it would have saved everybody some time.

Comment 8 by dgozman@chromium.org, Mar 23 2016 

Alright, I will do that. I thought it's easy to see that revert got reverted back, but I guess it won't hurt anybody to comment on the original one.
►

Sign in to add a comment