New issue
Advanced search Search tips

Issue 597028 link

Starred by 2 users
Status: Fixed
Owner:
jam@chromium.org
Closed: Apr 2016
Cc:
wfh@chromium.org
jsc...@chromium.org
scottmg@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Remove #pragma comment(lib

Project Member Reported by jam@chromium.org, Mar 22 2016 
Recently a cleanup (https://codereview.chromium.org/1813143002) removed a file that had 
#pragma comment(lib, "imm32.lib")

This broke the build 

fix was in https://codereview.chromium.org/1824143002/ for this specific issue, but we should remove all "#pragma comment(lib," lines in the code (at least in our chromium repo) and put this information in build files consistently.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ce80494acfd8abf6f1164891cd8ff9487071304

commit 6ce80494acfd8abf6f1164891cd8ff9487071304
Author: jam <jam@chromium.org>
Date: Tue Mar 22 22:00:21 2016

Link with imm32.lib.

Otherwise I'm seeing.
[1/21] LINK(DLL) content.dll content.dll.lib
FAILED: C:/python_27_amd64/files/python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /IMPLIB:./content.dll.lib /DLL
/OUT:./content.dll /PDB:./content.dll.pdb @./content.dll.rsp
browser_main_runner.obj : error LNK2019: unresolved external symbol _ImmDisableTextFrameService@4 referenced in function "public: virtual in
t __thiscall content::BrowserMainRunnerImpl::Initialize(struct content::MainFunctionParams const &)" (?Initialize@BrowserMainRunnerImpl@cont
ent@@UAEHABUMainFunctionParams@2@@Z)
./content.dll : fatal error LNK1120: 1 unresolved externals
ninja: build stopped: subcommand failed.

This is caused by https://codereview.chromium.org/1813143002 which removed a file that had "#pragma comment(lib, "imm32.lib")"

BUG= 597028 

Review URL: https://codereview.chromium.org/1824143002

Cr-Commit-Position: refs/heads/master@{#382696}

[modify] https://crrev.com/6ce80494acfd8abf6f1164891cd8ff9487071304/content/browser/BUILD.gn
[modify] https://crrev.com/6ce80494acfd8abf6f1164891cd8ff9487071304/content/content_browser.gypi

Comment 4 by ashej...@chromium.org, Apr 1 2016

Status: Untriaged (was: Unconfirmed)
Marking the above issue as Untriaged as CL is already posted in the issue.

Thank you!

Comment 5 by wfh@chromium.org, Apr 1 2016

Owner: jam@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66e4b2b2800e3dc683dbde2ede2bd8873a59c299

commit 66e4b2b2800e3dc683dbde2ede2bd8873a59c299
Author: jam <jam@chromium.org>
Date: Fri Apr 01 15:09:09 2016

Remove "#pragma comment(lib" in chrome.

BUG= 597028 

Review URL: https://codereview.chromium.org/1845083003

Cr-Commit-Position: refs/heads/master@{#384585}

[modify] https://crrev.com/66e4b2b2800e3dc683dbde2ede2bd8873a59c299/chrome/browser/BUILD.gn
[modify] https://crrev.com/66e4b2b2800e3dc683dbde2ede2bd8873a59c299/chrome/browser/policy/BUILD.gn
[modify] https://crrev.com/66e4b2b2800e3dc683dbde2ede2bd8873a59c299/chrome/browser/policy/policy_path_parser_win.cc
[modify] https://crrev.com/66e4b2b2800e3dc683dbde2ede2bd8873a59c299/chrome/browser/private_working_set_snapshot_win.cc
[modify] https://crrev.com/66e4b2b2800e3dc683dbde2ede2bd8873a59c299/chrome/browser/ui/network_profile_bubble.cc
[modify] https://crrev.com/66e4b2b2800e3dc683dbde2ede2bd8873a59c299/chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc
[modify] https://crrev.com/66e4b2b2800e3dc683dbde2ede2bd8873a59c299/chrome/browser/ui/views/certificate_viewer_win.cc
[modify] https://crrev.com/66e4b2b2800e3dc683dbde2ede2bd8873a59c299/chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc
[modify] https://crrev.com/66e4b2b2800e3dc683dbde2ede2bd8873a59c299/chrome/browser/ui/webui/settings_utils_win.cc
[modify] https://crrev.com/66e4b2b2800e3dc683dbde2ede2bd8873a59c299/chrome/chrome.gyp
[modify] https://crrev.com/66e4b2b2800e3dc683dbde2ede2bd8873a59c299/chrome/chrome_browser.gypi
[modify] https://crrev.com/66e4b2b2800e3dc683dbde2ede2bd8873a59c299/chrome/chrome_common.gypi
[modify] https://crrev.com/66e4b2b2800e3dc683dbde2ede2bd8873a59c299/chrome/chrome_installer_util.gypi
[modify] https://crrev.com/66e4b2b2800e3dc683dbde2ede2bd8873a59c299/chrome/common/BUILD.gn
[modify] https://crrev.com/66e4b2b2800e3dc683dbde2ede2bd8873a59c299/chrome/common/safe_browsing/binary_feature_extractor_win.cc
[modify] https://crrev.com/66e4b2b2800e3dc683dbde2ede2bd8873a59c299/chrome/installer/util/BUILD.gn
[modify] https://crrev.com/66e4b2b2800e3dc683dbde2ede2bd8873a59c299/chrome/installer/util/html_dialog_impl.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5332a63125aa1dead5af575d57a63c17013db1a6

commit 5332a63125aa1dead5af575d57a63c17013db1a6
Author: jam <jam@chromium.org>
Date: Fri Apr 01 22:36:05 2016

Remove "#pragma comment(lib" in net.

BUG= 597028 

Review URL: https://codereview.chromium.org/1844793007

Cr-Commit-Position: refs/heads/master@{#384710}

[modify] https://crrev.com/5332a63125aa1dead5af575d57a63c17013db1a6/net/BUILD.gn
[modify] https://crrev.com/5332a63125aa1dead5af575d57a63c17013db1a6/net/base/keygen_handler_win.cc
[modify] https://crrev.com/5332a63125aa1dead5af575d57a63c17013db1a6/net/base/network_change_notifier_win.cc
[modify] https://crrev.com/5332a63125aa1dead5af575d57a63c17013db1a6/net/base/network_interfaces_win.cc
[modify] https://crrev.com/5332a63125aa1dead5af575d57a63c17013db1a6/net/cert/cert_database_win.cc
[modify] https://crrev.com/5332a63125aa1dead5af575d57a63c17013db1a6/net/cert/cert_verify_proc_win.cc
[modify] https://crrev.com/5332a63125aa1dead5af575d57a63c17013db1a6/net/cert/x509_cert_types_win.cc
[modify] https://crrev.com/5332a63125aa1dead5af575d57a63c17013db1a6/net/cert/x509_certificate_win.cc
[modify] https://crrev.com/5332a63125aa1dead5af575d57a63c17013db1a6/net/dns/dns_config_service_win.cc
[modify] https://crrev.com/5332a63125aa1dead5af575d57a63c17013db1a6/net/http/http_auth_handler_ntlm_win.cc
[modify] https://crrev.com/5332a63125aa1dead5af575d57a63c17013db1a6/net/http/url_security_manager_win.cc
[modify] https://crrev.com/5332a63125aa1dead5af575d57a63c17013db1a6/net/net_common.gypi
[modify] https://crrev.com/5332a63125aa1dead5af575d57a63c17013db1a6/net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc
[modify] https://crrev.com/5332a63125aa1dead5af575d57a63c17013db1a6/net/proxy/dhcp_proxy_script_fetcher_win.cc
[modify] https://crrev.com/5332a63125aa1dead5af575d57a63c17013db1a6/net/proxy/proxy_config_service_win.cc
[modify] https://crrev.com/5332a63125aa1dead5af575d57a63c17013db1a6/net/proxy/proxy_resolver_winhttp.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2d1a95a4a7b352ec99be461a3e443d5ba7c859a

commit e2d1a95a4a7b352ec99be461a3e443d5ba7c859a
Author: jam <jam@chromium.org>
Date: Sat Apr 02 00:27:10 2016

Add presubmit check to enforce that we don't add "#pragma comment(lib" anymore.

BUG= 597028 

Review URL: https://codereview.chromium.org/1847353003

Cr-Commit-Position: refs/heads/master@{#384754}

[modify] https://crrev.com/e2d1a95a4a7b352ec99be461a3e443d5ba7c859a/PRESUBMIT.py
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3709bb1cb5c96dcdfcd18d84ed53034422c5e533

commit 3709bb1cb5c96dcdfcd18d84ed53034422c5e533
Author: lukasza <lukasza@chromium.org>
Date: Mon Apr 04 17:26:03 2016

Revert of Remove "#pragma comment(lib" in media. (patchset #1 id:1 of https://codereview.chromium.org/1850223002/ )

Reason for revert:
Speculatively reverting, hoping that this is the CL to blame for the compile redness in https://build.chromium.org/p/chromium/builders/Win/builds/42017

Original issue's description:
> Remove "#pragma comment(lib" in media.
>
> BUG= 597028 
>
> Committed: https://crrev.com/e266135aab534260b8f4a2eb956d1f71ab106ae8
> Cr-Commit-Position: refs/heads/master@{#384928}

TBR=dalecurtis@chromium.org,tommi@chromium.org,jam@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 597028 

Review URL: https://codereview.chromium.org/1855183005

Cr-Commit-Position: refs/heads/master@{#384935}

[modify] https://crrev.com/3709bb1cb5c96dcdfcd18d84ed53034422c5e533/media/audio/BUILD.gn
[modify] https://crrev.com/3709bb1cb5c96dcdfcd18d84ed53034422c5e533/media/audio/win/audio_manager_win.cc
[modify] https://crrev.com/3709bb1cb5c96dcdfcd18d84ed53034422c5e533/media/audio/win/wavein_input_win.cc
[modify] https://crrev.com/3709bb1cb5c96dcdfcd18d84ed53034422c5e533/media/audio/win/waveout_output_win.cc
[modify] https://crrev.com/3709bb1cb5c96dcdfcd18d84ed53034422c5e533/media/media.gyp
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bb1fbb5df886fce9607a8486fb3c01b0fd4dd13

commit 4bb1fbb5df886fce9607a8486fb3c01b0fd4dd13
Author: jam <jam@chromium.org>
Date: Mon Apr 04 17:38:40 2016

Reland of move "#pragma comment(lib" in media. (patchset #1 id:1 of https://codereview.chromium.org/1855183005/ )

Reason for revert:
This couldn't have caused the build breakage; that's a missing dependency inside blink.

Original issue's description:
> Revert of Remove "#pragma comment(lib" in media. (patchset #1 id:1 of https://codereview.chromium.org/1850223002/ )
>
> Reason for revert:
> Speculatively reverting, hoping that this is the CL to blame for the compile redness in https://build.chromium.org/p/chromium/builders/Win/builds/42017
>
> Original issue's description:
> > Remove "#pragma comment(lib" in media.
> >
> > BUG= 597028 
> >
> > Committed: https://crrev.com/e266135aab534260b8f4a2eb956d1f71ab106ae8
> > Cr-Commit-Position: refs/heads/master@{#384928}
>
> TBR=dalecurtis@chromium.org,tommi@chromium.org,jam@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 597028 
>
> Committed: https://crrev.com/3709bb1cb5c96dcdfcd18d84ed53034422c5e533
> Cr-Commit-Position: refs/heads/master@{#384935}

TBR=dalecurtis@chromium.org,tommi@chromium.org,lukasza@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 597028 

Review URL: https://codereview.chromium.org/1853223002

Cr-Commit-Position: refs/heads/master@{#384936}

[modify] https://crrev.com/4bb1fbb5df886fce9607a8486fb3c01b0fd4dd13/media/audio/BUILD.gn
[modify] https://crrev.com/4bb1fbb5df886fce9607a8486fb3c01b0fd4dd13/media/audio/win/audio_manager_win.cc
[modify] https://crrev.com/4bb1fbb5df886fce9607a8486fb3c01b0fd4dd13/media/audio/win/wavein_input_win.cc
[modify] https://crrev.com/4bb1fbb5df886fce9607a8486fb3c01b0fd4dd13/media/audio/win/waveout_output_win.cc
[modify] https://crrev.com/4bb1fbb5df886fce9607a8486fb3c01b0fd4dd13/media/media.gyp

Comment 14 by jam@chromium.org, Apr 4 2016

Status: Fixed (was: Started)
►

Sign in to add a comment