CC should check its message size is under limit |
||||||||
Issue description
the const is kMaxPacketPayloadSizeBytes
if (message->ByteSize() > static_cast<int>(kMaxPacketPayloadSizeBytes)) {
DLOG(ERROR) << "Message rejected (too large): " << *message;
callback.Run(net::ERR_MSG_TOO_BIG);
return;
}
original bug: crbug/596796
,
Mar 22 2016
,
Mar 22 2016
Adding a note from our offline discussion, there is no direct way to reduce the size of a single message right now. Even if we drop this message, the compositor will again try to send a message with the same size. We'll need a combination of interest rect manipulation and display item caching. Also the scaling down of images sent with the compositor messages should reduce the size. In the meanwhile, we should consider bumping up the max payload size limit. And in the case where the message exceeds the limit, inform the client to show a popup to the user and trigger closing and re-creating the tab on the engine so we re-build the WebContents.
,
Mar 22 2016
,
Mar 22 2016
Increase the max size as a short term solution sounds good. When I tried to load cnbc.com, I got connection error. Suspect the same cause.
,
Mar 23 2016
Looks like the error on cnbc.com is caused by another bug, filed crbug/597163 for it.
,
Mar 23 2016
How about sfgate.com? Similar as cnn.com, almost empty page.
,
Mar 23 2016
Issue 596751 has been merged into this issue.
,
Mar 23 2016
For #8, it is http://www.youtube.com. If it is different reason, please re-open it. Mark this as P1 as it blocks too many sites.
,
Mar 23 2016
It is the same reason, I'm increasing the size limit for the messages, https://codereview.chromium.org/1823383002/
,
Mar 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe446e5fe8e9b4989f6341b8fe7ec7614fb18a16 commit fe446e5fe8e9b4989f6341b8fe7ec7614fb18a16 Author: khushalsagar <khushalsagar@chromium.org> Date: Wed Mar 23 19:55:06 2016 blimp: Increase max payload size limit. BUG= 597026 Review URL: https://codereview.chromium.org/1823383002 Cr-Commit-Position: refs/heads/master@{#382906} [modify] https://crrev.com/fe446e5fe8e9b4989f6341b8fe7ec7614fb18a16/blimp/net/blimp_message_output_buffer.cc [modify] https://crrev.com/fe446e5fe8e9b4989f6341b8fe7ec7614fb18a16/blimp/net/common.cc
,
Mar 23 2016
I'll reduce the priority on this but keeping it open. Since, we shouldn't be silently dropping messages.
,
Mar 24 2016
,
Mar 24 2016
I have opened a different bug for the silent dropping of messages on the engine, crbug/597743, since that shouldn't block the release. Marking this as fixed now.
,
Dec 9 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by khushals...@chromium.org
, Mar 22 2016