Always run log_diff even if the autotest fails |
|||||
Issue descriptionCurrently, when an autotest fails, log diffing is disabled and every log is collected since there have been some hard-to-debug crashes which required logs across reboots. However, when debugging the failure, the large number of Chrome log files makes finding the correct log files difficult. Issue 303352 has some additional context. Instead, we should always compute a log_diff and save it to a folder in results. Additionally, we should collect all of the logs as-is inside another folder. The productivity gains from the log_diff folder should be worth the storage/processing overhead. Log diffs are implemented at [1] and [2]. 1: https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/client/bin/site_sysinfo.py?l=90 2: https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/client/bin/site_sysinfo.py?l=320
,
Mar 30 2016
Bumping to P1 since this will be a huge usability win.
,
Apr 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/aded6c65365a20cb624f2478885b037cefa05676 commit aded6c65365a20cb624f2478885b037cefa05676 Author: Dan Shi <dshi@google.com> Date: Mon Apr 04 19:06:44 2016 [autotest] Do log diff even if test failed and requires full log. The log diff helps debugging issues when a dut has too much log before the test is started. BUG= chromium:597015 TEST=unittest, test_that 100.96.51.226 dummy_Fail Change-Id: I325a13365e4dde1c82f60cceab1cf6ef235ffcf6 Reviewed-on: https://chromium-review.googlesource.com/336909 Commit-Ready: Dan Shi <dshi@google.com> Tested-by: Dan Shi <dshi@google.com> Reviewed-by: Fang Deng <fdeng@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> [modify] https://crrev.com/aded6c65365a20cb624f2478885b037cefa05676/client/bin/site_sysinfo.py
,
Apr 5 2016
,
Apr 11 2016
,
May 23 2016
Bulk verified |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jdufault@chromium.org
, Mar 22 2016Owner: dshi@chromium.org