New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597005 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

No overscroll glow from main thread fling

Project Member Reported by bokan@chromium.org, Mar 22 2016

Issue description

Version: 51.0.2679.0
OS: Android

What steps will reproduce the problem?
(1) Disable threaded scrolling using about:flags or --disable-threaded-scrolling
(2) Go to a page with scrolling
(3) Fling to the bottom or top of the page

What is the expected output?
An overscroll "glow" should animate indicating the scrolling has hit its extent

What do you see instead?
Nothing, there is no glow. The glow does work when gesture scrolling normally (non-fling)


Please use labels and text to provide additional information.

 
Owner: sunyunjia@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b3f75d6275ec65b1db1116f58e462e729a782ac

commit 5b3f75d6275ec65b1db1116f58e462e729a782ac
Author: sunyunjia <sunyunjia@chromium.org>
Date: Fri Sep 02 00:10:15 2016

Stop negating the overscroll velocity to enable the glow of main thread fling

The glow of the fling is calculated from the fling velocity, which may be
defined for gesture and scroll that are in opposite directions. The overscroll
glow logic expects to receive the fling scroll velocity as opposed to fling
gesture velocity. So we stop negating the value to enable the glow effect at
disable-threaded-scrolling.

BUG= 597005 

Review-Url: https://codereview.chromium.org/2285423002
Cr-Commit-Position: refs/heads/master@{#416137}

[modify] https://crrev.com/5b3f75d6275ec65b1db1116f58e462e729a782ac/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/5b3f75d6275ec65b1db1116f58e462e729a782ac/content/renderer/render_widget_unittest.cc

Status: Fixed (was: Started)
Cc: majidvp@chromium.org siva.gun...@samsung.com satay...@samsung.com jdduke@chromium.org
 Issue 499743  has been merged into this issue.

Sign in to add a comment