Issue metadata
Sign in to add a comment
|
ChromeVox crashes when enabled on login screen |
||||||||||||||||||||||||
Issue description
Repro steps:
1. Get on the login screen;
2. Turn on spoken feedback (either by ctrl+alt+z or system tray menu)
Chrome crashes after step 2, prior showing the ChromeVox panel. The crash is because ChromeVoxPanel tries to access ash shelf, which is not created on the login screen.
Stack:
Program received signal SIGSEGV, Segmentation fault.
0x00007fdbedfa87e3 in DidFirstVisuallyNonEmptyPaint (this=<optimized out>) at ../../chrome/browser/chromeos/accessibility/chromevox_panel.cc:114
warning: Source file is more recent than executable.
114 ->SetChromeVoxPanelHeight(kPanelHeight);
(gdb) bt
#0 0x00007fdbedfa87e3 in DidFirstVisuallyNonEmptyPaint (this=<optimized out>) at ../../chrome/browser/chromeos/accessibility/chromevox_panel.cc:114
#1 ChromeVoxPanelWebContentsObserver::DidFirstVisuallyNonEmptyPaint (this=<optimized out>) at ../../chrome/browser/chromeos/accessibility/chromevox_panel.cc:42
#2 0x00007fdbed5164e4 in content::WebContentsImpl::OnFirstVisuallyNonEmptyPaint (this=<optimized out>) at ../../content/browser/web_contents/web_contents_impl.cc:3605
#3 0x00007fdbed51e3b2 in DispatchToMethodImpl<content::WebContentsImpl*, void (content::WebContentsImpl::*)()> (obj=<optimized out>, arg=..., method=<optimized out>)
at ../../base/tuple.h:166
#4 DispatchToMethod<content::WebContentsImpl*, void (content::WebContentsImpl::*)()> (obj=<optimized out>, arg=..., method=<optimized out>) at ../../base/tuple.h:173
#5 DispatchToMethod<content::WebContentsImpl, void (content::WebContentsImpl::*)(), void, std::tuple<> > (tuple=..., method=<optimized out>, obj=<optimized out>)
at ../../ipc/ipc_message_templates.h:25
#6 Dispatch<content::WebContentsImpl, content::WebContentsImpl, void, void (content::WebContentsImpl::*)()> (sender=<optimized out>, parameter=<optimized out>,
func=<optimized out>, obj=<optimized out>, msg=<optimized out>) at ../../ipc/ipc_message_templates.h:119
#7 content::WebContentsImpl::OnMessageReceived (this=<optimized out>, render_view_host=<optimized out>, render_frame_host=<optimized out>, message=...)
at ../../content/browser/web_contents/web_contents_impl.cc:606
#8 0x00007fdbed477431 in content::RenderViewHostImpl::OnMessageReceived (this=<optimized out>, msg=...) at ../../content/browser/renderer_host/render_view_host_impl.cc:892
#9 0x00007fdbed483123 in content::RenderWidgetHostImpl::OnMessageReceived (this=<optimized out>, msg=...) at ../../content/browser/renderer_host/render_widget_host_impl.cc:443
#10 0x00007fdbed46f3d5 in content::RenderProcessHostImpl::OnMessageReceived (this=<optimized out>, msg=...) at ../../content/browser/renderer_host/render_process_host_impl.cc:1804
#11 0x00007fdbed480399 in content::RenderWidgetHostImpl::OnSwapCompositorFrame (this=<optimized out>, message=...)
at ../../content/browser/renderer_host/render_widget_host_impl.cc:1617
#12 0x00007fdbed482c35 in content::RenderWidgetHostImpl::OnMessageReceived (this=<optimized out>, msg=...) at ../../content/browser/renderer_host/render_widget_host_impl.cc:459
#13 0x00007fdbed46f3d5 in content::RenderProcessHostImpl::OnMessageReceived (this=<optimized out>, msg=...) at ../../content/browser/renderer_host/render_process_host_impl.cc:1804
#14 0x00007fdbeac79c28 in IPC::ChannelProxy::Context::OnDispatchMessage (this=<optimized out>, message=...) at ../../ipc/ipc_channel_proxy.cc:293
...
,
Mar 23 2016
,
Mar 24 2016
,
Mar 28 2016
,
Mar 28 2016
,
Mar 28 2016
Albert was able to reproduce on Lulu on latest canary but not on beta.
,
Mar 28 2016
,
Mar 28 2016
This is REALLY bad when it happens. It would be really hard for a user to recover from this state.
,
Mar 29 2016
Filed issue 598839 to track adding an autotest for this. I my quick experiments, I was able to catch this crash by extending an existing test.
,
Mar 29 2016
The dev channel is over a week delayed at this point (we are targeting 8104.1/2 today), do you really want to block Dev channel on this? If so can this be fixed in the next 24 hours?
,
Mar 29 2016
Fix is in the commit queue now, I think it will land within an hour: https://codereview.chromium.org/1837053003/ Can you try to wait for it for dev? If it fails to land I'm okay with waiting until the next dev, thanks.
,
Mar 29 2016
Cool, would it be ok if we go with the dev we have staged and get this in the next scheduled dev (which is Thursday)? Revving Chrome again will delay at least another day on this release :(.
,
Mar 29 2016
Moving to beta block. Since this is already broken in dev one more cycle doesn't make it worse, but we CAN'T let this reach beta.
,
Mar 29 2016
Sounds good. Looks like the fix just landed.
,
Mar 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39d6d4bd6312b9f7379df930f4fde795d04687f0 commit 39d6d4bd6312b9f7379df930f4fde795d04687f0 Author: dmazzoni <dmazzoni@chromium.org> Date: Tue Mar 29 22:18:00 2016 Accessibility manager shouldn't try to access ash Shelf from login screen. BUG= 597000 Review URL: https://codereview.chromium.org/1837053003 Cr-Commit-Position: refs/heads/master@{#383847} [modify] https://crrev.com/39d6d4bd6312b9f7379df930f4fde795d04687f0/chrome/browser/chromeos/accessibility/accessibility_manager.cc [modify] https://crrev.com/39d6d4bd6312b9f7379df930f4fde795d04687f0/chrome/browser/chromeos/accessibility/chromevox_panel.cc [modify] https://crrev.com/39d6d4bd6312b9f7379df930f4fde795d04687f0/chrome/browser/chromeos/accessibility/chromevox_panel.h
,
Mar 30 2016
Thanks for the quick fix!
,
Mar 31 2016
,
Apr 6 2016
Verified on 51.0.2699.0 / 8155.0.0 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by abodenha@chromium.org
, Mar 22 2016