New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 596999 link

Starred by 1 user
Status: Fixed
Owner:
mfo...@chromium.org
Closed: Apr 2016
Cc:
█ apaci...@chromium.org
█ imch...@chromium.org
btolsch@chromium.org
mfo...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

[Media Router] Move component-specific code to c/b/media/router/mojo/

Project Member Reported by mfo...@chromium.org, Mar 22 2016 
There is a growing set of files that are sort-of shared between the Clank and desktop builds for Media Router.  This includes metrics, the dialog controller and some test support code.

I propose we move all mojo- and extensions- specific code to its own subfolder and, when possible, remove various #ifdef defined(OS_ANDROID) in the remaining codebase.

Comment 1 by sko...@chromium.org, Mar 23 2016

Status: Available (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66389721bebe73b5de231cea0672b0f436acea8c

commit 66389721bebe73b5de231cea0672b0f436acea8c
Author: mfoltz <mfoltz@chromium.org>
Date: Fri Apr 01 00:08:38 2016

[Media Router] Moves mojo-specific code into mojo/ folder

This moves code specific to the Mojo-based implementation of MR into a separate folder.  As part of this change:

- Component-specific MediaRouterMetrics are split into MediaRouterMetricsMojo
- Mojo-specific mocks are moved into media_router_mojo_test.{h,cc}
- Various #ifdef defined(OS_ANDROID) are removed

Also, updates TODOs to remove dependencies on mojo/ from UI code.

NOTE: media_router.mojom remains outside the mojo/ folder until dependencies from the extensions system can be updated.

BUG= 596999 

Review URL: https://codereview.chromium.org/1826403002

Cr-Commit-Position: refs/heads/master@{#384442}

[modify] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/extensions/chrome_mojo_service_registration.cc
[modify] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/media_router.gyp
[modify] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/media_router.gypi
[modify] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/media_router_factory.cc
[modify] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/media_router_metrics.cc
[modify] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/media_router_metrics.h
[delete] https://crrev.com/93649e8fc3faf88cee5a9b03b67199c4bb614b1c/chrome/browser/media/router/media_router_metrics_unittest.cc
[delete] https://crrev.com/93649e8fc3faf88cee5a9b03b67199c4bb614b1c/chrome/browser/media/router/media_router_mojo_test.h
[rename] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/mojo/media_route_provider_util_win.cc
[rename] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/mojo/media_route_provider_util_win.h
[rename] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[rename] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[rename] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[add] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/mojo/media_router_mojo_metrics.cc
[add] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/mojo/media_router_mojo_metrics.h
[add] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/mojo/media_router_mojo_metrics_unittest.cc
[rename] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/mojo/media_router_mojo_test.cc
[add] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/mojo/media_router_mojo_test.h
[rename] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/mojo/media_router_type_converters.cc
[rename] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/mojo/media_router_type_converters.h
[rename] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc
[modify] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/test_helper.cc
[modify] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/media/router/test_helper.h
[modify] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/ui/toolbar/media_router_action.cc
[modify] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
[modify] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c/chrome/test/media_router/media_router_e2e_browsertest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a60c1f4211ff0113e3ceb514b7b6297c070f37d3

commit a60c1f4211ff0113e3ceb514b7b6297c070f37d3
Author: mfoltz <mfoltz@chromium.org>
Date: Tue Apr 05 06:59:01 2016

[Media Router] Move media_router.mojom to c/b/media/router/mojo

This completes the co-location of the Mojo-related code in Media Router.  It
also adds a missing dependency from MR onto //content/public/browser.

BUG= 596999 

Review URL: https://codereview.chromium.org/1858783002

Cr-Commit-Position: refs/heads/master@{#385114}

[modify] https://crrev.com/a60c1f4211ff0113e3ceb514b7b6297c070f37d3/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/a60c1f4211ff0113e3ceb514b7b6297c070f37d3/chrome/browser/media/router/media_router.gyp
[rename] https://crrev.com/a60c1f4211ff0113e3ceb514b7b6297c070f37d3/chrome/browser/media/router/mojo/media_router.mojom
[modify] https://crrev.com/a60c1f4211ff0113e3ceb514b7b6297c070f37d3/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/a60c1f4211ff0113e3ceb514b7b6297c070f37d3/chrome/browser/media/router/mojo/media_router_mojo_test.h
[modify] https://crrev.com/a60c1f4211ff0113e3ceb514b7b6297c070f37d3/chrome/browser/media/router/mojo/media_router_type_converters.h
[modify] https://crrev.com/a60c1f4211ff0113e3ceb514b7b6297c070f37d3/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/a60c1f4211ff0113e3ceb514b7b6297c070f37d3/extensions/renderer/resources/extensions_renderer_resources.grd
[modify] https://crrev.com/a60c1f4211ff0113e3ceb514b7b6297c070f37d3/extensions/renderer/resources/media_router_bindings.js

Comment 4 by mfo...@chromium.org, Apr 5 2016

Status: Fixed (was: Available)
►

Sign in to add a comment