New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596967 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Make recipe findit/chromium/compile to use heuristics-based results

Project Member Reported by st...@chromium.org, Mar 22 2016

Issue description

For compile step failures, heuristics-based approach could have results in 1 or 2 minutes, with statically 60% for detection rate and 100% for accuracy.

The recipe could take advantage of such quick results to speed up by recompile at the suspected revision and the one before it.

 

Comment 1 by st...@chromium.org, Apr 7 2016

Here is an example of how this works.
Case:
  Entire regression range is: (r0, r10].
  Heuristics-based results are: [r5]
  Actual culprit is: r5

Currently without heuristics-based results, the recipe findit/chromium/compile runs at 5 revisions r1, r2, r3, r4, and r5 to identify the culprit r5.

With the heuristics-based results, the recipe could divide the entire regression range into two smaller ranges:
  range1: r4, and [r5, r6, r7, r8, r9, r10]
  range2: r0, and [r1, r2, r3]
The recipe checks range1 first, and it runs compile only at 2 revision r4 (pass) and then r5 (fail) to identify the culprit r5.

In this way, it runs less rounds of compile and as a result speeds up the culprit finding.

Comment 2 by st...@chromium.org, Apr 12 2016

Status: Fixed (was: Assigned)
The CL was landed. https://codereview.chromium.org/1869223002/

Comment 3 by st...@chromium.org, Apr 12 2016

Status: Assigned (was: Fixed)
Oops, close it too quick.

There is still a change needed on Findit side.

Comment 5 by st...@chromium.org, Apr 12 2016

The corresponding change on recipe side was landed as  https://codereview.chromium.org/1881223002/
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/37ab5bcdc6f6f9bfdc45f8e32785ab0a386ff98b

commit 37ab5bcdc6f6f9bfdc45f8e32785ab0a386ff98b
Author: stgao@chromium.org <stgao@chromium.org>
Date: Tue Apr 12 22:08:16 2016

[Findit] Set culprit and infra failure explicitly.

If suspected revisions from heuristic analysis are passed over to the recipe, there might be more than one revision with compile failures. Thus set the culprit explicitly if found.

BUG= chromium:596967 

Review URL: https://codereview.chromium.org/1881223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299873 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/37ab5bcdc6f6f9bfdc45f8e32785ab0a386ff98b/scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json
[modify] https://crrev.com/37ab5bcdc6f6f9bfdc45f8e32785ab0a386ff98b/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_build_error.json
[modify] https://crrev.com/37ab5bcdc6f6f9bfdc45f8e32785ab0a386ff98b/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_ping_failure.json
[modify] https://crrev.com/37ab5bcdc6f6f9bfdc45f8e32785ab0a386ff98b/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_setup_failure.json
[modify] https://crrev.com/37ab5bcdc6f6f9bfdc45f8e32785ab0a386ff98b/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_as_first_revision_of_entire_range.json
[modify] https://crrev.com/37ab5bcdc6f6f9bfdc45f8e32785ab0a386ff98b/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_at_first_revision_of_a_sub_range.json
[modify] https://crrev.com/37ab5bcdc6f6f9bfdc45f8e32785ab0a386ff98b/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_in_middle_of_a_sub_range.json
[modify] https://crrev.com/37ab5bcdc6f6f9bfdc45f8e32785ab0a386ff98b/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_in_second_sub_range.json
[modify] https://crrev.com/37ab5bcdc6f6f9bfdc45f8e32785ab0a386ff98b/scripts/slave/recipes/findit/chromium/compile.py

Comment 7 by st...@chromium.org, Apr 22 2016

Components: Tools>Test>FindIt
Labels: -Findit
Status: Fixed (was: Assigned)

Sign in to add a comment