New issue
Advanced search Search tips

Issue 596947 link

Starred by 4 users

Issue metadata

Status: Archived
Owner:
Closed: Dec 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Chrome-Bug-Cleanup


Sign in to add a comment

PDF does not display when opened

Project Member Reported by andyb...@chromium.org, Mar 22 2016

Issue description

Chrome Version       : 49.0.2623.87
OS Version: OS X 10.11.4

What steps will reproduce the problem?
1. Open the attached PDF in Chrome

What is the expected result?
The PDF is displayed properly

What happens instead of that?
Only the PDF viewer chrome is displayed


UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.87 Safari/537.36



 
Sky Deck Rendering March 2016.pdf
3.5 MB Download

Comment 1 by shrike@chromium.org, Mar 23 2016

Owner: thestig@chromium.org
Status: Untriaged (was: Unconfirmed)
Hi thestig@,

This PDF opens OK in Preview on my Mac. Can you move it along to the right PDF plug-in person to diagnose further?

Cc: tsepez@chromium.org
Status: Assigned (was: Untriaged)
Marking assigned to thestig@ and CCing tsepez@ for routing or assignment.
The issue seems to have to do with the second trailer. If you remove the second trailer in the document it opens correctly.
Looking at this a bit more, the original trailer was a V5 trailer. When we parse it we end up getting object 2 pointing to position 12. The new trailer isn't V4 or V5 so we go into ParseCrossRef. When that finishes we don't find an object 2 because one doesn't exist in the document.

The Pages entry says the page is at object 2.

So, the question becomes, when parsing the second trailer, why do we parse incorrectly.
Labels: -OS-Mac OS-All
Owner: weili@chromium.org
Wei, can you take a look?

FWIW, Ghostscript's pdf2ps successfully converted the file to PS. Libpoppler-based PDF viewers cannot open the PDF either.

Comment 6 by weili@chromium.org, Apr 22 2016

Status: Started (was: Assigned)
I will take a look. This pdf is weirdly formed though.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium.git/+/cd1e9ff4f432cbc29ed279e6891fb7ddc2ea3734

commit cd1e9ff4f432cbc29ed279e6891fb7ddc2ea3734
Author: weili <weili@chromium.org>
Date: Fri Apr 29 17:24:02 2016

Relax a couple checks to allow certain non-standard PDF files.

Some non-standard PDF files misuse the size of cross reference table,
and reuse some object number which the old one is still in use. PDFium
can relax the reusing of xref objects only since it is not referred in
the pdf document. When the size of cross reference table is larger
than defined, PDFium will try to continue other than abort.

BUG= chromium:596947 

Review-Url: https://codereview.chromium.org/1926823002

[modify] https://crrev.com/cd1e9ff4f432cbc29ed279e6891fb7ddc2ea3734/core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp
[modify] https://crrev.com/cd1e9ff4f432cbc29ed279e6891fb7ddc2ea3734/core/fpdfapi/fpdf_parser/cpdf_parser.cpp
[modify] https://crrev.com/cd1e9ff4f432cbc29ed279e6891fb7ddc2ea3734/core/fpdfapi/fpdf_parser/cpdf_parser_embeddertest.cpp
[add] https://crrev.com/cd1e9ff4f432cbc29ed279e6891fb7ddc2ea3734/testing/resources/bug_596947.pdf

Comment 9 by weili@chromium.org, May 2 2016

Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium.git/+/5fc4f31285c3a88fc157fd2d9b9cf2eb5c7cabed

commit 5fc4f31285c3a88fc157fd2d9b9cf2eb5c7cabed
Author: weili <weili@chromium.org>
Date: Tue May 03 18:46:17 2016

Revert of Relax a couple checks to allow certain non-standard PDF files. (patchset #1 id:1 of https://codereview.chromium.org/1926823002/ )

Reason for revert:
Speculatively revert due to high volume of crashes on Chromium.

Original issue's description:
> Relax a couple checks to allow certain non-standard PDF files.
>
> Some non-standard PDF files misuse the size of cross reference table,
> and reuse some object number which the old one is still in use. PDFium
> can relax the reusing of xref objects only since it is not referred in
> the pdf document. When the size of cross reference table is larger
> than defined, PDFium will try to continue other than abort.
>
> BUG= chromium:596947 
>
> Committed: https://pdfium.googlesource.com/pdfium/+/cd1e9ff4f432cbc29ed279e6891fb7ddc2ea3734

TBR=thestig@chromium.org,dsinclair@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= chromium:596947 

Review-Url: https://codereview.chromium.org/1946693002

[modify] https://crrev.com/5fc4f31285c3a88fc157fd2d9b9cf2eb5c7cabed/core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp
[modify] https://crrev.com/5fc4f31285c3a88fc157fd2d9b9cf2eb5c7cabed/core/fpdfapi/fpdf_parser/cpdf_parser.cpp
[modify] https://crrev.com/5fc4f31285c3a88fc157fd2d9b9cf2eb5c7cabed/core/fpdfapi/fpdf_parser/cpdf_parser_embeddertest.cpp
[delete] https://crrev.com/fd670fdef8984fd7f8824b17d8fcf52fdec9aacc/testing/resources/bug_596947.pdf

Project Member

Comment 11 by bugdroid1@chromium.org, May 4 2016

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium.git/+/a031357eaab7c934ac03717968cf78ff556c819b

commit a031357eaab7c934ac03717968cf78ff556c819b
Author: weili <weili@chromium.org>
Date: Wed May 04 16:36:11 2016

Reland of lax a couple checks to allow certain non-standard PDF files. (patchset #1 id:1 of https://codereview.chromium.org/1946693002/ )

Reason for revert:
The culprit was found and confirmed, not this one.

Original issue's description:
> Revert of Relax a couple checks to allow certain non-standard PDF files. (patchset #1 id:1 of https://codereview.chromium.org/1926823002/ )
>
> Reason for revert:
> Speculatively revert due to high volume of crashes on Chromium.
>
> Original issue's description:
> > Relax a couple checks to allow certain non-standard PDF files.
> >
> > Some non-standard PDF files misuse the size of cross reference table,
> > and reuse some object number which the old one is still in use. PDFium
> > can relax the reusing of xref objects only since it is not referred in
> > the pdf document. When the size of cross reference table is larger
> > than defined, PDFium will try to continue other than abort.
> >
> > BUG= chromium:596947 
> >
> > Committed: https://pdfium.googlesource.com/pdfium/+/cd1e9ff4f432cbc29ed279e6891fb7ddc2ea3734
>
> TBR=thestig@chromium.org,dsinclair@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= chromium:596947 
>
> Committed: https://pdfium.googlesource.com/pdfium/+/5fc4f31285c3a88fc157fd2d9b9cf2eb5c7cabed

TBR=thestig@chromium.org,dsinclair@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:596947 

Review-Url: https://codereview.chromium.org/1947983002

[modify] https://crrev.com/a031357eaab7c934ac03717968cf78ff556c819b/core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp
[modify] https://crrev.com/a031357eaab7c934ac03717968cf78ff556c819b/core/fpdfapi/fpdf_parser/cpdf_parser.cpp
[modify] https://crrev.com/a031357eaab7c934ac03717968cf78ff556c819b/core/fpdfapi/fpdf_parser/cpdf_parser_embeddertest.cpp
[add] https://crrev.com/a031357eaab7c934ac03717968cf78ff556c819b/testing/resources/bug_596947.pdf

Project Member

Comment 12 by bugdroid1@chromium.org, May 9 2016

Status: Assigned (was: Fixed)
Reopening because the fix got reverted.
Cc: hnakashima@chromium.org
Hello!
This bug is receiving this notice because there has been no acknowledgment of its existence in quite a bit of time
- If you are currently working on this bug, please provide an update.
- If you are currently affected by this bug, please update with your current symptoms and relevant logs.

If there has been no updates provided by EOD Wednesday, 12/12/18 (5pm EST), this bug will be archived and can be re-opened at any time deemed necessary.

Thank you!
Status: Archived (was: Assigned)
Due to lack of action this bug has been Archived. If work is still being done on this issue or you are still experiencing this issue please feel free to re-open with the appropriate information.

Sign in to add a comment