New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 596935 link

Starred by 1 user
Status: Fixed
Owner:
█ fsam...@chromium.org
Last visit > 30 days ago
Closed: Mar 2016
Cc:
█ vollick@chromium.org
penghuang@chromium.org
█ markdittmer@chromium.org
rjkroege@chromium.org
vmi...@chromium.org
piman@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
mus



Sign in to add a comment

content/browser depends on content/gpu

Project Member Reported by brettw@chromium.org, Mar 22 2016 
https://codereview.chromium.org/1799713002 moved gpu_host_messages from content/common to content/gpu.

gpu_host_messages is used by content/browser. This introduces a path browser -> gpu -> child -> blink, but the browser should not be linking blink (or child at all). GPU is a "child" process.

Comment 1 by fsam...@chromium.org, Mar 22 2016

Cc: rjkroege@chromium.org vollick@chromium.org markdittmer@chromium.org piman@chromium.org vmi...@chromium.org penghuang@chromium.org

Comment 2 by fsam...@chromium.org, Mar 22 2016

Labels: mustash1 mus gpurefactor OS-All
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/115b5ed455b9d00ed278e5138e29bee2402ee32b

commit 115b5ed455b9d00ed278e5138e29bee2402ee32b
Author: fsamuel <fsamuel@chromium.org>
Date: Tue Mar 22 19:41:58 2016

gpu_host_messages => content/common

content/browser cannot depend on content/gpu because that pulls in blink.

Thus, this CL moves gpu_host_messages.h and dependencies to content/common

BUG= 596935 

Review URL: https://codereview.chromium.org/1820793005

Cr-Commit-Position: refs/heads/master@{#382648}

[modify] https://crrev.com/115b5ed455b9d00ed278e5138e29bee2402ee32b/content/browser/BUILD.gn
[modify] https://crrev.com/115b5ed455b9d00ed278e5138e29bee2402ee32b/content/browser/DEPS
[modify] https://crrev.com/115b5ed455b9d00ed278e5138e29bee2402ee32b/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/115b5ed455b9d00ed278e5138e29bee2402ee32b/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/115b5ed455b9d00ed278e5138e29bee2402ee32b/content/browser/gpu/gpu_process_host_ui_shim.cc
[modify] https://crrev.com/115b5ed455b9d00ed278e5138e29bee2402ee32b/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/115b5ed455b9d00ed278e5138e29bee2402ee32b/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/115b5ed455b9d00ed278e5138e29bee2402ee32b/content/common/content_message_generator.h
[rename] https://crrev.com/115b5ed455b9d00ed278e5138e29bee2402ee32b/content/common/establish_channel_params.cc
[rename] https://crrev.com/115b5ed455b9d00ed278e5138e29bee2402ee32b/content/common/establish_channel_params.h
[rename] https://crrev.com/115b5ed455b9d00ed278e5138e29bee2402ee32b/content/common/gpu_host_messages.h
[modify] https://crrev.com/115b5ed455b9d00ed278e5138e29bee2402ee32b/content/content_common.gypi
[modify] https://crrev.com/115b5ed455b9d00ed278e5138e29bee2402ee32b/content/content_gpu.gypi
[modify] https://crrev.com/115b5ed455b9d00ed278e5138e29bee2402ee32b/content/gpu/BUILD.gn
[delete] https://crrev.com/d206550938ad868be9093efe28fa56d6f2238220/content/gpu/content_gpu_message_generator.cc
[delete] https://crrev.com/d206550938ad868be9093efe28fa56d6f2238220/content/gpu/content_gpu_message_generator.h
[modify] https://crrev.com/115b5ed455b9d00ed278e5138e29bee2402ee32b/content/gpu/gpu_child_thread.cc
[modify] https://crrev.com/115b5ed455b9d00ed278e5138e29bee2402ee32b/content/gpu/gpu_main.cc

Comment 4 by fsam...@chromium.org, Mar 23 2016

Status: Fixed (was: Assigned)
This should be fixed now. Closing.
►

Sign in to add a comment