New issue
Advanced search Search tips

Issue 596934 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 596145
Owner: ----
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 457078



Sign in to add a comment

sizes step failing on win_perf_bisect_builder

Project Member Reported by h...@chromium.org, Mar 22 2016

Issue description

For example: https://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect_builder/builds/13492/steps/sizes/logs/stdio

@@@STEP_TEXT@</div>@@@
  File "C:\b\build\scripts\slave\runtest.py", line 1951, in <module>
    sys.exit(main())
  File "C:\b\build\scripts\slave\runtest.py", line 1916, in main
    result = _MainWin(options, args, extra_env)
  File "C:\b\build\scripts\slave\runtest.py", line 1489, in _MainWin
    perf_dashboard_id=options.perf_dashboard_id)
  File "C:\b\build\scripts\slave\annotation_utils.py", line 123, in annotate
    raise Exception('runtest.py error: perf step specified but'
Exception: runtest.py error: perf step specified butno test_id in factory_properties!


Quinten, you added this exception. How do I make it go away?

I don't need this data to be uploaded to the perf dashboard, so the step is running without results_url or perf_id (see https://codereview.chromium.org/1809783003).
 

Comment 1 by h...@chromium.org, Mar 22 2016

Mergedinto: 596145
Status: Duplicate (was: Available)
Hmm, the error message is suggesting that if the "log processor" object has the method PerformanceLogs, then it's assumed to be a "perf step".

https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/annotation_utils.py&l=121

A few possible changes:

 - Remove the check and the exception, and instead just log a warning and don't write performance log lines
 - Find a different way to check whether we want perf results besides looking at the log processor object
 - Find a way to make it use a different log processor object
 hasattr(log_processor, 'PerformanceLogs')

Do we still want to make one of these changes?


(Note, I didn't actually add that exception - it has been there for a long time (more than 2 and a half years); it was in runtest.py before it was moved to annotation_utils.py.)

Sign in to add a comment