Keyboard accelerators won't work if an extension popup is open |
||||
Issue descriptionChromium 51.0.2682.0 (Developer Build) (32-bit) Revision ba603a096944e16f5ac757c2a513b01a080cb3db-refs/heads/master@{#381748} OS Windows Blink 537.36 (@ba603a096944e16f5ac757c2a513b01a080cb3db) JavaScript V8 5.1.153 Flash 21.0.0.182 User Agent Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2682.0 Safari/537.36 Command Line "C:\dev\chromium\src\out\Release\chrome.exe" --user-data-dir="c:\tmp\keyb" --lang=en_US --flag-switches-begin --flag-switches-end What steps will reproduce the problem? 1. Install any Chrome extension that adds a button to the extensions toolbar. For example, https://chrome.google.com/webstore/detail/grammarly-spell-checker-g/kbfnbcaeplbcioakkpcpgfkobkghlhen?utm_source=chrome-app-launcher-info-dialog 2. Press the extension button to show extension popup. 3. While extension popup is active, try to press keyboard accelerators like CTRL+TAB, CTRL+{1,2,3}, CTRL+F, CTRL+L or even ALT+F4. What is the expected result? Accelerators should work, e.g. active tab can be changed, or find-bar should appear and extension popup disappears. What happens instead of that? Accelerators won't work. Current tab cannot be changed, omnibox cannot be activated from keyboard and popup is still active. It seems that CL https://codereview.chromium.org/1544803004 is the source of this issue, see https://bugs.chromium.org/p/chromium/issues/detail?id=557558.
,
May 26 2016
iceman@ could you please confirm are you still facing this issue on latest stable 51.0.2704.63? getting an error while adding https://chrome.google.com/webstore/detail/grammarly-spell-checker-g/kbfnbcaeplbcioakkpcpgfkobkghlhen?utm_source=chrome-app-launcher-info-dialog extesnion to chrome. Request you please try the issue by upgrading chrome to latest stable and update the thread if the issue still persists. Thanks,
,
May 26 2016
Hi! Sorry for a long delay! The problem still exists on my Windows7 machine. I've attached two screencast, for latest Chromium 53 and stable Chrome 51. In that screencasts I open an extension popup and try to press keyboard accelerators like CTRL+1,2,3 or CTRL+TAB to change current tab. In both cases at the end I pressed ALT+F4 and this closes the popup, but not the Chrome windows.
,
May 26 2016
Thank you for providing more feedback. Adding requester "rnimmagadda@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 1 2016
==================================== Good Build: 50.0.2645.0 Base Position: 374251 Bad Build: 50.0.2655.0 Base Position: 376333 ===================================== Able to repro this issue on Windows 7, MAC (10.11.5) & Ubuntu Trusty (14.04) for the Google Chrome Stable Version - 51.0.2704.63 This is a regression issue broken in M50, below mentioned is the bisect info: CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/0b5363e434fdbf98397c344a441a62de025e1adb..09b5446ad460feb3c57d2c8e1e5787dcb4f664ee Suspecting Commit: ac440714860679857517ac7dd4c6282acbfa4033 Review URL: https://codereview.chromium.org/1544803004 @meacer: Could you please look into the issue, and if it has nothing to do with your changes and if possible please do assign it to the concerned owner. Thank you.
,
Jan 26 2017
Sorry for not attending this earlier. https://codereview.chromium.org/1544803004 was very likely what changed this behavior. However, I feel like the behavior isn't too odd: If the popup is open, it is the active window, and shouldn't be consuming the key presses?
,
Mar 1 2017
Ping. I think the behavior here is reasonable. If noone objects, I'll close this as wontfix. |
||||
►
Sign in to add a comment |
||||
Comment 1 by rnimmagadda@chromium.org
, May 2 2016Labels: Needs-Feedback
4.2 MB
4.2 MB Download