Issue 596913 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	se...@chromium.org
Closed:	Mar 2016
Cc:	ma...@chromium.org
Components:	UI>Browser>Autofill>Predictions
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	3
Type:	Bug

Ignore address nickname and other address naming fields.

Project Member Reported by se...@chromium.org, Mar 22 2016

Issue description

Some websites have a field to give a name to the address. Autofill currently sees those fields as address line 1 fields. These fields should not be filled.

Example:

Costco.com

Field name: addressFormInlineAddressNickName 
Field label: Address Nickname

store.scholastic.com

Field name: label
Field label: Address Label

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/477a7e9549f46f1e7aa30e4e55da85cb08be264b

commit 477a7e9549f46f1e7aa30e4e55da85cb08be264b
Author: sebsg <sebsg@chromium.org>
Date: Wed Mar 23 15:46:50 2016

Some forms have "Address Nickname" or "Address Label" fields that are used to identify an address. These fields were filled as address line 1.

Added a regex to find those specific fields and not fill them.

BUG= 596913 
TEST=FormStructureBrowserTest

Review URL: https://codereview.chromium.org/1825133002

Cr-Commit-Position: refs/heads/master@{#382851}

[add] https://crrev.com/477a7e9549f46f1e7aa30e4e55da85cb08be264b/chrome/test/data/autofill/heuristics/input/146_checkout_store.scholastic.com.html
[modify] https://crrev.com/477a7e9549f46f1e7aa30e4e55da85cb08be264b/chrome/test/data/autofill/heuristics/output/100_checkout_costco.com.out
[add] https://crrev.com/477a7e9549f46f1e7aa30e4e55da85cb08be264b/chrome/test/data/autofill/heuristics/output/146_checkout_store.scholastic.com.out
[modify] https://crrev.com/477a7e9549f46f1e7aa30e4e55da85cb08be264b/components/autofill/core/browser/address_field.cc
[modify] https://crrev.com/477a7e9549f46f1e7aa30e4e55da85cb08be264b/components/autofill/core/browser/autofill_regex_constants.cc
[modify] https://crrev.com/477a7e9549f46f1e7aa30e4e55da85cb08be264b/components/autofill/core/browser/autofill_regex_constants.h

Comment 2 by se...@chromium.org, Mar 23 2016

Status: Fixed (was: Started)

►

Issue 596913 link

Issue metadata

Ignore address nickname and other address naming fields.

Issue description

Comment 1 by bugdroid1@chromium.org, Mar 23 2016

Comment 1 Deleted

Comment 2 by se...@chromium.org, Mar 23 2016

Comment 2 Deleted

Sign in to add a comment