OmniboxTest#testRequestZeroSuggestAfterDelete failing on low end devices |
||
Issue descriptionTest is failing consistently on Lollipop Low-end Tester (as well as internal svelte bots). C 1150.330s Main [FAIL] org.chromium.chrome.browser.omnibox.OmniboxTest#testRequestZeroSuggestAfterDelete: C 1150.330s Main junit.framework.AssertionFailedError: Values did not match. Expected: 1, actual: 2 C 1150.330s Main at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:74) C 1150.330s Main at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:89) C 1150.330s Main at org.chromium.chrome.browser.omnibox.OmniboxTest.testRequestZeroSuggestAfterDelete(OmniboxTest.java:204) C 1150.330s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) C 1150.330s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) C 1150.330s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) C 1150.330s Main at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:793) C 1150.330s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) C 1150.330s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) C 1150.330s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 1150.330s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 1150.331s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555) C 1150.331s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853) https://build.chromium.org/p/chromium.android/builders/Lollipop%20Low-end%20Tester/builds/2812/steps/Instrumentation%20test%20chrome_public_test_apk/logs/stdio First failure was at: https://build.chromium.org/p/chromium.android/builders/Lollipop%20Low-end%20Tester/builds/2781 Two CLs in that bot's blame list jump out: 378652175b71acfd40a95d9a5c413261290227ed Refactor the logic that triggers autocomplete requests on Android. 62a928390ba06db29576bbb32606696b3e16a66c Implement a new IDN display policy cc'ing authors of those.
,
Mar 22 2016
Hmm...doesn't repro on KK svelte. Will need to find a lollipop build.
,
Mar 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8849b0dbc979ee32c24c4bc74cb1d09f06ea966e commit 8849b0dbc979ee32c24c4bc74cb1d09f06ea966e Author: tedchoc <tedchoc@chromium.org> Date: Thu Mar 24 21:00:10 2016 Ignore text updates where the size is 0 before and after for autocomplete. On Svelte devices, after clearing the text the IME was issuing a batch edit and adjusting the composing text with a 0 length string. We should ignore such updates. TEST=OmniboxTest#testRequestZeroSuggestAfterDelete (on L svelte) BUG= 596906 Review URL: https://codereview.chromium.org/1829113002 Cr-Commit-Position: refs/heads/master@{#383144} [modify] https://crrev.com/8849b0dbc979ee32c24c4bc74cb1d09f06ea966e/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
,
Mar 24 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by tedc...@chromium.org
, Mar 22 2016Owner: tedc...@chromium.org
Status: Started (was: Untriaged)