New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 596890 link

Starred by 4 users
Status: WontFix
Owner: ----
Closed: Jul 2017
Cc:
█ bruthig@chromium.org
est...@chromium.org
varkha@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug-Regression

Blocking:
issue 495654



Sign in to add a comment

The Material Design ripple should not be clipped to the location bar bounds

Project Member Reported by bruthig@chromium.org, Mar 22 2016 
The LocationBarView was configured to mask to bounds in https://codereview.chromium.org/1724333002, however this also causes the ripple to be clipped as well.  See attached "omnibox ripple acutal.png".

It should be possible to expose cc::Layer::SetClipParent() to ui::Layer and  use this so that ripples are not clipped to parent layers.
omnibox ripple actual.png
1.8 KB View Download
omnibox ripple expected.png
2.1 KB View Download

Comment 1 by tdander...@chromium.org, Mar 22 2016

Labels: -Type-Bug OS-Linux OS-Windows Type-Bug-Regression
To be clear, https://codereview.chromium.org/1724333002 caused this regression in M-50. But this is not noticeable in material-hybrid mode (the location bar is taller) and is barely noticeable in material, so I would not consider it a priority to fix and merge back to M-50. Keeping this targeted at M-51.

Comment 2 by tdander...@chromium.org, Mar 23 2016

Labels: -Pri-2 -M-51 Pri-3

Comment 3 by pkasting@chromium.org, May 4 2016

Blocking: 495654
Labels: M-53
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 15 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 17 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by varkha@chromium.org, Jul 17 2017

Status: WontFix (was: Untriaged)
Those icons are using flood-fill ripple now so this bug is WontFix. See attachment for the current look when pressed.
star-ripple.png
2.0 KB View Download
►

Sign in to add a comment