The blame list links from data points on graphs like this (link from a buildbot build): https://chromeperf.appspot.com/report?sid=f8bd7c10aded801e6b6824399d8b8a5823709350f0803d54149786bfae0ce80f&rev=12087 looks like this: https://chromium.googlesource.com/chromium/src/+log/beb9798ab4c334617e3023a9c2811e1e34b5a49f..9d657cfd664122541086e5ab7ca19b25f1c4b90e They aren't using the right base URL (https://chromium.googlesource.com/external/webrtc), making it harder for sheriffs to triage properly. It should look like this: https://chromium.googlesource.com/external/webrtc/+log/beb9798ab4c334617e3023a9c2811e1e34b5a49f..9d657cfd664122541086e5ab7ca19b25f1c4b90e
Related catapult issue: https://github.com/catapult-project/catapult/issues/1922
I'm attaching an example log from https://build.chromium.org/p/client.webrtc.perf/builders/Linux%20Trusty/builds/147 It shows for the runtest.py invocation: --revision=15324 --perf-config '{'\''a_default_rev'\'': '\''r_webrtc_rev'\''}' and factory/build-properties: "git_revision": "8d66a5a3b18eef73b238f4220477da265bf4494b", "revision": "8d66a5a3b18eef73b238f4220477da265bf4494b", "project": "webrtc", "repository": "https://chromium.googlesource.com/external/webrtc" and at the end: {"supplemental_columns": {"r_webkit_rev": "435081 r_chromium": "8d66a5a3b18eef73b238f4220477da265bf4494b a_default_rev": "r_webrtc_rev a_stdio_uri": "[Buildbot stdio](http://build.chromium.org/p/client.webrtc.perf/builders/Linux%20Trusty/builds/147/steps/isac_fix_test/logs/stdio)"}, "bot": "webrtc-linux-large-tests value": "51.0 units": "us master": "WebRTCPerf error": "0.0 test": "isac_fix_test/isac/time_per_10ms_frame revision": 15324 }] Note that r_webrtc_rev is not passed, which is probably what should be fixed first. Next step is to figure out how to get the mapping of the repository to be the one showing up in the change log link (might need upstreaming to catapult).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/40ae1fb78554f3932653b17261e31d7976eca5d8 commit 40ae1fb78554f3932653b17261e31d7976eca5d8 Author: Henrik Kjellander <kjellander@chromium.org> Date: Wed Nov 30 15:05:43 2016 WebRTC: Report Git revision properly for perf tests. This works for V8 so it's likely it will work out of the box for us. We've been missing reporting of r_webrtc_rev for a long time, and since the Git migration is seems the _git suffix is preferred. BUG= 596883 , 491520 TBR=tandrii@chromium.org Change-Id: Ic8642c4b02799beac6435329354f730c75b4a4ad Reviewed-on: https://chromium-review.googlesource.com/414872 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Henrik Kjellander <kjellander-cc@chromium.org> [modify] https://crrev.com/40ae1fb78554f3932653b17261e31d7976eca5d8/scripts/slave/recipe_modules/chromium/api.py [modify] https://crrev.com/40ae1fb78554f3932653b17261e31d7976eca5d8/scripts/slave/recipe_modules/webrtc/api.py [modify] https://crrev.com/40ae1fb78554f3932653b17261e31d7976eca5d8/scripts/slave/recipe_modules/webrtc/builders.py [modify] https://crrev.com/40ae1fb78554f3932653b17261e31d7976eca5d8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__j_nexus4_.json [modify] https://crrev.com/40ae1fb78554f3932653b17261e31d7976eca5d8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__k_nexus5_.json [modify] https://crrev.com/40ae1fb78554f3932653b17261e31d7976eca5d8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__l_nexus6_.json [modify] https://crrev.com/40ae1fb78554f3932653b17261e31d7976eca5d8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5_.json [modify] https://crrev.com/40ae1fb78554f3932653b17261e31d7976eca5d8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json [modify] https://crrev.com/40ae1fb78554f3932653b17261e31d7976eca5d8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced.json [modify] https://crrev.com/40ae1fb78554f3932653b17261e31d7976eca5d8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus6_.json [modify] https://crrev.com/40ae1fb78554f3932653b17261e31d7976eca5d8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus7_2_.json [modify] https://crrev.com/40ae1fb78554f3932653b17261e31d7976eca5d8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json [modify] https://crrev.com/40ae1fb78554f3932653b17261e31d7976eca5d8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_linux_trusty.json [modify] https://crrev.com/40ae1fb78554f3932653b17261e31d7976eca5d8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_mac_10_11.json [modify] https://crrev.com/40ae1fb78554f3932653b17261e31d7976eca5d8/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_win7.json
The CL above and configuration for 'r_webrtc_git' at https://chromeperf.appspot.com/edit_site_config?key=revision_info made "WebRTC Git Hash range show up". I verified at https://chromeperf.appspot.com/report?sid=6bbac291d20cf816960ffcc9939dc316868c696efd5a11184e61f7e74c5d6867&rev=15346
Comment 1 by kjellander@chromium.org
, Mar 22 2016