New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596882 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3% regression in webrtc.getusermedia at 382516:382518

Project Member Reported by alexclarke@chromium.org, Mar 22 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=596882

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgkLrLvwoM


Bot(s) for this bug's original alert(s):

android-nexus6
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Mar 22 2016

Cc: catapult-deps-roller@chromium.org
Owner: catapult-deps-roller@chromium.org

=== Auto-CCing suspected CL author catapult-deps-roller@chromium.org ===

Hi catapult-deps-roller@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Roll src/third_party/catapult/ 8d9e4952d..c52974880 (1 commit).
Author  : catapult-deps-roller
Commit description:
  
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8d9e4952d037..c52974880be8

$ git log 8d9e4952d..c52974880 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1819823003

Cr-Commit-Position: refs/heads/master@{#382518}
Commit  : 0fbcbd2b96fee4d6bd5fc7f4700225bc4af9b442
Date    : Tue Mar 22 06:36:49 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@382515         25930.66666734.840589   6           good
chromium@382517         25962.4     43.689816   5           good
chromium@382518         26668.0     74.993333   5           bad

Bisect job ran on: android_nexus6_perf_bisect
Bug ID: 596882

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --also-run-disabled-tests webrtc.getusermedia
Test Metric: vm_private_dirty_final_browser/vm_private_dirty_final_browser
Relative Change: 2.83%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus6_perf_bisect/builds/2046
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9017481294551656096


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 22 2016


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Roll src/third_party/catapult/ 8d9e4952d..c52974880 (1 commit).
Author  : catapult-deps-roller
Commit description:
  
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8d9e4952d037..c52974880be8

$ git log 8d9e4952d..c52974880 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1819823003

Cr-Commit-Position: refs/heads/master@{#382518}
Commit  : 0fbcbd2b96fee4d6bd5fc7f4700225bc4af9b442
Date    : Tue Mar 22 06:36:49 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@382515         25926.4     98.897927   5           good
chromium@382517         25966.4     29.065443   5           good
chromium@382518         26771.2     77.531929   5           bad

Bisect job ran on: android_nexus6_perf_bisect
Bug ID: 596882

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --also-run-disabled-tests webrtc.getusermedia
Test Metric: vm_private_dirty_final_browser/vm_private_dirty_final_browser
Relative Change: 3.26%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus6_perf_bisect/builds/2047
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9017481289209465728


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!
Status: WontFix (was: Assigned)
Bisect doesn't reproduce. Looks like this may have been caused by a device swap.
Owner: bashi@chromium.org
Status: Assigned (was: WontFix)
Sorry, wrong bug. bashi, we're seeing a 3% regression in the catapult roll, which only contains this CL:
https://codereview.chromium.org/1825453002

Is it expected?

Comment 6 by bashi@chromium.org, Mar 28 2016

Owner: sullivan@chromium.org
I don't think the CL affects performance. It changed the condition for installing test certificate.
Owner: nednguyen@chromium.org
Status: WontFix (was: Assigned)
Hmm, actually the memory improves in the graph slightly before this, where the catapult roll with the disable is: https://codereview.chromium.org/1812993003

And then when the test certificate is installed, the memory goes up again.

I don't think this is an actual performance issue, just making the test more realistic, but it does seem to be the cause for the change. WontFix-ing and assigning to Ned since he made the original change, in case he has any reason to investigate further.
Cc: primiano@chromium.org perezju@chromium.org petrcermak@chromium.org
My guess is handling the certificate consume more memory than just ignore it. Though it's interesting that the code for handling the certificate consumes 3% memory.

+memory folks if you find this interesting as well.
Cc: dskiba@chromium.org ssid@chromium.org
+ssid +dskiba FIY about the memory usage due to the certificate.
Note: this time it's on Android.

Sign in to add a comment