Issue metadata
Sign in to add a comment
|
After launching Chrome, suggested sites show up slowly on the NTP |
||||||||||||||||||||||
Issue descriptionVersion: 51.0.2680.0 OS: Android What steps will reproduce the problem? (1) Make sure Chrome is not running and that the Snippets flag is enabled (2) Launch Chrome (3) Open a new tab What is the expected output? - 8 site suggestions and snippets What do you see instead? - 4 site suggestions with snippets (screenshot 1) - a second row of 4 site suggestions comes in a couple of seconds later (screenshot 2) Please use labels and text to provide additional information.
,
Mar 22 2016
,
Mar 22 2016
Have you tried with the Zine experiment disabled? This looks like a general NTP problem unrelated to snippets.
,
Mar 22 2016
I disabled the snippets experiment and get the same experience. I verified that Beta works well for me. It reliably reproduces for me on Chrome Canary. The first row of icons I get is always different from the first row of icons I get a couple seconds later.
,
Mar 22 2016
,
Mar 22 2016
More data: I just cleared my app data, signed in again, visited a site and went back to the NTP. What I get is: 1) First row shows just a single icon: the site I just visited (so seems to becoming from Top Sites) 2) A couple of seconds later the first and second row show ML icons
,
Mar 31 2016
I can't reproduce this yet on 51.0.2690.0
,
Mar 31 2016
Sorry I can reproduce this on my private phone too.
,
Mar 31 2016
,
Mar 31 2016
Thanks for reproducing Markus! Marc, once we've fixed this we should make sure to merge this back to any branches that could be affected.
,
Mar 31 2016
Wait, why is this labeled M50? The CL I'm suspecting landed well after the M50 branch point. So no merging should be required.
,
Mar 31 2016
Mhm, sadly I didn't leave a comment for that milestone target - might have been a mistake (my repro was on M51 Canary). We should just verify that the issue only exists in M51 :). Thanks!
,
Mar 31 2016
,
Mar 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba0dee760b7e0f02631ed33a8aa3dcf6dbcbeb8d commit ba0dee760b7e0f02631ed33a8aa3dcf6dbcbeb8d Author: treib <treib@chromium.org> Date: Thu Mar 31 13:25:59 2016 Android NTP: only query TopSites if SuggestionsService has nothing in the cache BUG= 596857 Review URL: https://codereview.chromium.org/1850673002 Cr-Commit-Position: refs/heads/master@{#384260} [modify] https://crrev.com/ba0dee760b7e0f02631ed33a8aa3dcf6dbcbeb8d/chrome/browser/android/ntp/most_visited_sites.cc
,
Mar 31 2016
Should be fixed! Please verify on the next Canary/Dev build :)
,
Mar 31 2016
Will do! Thanks for the fast turnaround! :) |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by nepper@chromium.org
, Mar 22 2016