Regression: Header text is not clickable using tap/touch after changing option for cast overlay.
Reported by
jshan...@etouch.net,
Mar 22 2016
|
|||||||
Issue descriptionChrome Version: 51.0.2687.0 (Official Build) 5ee3f242cefebba7eb0f05424e7308f9158d8388-refs/heads/master@{#382459}-32/64 bit OS: Windows(Touch device) Pre-condition: Enabled 'Media Router' flag from chrome://flags Steps: 1. Launch chrome and click on 'Cast' option from wrench menu. 2. Tap/touch on 'Cast to' option and then change it to 'Cast desktop/Cast Tab' 3. Now tap/touch on 'Cast desktop/Cast Tab' and observe. Actual: Unable to open 'Select source' overlay using tap/touch on 'Cast desktop/Cast Tab' for first instance. Expected: 'Select source' overlay should be open using tap/touch on 'Cast desktop/Cast Tab' for first instance. This is a regression issue broken in M-50, below is bisect info. Good build: 50.0.2630.0 Bad build: 50.0.2631.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/00055282bebe9c692443d0bcb44fb4e9e008daeb..3647a2e3c8476adfc7aba16eb12b7f3e13648ec6?pretty=fuller&n=10 Suspecting: r371379 ? Please help to reassign if your change is not the cause Note: This is touch device specific issue, same works fine on mouse click.
,
Mar 25 2016
I see it on M49 stable as well on a surface; the suspected CL in the bisect did not introduce this. I can also now repro this on other platforms, which will make debugging easier.
,
Mar 25 2016
It looks like switching to checking for tap events rather than just click fixes this. Also from the docs -- "Use on-tap rather than on-click for an event that fires consistently across both touch (mobile) and click (desktop) devices."
,
Mar 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6d78f039a327f70412ccdb2c03a341c7f1fc8af commit b6d78f039a327f70412ccdb2c03a341c7f1fc8af Author: apacible <apacible@chromium.org> Date: Fri Mar 25 23:07:09 2016 [Media Router WebUI] Switch on-click to on-tap for consistent event listening. Previously, we used on-click for user click events, which made touch screen interactions inconsistent. This change switches all on-click listeners to on-tap, which listens for a event that fires consistently on touch/click platforms. Tested with the --simulate-touch-screen-with-mouse and enabling touch events in Chrome DevTools. BUG= 596844 Review URL: https://codereview.chromium.org/1839433002 Cr-Commit-Position: refs/heads/master@{#383395} [modify] https://crrev.com/b6d78f039a327f70412ccdb2c03a341c7f1fc8af/chrome/browser/resources/media_router/elements/issue_banner/issue_banner.html [modify] https://crrev.com/b6d78f039a327f70412ccdb2c03a341c7f1fc8af/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html [modify] https://crrev.com/b6d78f039a327f70412ccdb2c03a341c7f1fc8af/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.html [modify] https://crrev.com/b6d78f039a327f70412ccdb2c03a341c7f1fc8af/chrome/browser/resources/media_router/elements/route_details/route_details.html
,
Mar 28 2016
Verified on today's Canary with a surface pro. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by apaci...@chromium.org
, Mar 22 2016