New issue
Advanced search Search tips

Issue 596825 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

16.6% regression in blink_perf.css at 382304:382307

Project Member Reported by alexclarke@chromium.org, Mar 22 2016

Issue description

Seems this partially recovered but there's still some overall regression.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=596825

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgkOyDqQoM


Bot(s) for this bug's original alert(s):

chromium-rel-win8-dual
I also kicked off another few bisects.
Cc: bmeu...@chromium.org mvstan...@chromium.org
Components: Blink>JavaScript
Owner: ----
Status: Untriaged (was: Assigned)
Bisect bot narrowed to the V8 roll: ae7184b6f12adfa37ecca0fbae511aa68fa080e6

Revision range: https://chromium.googlesource.com/v8/v8/+log/93550712..4d1d2c2f

Nothing stands out in the range. Handing over to V8 perf sheriffs.
Owner: verwa...@chromium.org
Status: Assigned (was: Untriaged)
Toon, is it possible that the culprit is https://chromium.googlesource.com/v8/v8/+/75ed4a6071a4a2561136173882c8f48432d5c2cd ?
Seems quite unlikely, but I'll verify.
Arg. Obviously it was. Will be fixed by https://codereview.chromium.org/1874303002
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/39d121d1e3c334875052acda54f28551a89f6f3e

commit 39d121d1e3c334875052acda54f28551a89f6f3e
Author: verwaest <verwaest@chromium.org>
Date: Mon Apr 11 16:03:49 2016

Properly set up the code flags of the turbofan interceptor stubs.

Otherwise they can't be found in the megamorphic cache, leading to repeated misses.

BUG= chromium:596825 
LOG=n

Review URL: https://codereview.chromium.org/1874303002

Cr-Commit-Position: refs/heads/master@{#35393}

[modify] https://crrev.com/39d121d1e3c334875052acda54f28551a89f6f3e/src/code-factory.cc
[modify] https://crrev.com/39d121d1e3c334875052acda54f28551a89f6f3e/src/code-factory.h
[modify] https://crrev.com/39d121d1e3c334875052acda54f28551a89f6f3e/src/code-stubs.h
[modify] https://crrev.com/39d121d1e3c334875052acda54f28551a89f6f3e/src/ic/ic.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/39d121d1e3c334875052acda54f28551a89f6f3e

commit 39d121d1e3c334875052acda54f28551a89f6f3e
Author: verwaest <verwaest@chromium.org>
Date: Mon Apr 11 16:03:49 2016

Properly set up the code flags of the turbofan interceptor stubs.

Otherwise they can't be found in the megamorphic cache, leading to repeated misses.

BUG= chromium:596825 
LOG=n

Review URL: https://codereview.chromium.org/1874303002

Cr-Commit-Position: refs/heads/master@{#35393}

[modify] https://crrev.com/39d121d1e3c334875052acda54f28551a89f6f3e/src/code-factory.cc
[modify] https://crrev.com/39d121d1e3c334875052acda54f28551a89f6f3e/src/code-factory.h
[modify] https://crrev.com/39d121d1e3c334875052acda54f28551a89f6f3e/src/code-stubs.h
[modify] https://crrev.com/39d121d1e3c334875052acda54f28551a89f6f3e/src/ic/ic.cc

Status: Fixed (was: Assigned)
Looks like these metrics have all recovered now that v8:r35468 has rolled into chromium.

Sign in to add a comment