New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596803 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
NOT IN USE
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Video full screen is not proper in play.google.com.

Reported by lpa...@etouch.net, Mar 22 2016

Issue description

Chrome Version: 51.0.2687.0 (Official Build) 5ee3f242cefebba7eb0f05424e7308f9158d8388-refs/heads/master@{#382459} 32/64 bit.
OS: Windows, Linux (Win 7 Aero-Enabled)
Pre-condition: Go to chrome://components >> Widevine Content Decryption Module >> click 'Check for update'  (IF REQUIRED)

Steps: 
1. Launch chrome and navigate to https://play.google.com/store/movies/details/In_the_Heart_of_the_Sea?id=2Mq6z-IlECA&hl=en
2. Play the video and click on full screen icon.
3. Observe the video in full screen mode.

Actual: Video full screen is not proper.

Expected: Video full screen should be proper.

This is a regression issue broken in M-51, will soon update the other info.
 

Comment 1 by lpa...@etouch.net, Mar 22 2016

Components: Blink>Fullscreen
Labels: hasbisect OS-Mac
Owner: r...@opera.com
Status: Assigned (was: Unconfirmed)
Manual Regression Range:
Good Build: 51.0.2686.0
Bad Build: 51.0.2687.0

Providing Change log url as  'WidevineCdm component' is not available in chromium builds:
https://chromium.googlesource.com/chromium/src/+log/51.0.2686.0..51.0.2687.0?pretty=fuller&n=10000 

Suspecting: r382405 ?

Please re-assign if your change is not the cause of this issue. 
Actual.mp4
1.2 MB Download
Expected.mp4
557 KB Download

Comment 2 by r...@opera.com, Mar 22 2016

That's most certainly r382405. I'll probably have to revert to using a full style recalc, but I'd like to keep the change where we don't check for loaded UA style for every element, so please don't revert. I'll upload a new CL.

Labels: ReleaseBlock-Beta
Adding release block label, please undo if not the case.

Comment 4 by r...@opera.com, Mar 22 2016

So, I cannot reproduce this as I cannot build Chrome, thus I don't have WidevineCdm. Have you seen problems with other fullscreen'ed video? I have tested youtube which didn't seem to have a problem.

Comment 5 by r...@opera.com, Mar 23 2016

Patch for review: https://codereview.chromium.org/1823143002/

Comment 6 by r...@opera.com, Mar 23 2016

Status: Started (was: Assigned)
Still able to reproduce the issue on Windows 7, Mac 10.10.5, Ubuntu 14.04 using latest M-51(51.0.2692.0).Observed that Video full screen is not proper.
Please find attached screencast.

rune@Could you please look into this.
596803.mp4
1.2 MB Download

Comment 8 by r...@opera.com, Mar 29 2016

Cc: r...@opera.com
 Issue 598276  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a71fcc137ef2e4a78c93ecb15e1623ca9b3eb65

commit 7a71fcc137ef2e4a78c93ecb15e1623ca9b3eb65
Author: rune <rune@opera.com>
Date: Tue Mar 29 13:41:43 2016

Ensure fullscreen.css loaded for ancestor invalidation

Using invalidation sets caused regression  crbug.com/596803  because we
only ensured the fullscreen.css had features available for style
resolving in the fullscreened element's document. This CL ensures the
features are up-to-date for all fullscreen related pseudoStateChanged.

I was not able to reproduce the problem in 596803, but 448721 also
regressed and I've confirmed this CL fixes that regression.

The added layout test does not fail without this fix because the
full screen implementation in content_shell is different and
setMediaType() for fullscreen on resize causes a full recalc of
everything in content_shell before we try to apply fullscreen style
changes. However, if mediaQueryAffectingValueChanged was smarter when
changing media type to fullscreen. That test would have failed.

BUG= 596803 

Review URL: https://codereview.chromium.org/1823143002

Cr-Commit-Position: refs/heads/master@{#383711}

[add] https://crrev.com/7a71fcc137ef2e4a78c93ecb15e1623ca9b3eb65/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style-expected.txt
[add] https://crrev.com/7a71fcc137ef2e4a78c93ecb15e1623ca9b3eb65/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html
[modify] https://crrev.com/7a71fcc137ef2e4a78c93ecb15e1623ca9b3eb65/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/7a71fcc137ef2e4a78c93ecb15e1623ca9b3eb65/third_party/WebKit/Source/core/dom/Fullscreen.cpp

Comment 11 by r...@opera.com, Mar 29 2016

Status: Fixed (was: Started)

Comment 12 by r...@opera.com, Mar 29 2016

Status: Fixed (was: Started)

Comment 13 by r...@opera.com, Mar 30 2016

Cc: alex...@chromium.org timloh@chromium.org
 Issue 598911  has been merged into this issue.
Cc: william.xie@chromium.org
 Issue 598187  has been merged into this issue.

Sign in to add a comment