New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596796 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Need more log on the client side for the network activities

Project Member Reported by klo...@chromium.org, Mar 22 2016

Issue description

While using the client, I got a network connection error, try to reload, nothing happens.

Looking at the logs, I only saw the following from pid 15270, which is the client app.
03-22 00:12:10.230 15270 15295 I chromium: [INFO:client_connection_manager.cc(92)] Connection dropped, error=-100
03-22 00:12:10.289 15270 15295 W chromium: [WARNING:client_connection_manager.cc(49)] All transports failed to connect

To help understand what happened, we should take advantage of the logs now. Please add more logging.

Mark it as P1 as I think we need them sooner than later.
 
klobag@, did you see google.com page and then navigate to other website before this network error? 

Comment 2 by w...@chromium.org, Mar 22 2016

Re #1: This bug is for adding more diagnostic logging; please make sure there is a separate bug for the actual connectivity issue that Grace mentions.

Comment 3 by klo...@chromium.org, Mar 22 2016

Sure, filed crbug/597004 for network error.

As I mentioned in crbug/596797, I suggest to log for both success and failure case. As the app is for testing only, we have freedom to write a lot of info there.
Owner: sriramsr@chromium.org
Fowrarding to Sriram. He is also writing up instruction to get server logs.
Owner: haibinlu@chromium.org
assign back to myself for diagnosing.  Waiting for Sriram to gets the Engine log.
This is caused by big CC message, which is rejected by blimp connection.

Engine logs:

[8:30:0322/195520:ERROR:blimp_connection.cc(69)] Message rejected (too large): <BlimpMessage type=COMPOSITOR target_tab_id=0 byte_size=4361225>
[8:30:0322/195520:WARNING:blimp_message_output_buffer.cc(153)] Write error (result=-142)
[8:28:0322/195522:ERROR:zygote_host_impl_linux.cc(162)] Failed to adjust OOM score of renderer with pid 94: Permission denied
[8:8:0322/195522:FATAL:surface_manager.cc(257)] Check failed: valid_surface_id_namespaces_.count(parent_namespace) == 1u (0 vs. 1)

Cc: -marshall@chromium.org
You probably chose the wrong Marshall :)
filed crbug/597026 for fixing message size issue. Closing this bug.

Comment 9 by w...@chromium.org, Mar 22 2016

Haibin, as I mentioned earlier, this bug is for tracking the client-side logging improvements - Grace filed  issue 597004  for the actual network issue, so can you please reconcile that w/ the new bug you filed? Thanks.
Status: Fixed (was: Assigned)
If you specify command line arguments below after installing the Client apk, "adb logcat" will show all incoming and outgoing message activities. 

./build/android/adb_blimp_command_line  --vmodule="blimp_message_pump=2, blimp_connection=2"  --enable-logging=stderr --enable-logging

Comment 11 by w...@chromium.org, Mar 29 2016

Status: Assigned (was: Fixed)
Let's enable the verbose logging for those modules by default, in the client's main.
Status: Started (was: Assigned)
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ae0ee4d57c0da9a27ff1f44d4346ba5c16e2a66

commit 5ae0ee4d57c0da9a27ff1f44d4346ba5c16e2a66
Author: haibinlu <haibinlu@chromium.org>
Date: Tue Mar 29 22:01:08 2016

so that users does not have to specify command line arguments.

It generates logs:

V/chromium(22041): [VERBOSE1:blimp_message_pump.cc(59)] Received <BlimpMessage type=COMPOSITOR target_tab_id=0 byte_size=61379>
V/chromium(22041): [VERBOSE1:blimp_connection.cc(66)] Sending <BlimpMessage type=PROTOCOL_CONTROL subtype=CHECKPOINT_ACK checkpoint_id=20 byte_size=15>

BUG= 596796 

Review URL: https://codereview.chromium.org/1841183002

Cr-Commit-Position: refs/heads/master@{#383840}

[modify] https://crrev.com/5ae0ee4d57c0da9a27ff1f44d4346ba5c16e2a66/blimp/client/app/blimp_startup.cc
[modify] https://crrev.com/5ae0ee4d57c0da9a27ff1f44d4346ba5c16e2a66/blimp/net/blimp_connection.cc
[modify] https://crrev.com/5ae0ee4d57c0da9a27ff1f44d4346ba5c16e2a66/blimp/net/blimp_message_pump.cc

Status: Fixed (was: Started)
Labels: Archive-Blimp

Sign in to add a comment