New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 596781 link

Starred by 4 users
Status: Fixed
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: Jul 2016
Cc:
calamity@chromium.org
nyerramilli@chromium.org
tbuck...@chromium.org
█ tkonch...@chromium.org
█ tsergeant@chromium.org
bettes@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

MD History appears in incognito mode

Project Member Reported by calamity@chromium.org, Mar 22 2016 
Old history would redirect to main window to show the actual page. This was the case with history, settings, extensions etc. Should we try to keep this behavior in MD History?

Assigning to dbeam@ for triage.

Comment 1 by dbeam@chromium.org, Mar 22 2016 

unless there's something to useful to show in the incognito case, we should re-use the existing code/behavior:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/chrome_pages.cc&sq=package:chromium&type=cs&l=154&rcl=1458660716

for MD/pre-MD downloads: we show both downloads started while incognito (with a little marker) and from the original profile.
2016-03-22-135852_852x533_scrot.png
47.2 KB View Download

Comment 2 by dbeam@chromium.org, Mar 22 2016

Cc: tbuck...@chromium.org bettes@chromium.org

Comment 3 by omrilio@chromium.org, Mar 24 2016

Status: Assigned (was: Untriaged)

Comment 4 by msramek@chromium.org, Mar 29 2016

Components: Privacy

Comment 5 by tsergeant@chromium.org, Jun 21 2016

Components: UI>Browser>History
Labels: Proj-MaterialDesign-WebUI

Comment 6 by tsergeant@chromium.org, Jun 21 2016

Cc: nyerramilli@chromium.org tkonch...@chromium.org
 Issue 621470  has been merged into this issue.

Comment 7 by tsergeant@chromium.org, Jul 11 2016

Owner: tsergeant@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f057c9421a0d0a5978f93cbf13a33378cbb84a7a

commit f057c9421a0d0a5978f93cbf13a33378cbb84a7a
Author: tsergeant <tsergeant@chromium.org>
Date: Tue Jul 12 00:46:06 2016

Disable MD History in Incognito windows

All Uber pages are disabled in Incognito, which implicitly disabled
non-Material history. However, Material history does not use Uber UI and
so was not included in the blacklist. This CL adds chrome://history to
the blacklist to explicitly disable it in Incognito windows.

BUG= 596781 ,  624270 

Review-Url: https://codereview.chromium.org/2140493002
Cr-Commit-Position: refs/heads/master@{#404755}

[modify] https://crrev.com/f057c9421a0d0a5978f93cbf13a33378cbb84a7a/chrome/browser/ui/browser_navigator.cc

Comment 9 by tsergeant@chromium.org, Jul 12 2016

Status: Fixed (was: Started)
►

Sign in to add a comment