New issue
Advanced search Search tips

Issue 596760 link

Starred by 10 users
Status: Fixed
Owner: ----
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocked on:
issue 596522
issue 598886
issue 638849
issue 672699
issue 697685
issue 697687
issue 697688
issue 697692
issue 707638
issue 707641
issue 707642
issue 708056
issue 708057
Blocking:
issue 565765



Sign in to add a comment

Reduce usage of macros defined in wtf/Assertions.h

Project Member Reported by tkent@chromium.org, Mar 22 2016 
We should replace macros defined in wtf/Assertions.h with macros defined in base/logging.h.
  *ASSERT*() -> *CHECK*()
  ASSERT_NOT_REACHED() -> NOTREACHED()
  ENABLE(ASSERT) -> DCHECK_IS_ON()
  FATAL() -> DLOG(FATAL)
  WTF_LOG_ERROR() -> DLOG(ERROR)
  WTF_LOG() -> DVLOG() or VLOG()
  etc.
Showing comments 17 - 116 of 116 Older ›
Project Member

Comment 20 by bugdroid1@chromium.org, Mar 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f378c922c0e541e42f567f0b71d4d66c23bd539f

commit f378c922c0e541e42f567f0b71d4d66c23bd539f
Author: dtapuska <dtapuska@chromium.org>
Date: Wed Mar 30 03:49:16 2016

Remove HTMLPlugin WTF logging.

Replace two Plugins logging with VLOG(1). This has a slight change in that
it uses operator<< on Node.h as opposed to logging the address of the
HTML Plugin Element; I do think this is slightly more useful than the
previous log info.

BUG=596760

Review URL: https://codereview.chromium.org/1845533002

Cr-Commit-Position: refs/heads/master@{#383902}

[modify] https://crrev.com/f378c922c0e541e42f567f0b71d4d66c23bd539f/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
[modify] https://crrev.com/f378c922c0e541e42f567f0b71d4d66c23bd539f/third_party/WebKit/Source/platform/Logging.cpp
[modify] https://crrev.com/f378c922c0e541e42f567f0b71d4d66c23bd539f/third_party/WebKit/Source/platform/Logging.h
Project Member

Comment 21 by bugdroid1@chromium.org, Mar 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f378c922c0e541e42f567f0b71d4d66c23bd539f

commit f378c922c0e541e42f567f0b71d4d66c23bd539f
Author: dtapuska <dtapuska@chromium.org>
Date: Wed Mar 30 03:49:16 2016

Remove HTMLPlugin WTF logging.

Replace two Plugins logging with VLOG(1). This has a slight change in that
it uses operator<< on Node.h as opposed to logging the address of the
HTML Plugin Element; I do think this is slightly more useful than the
previous log info.

BUG=596760

Review URL: https://codereview.chromium.org/1845533002

Cr-Commit-Position: refs/heads/master@{#383902}

[modify] https://crrev.com/f378c922c0e541e42f567f0b71d4d66c23bd539f/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
[modify] https://crrev.com/f378c922c0e541e42f567f0b71d4d66c23bd539f/third_party/WebKit/Source/platform/Logging.cpp
[modify] https://crrev.com/f378c922c0e541e42f567f0b71d4d66c23bd539f/third_party/WebKit/Source/platform/Logging.h
Project Member

Comment 22 by bugdroid1@chromium.org, Mar 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be2579d48fbb2b4c98f693ab1c62cf1a9d60a06d

commit be2579d48fbb2b4c98f693ab1c62cf1a9d60a06d
Author: tkent <tkent@chromium.org>
Date: Thu Mar 31 06:53:42 2016

Replace RELEASE_ASSERT_WITH_SECURITY_IMPLICATION with SECURITY_CHECK.

SECURITY_CHECK is based on base/logging.h.  SECURITY_CHECK is
 - equivalent to SECURITY_DCHECK if ADDRESS_SANITIZER is defined.
 - equivalent to CHECK otherwise.

It's similar to RELEASE_ASSERT_WITH_SECURITY_IMPLICATION.

BUG=596760

Review URL: https://codereview.chromium.org/1841363003

Cr-Commit-Position: refs/heads/master@{#384205}

[modify] https://crrev.com/be2579d48fbb2b4c98f693ab1c62cf1a9d60a06d/third_party/WebKit/Source/bindings/core/v8/ScriptState.h
[modify] https://crrev.com/be2579d48fbb2b4c98f693ab1c62cf1a9d60a06d/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
[modify] https://crrev.com/be2579d48fbb2b4c98f693ab1c62cf1a9d60a06d/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h
[modify] https://crrev.com/be2579d48fbb2b4c98f693ab1c62cf1a9d60a06d/third_party/WebKit/Source/core/dom/NodeRareData.cpp
[modify] https://crrev.com/be2579d48fbb2b4c98f693ab1c62cf1a9d60a06d/third_party/WebKit/Source/core/dom/ScriptRunner.cpp
[modify] https://crrev.com/be2579d48fbb2b4c98f693ab1c62cf1a9d60a06d/third_party/WebKit/Source/core/frame/DOMWindow.cpp
[modify] https://crrev.com/be2579d48fbb2b4c98f693ab1c62cf1a9d60a06d/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/be2579d48fbb2b4c98f693ab1c62cf1a9d60a06d/third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp
[modify] https://crrev.com/be2579d48fbb2b4c98f693ab1c62cf1a9d60a06d/third_party/WebKit/Source/wtf/Assertions.h
[modify] https://crrev.com/be2579d48fbb2b4c98f693ab1c62cf1a9d60a06d/third_party/WebKit/Source/wtf/PartitionAlloc.cpp
[modify] https://crrev.com/be2579d48fbb2b4c98f693ab1c62cf1a9d60a06d/third_party/WebKit/Source/wtf/PartitionAlloc.h
Project Member

Comment 23 by bugdroid1@chromium.org, Mar 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d181f524c11e0d456bc48261334beda61e6f852c

commit d181f524c11e0d456bc48261334beda61e6f852c
Author: kotenkov <kotenkov@yandex-team.ru>
Date: Thu Mar 31 07:39:50 2016

Replace all occurrences of RELEASE_ASSERT in wtf with CHECK.

BUG=596760

Review URL: https://codereview.chromium.org/1840163002

Cr-Commit-Position: refs/heads/master@{#384213}

[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/ArrayBuffer.h
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/BitArray.h
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/Deque.h
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/Functional.h
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/HashTable.h
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/Optional.h
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/PageAllocator.cpp
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/PartitionAlloc.cpp
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/PartitionAlloc.h
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/PartitionAllocator.h
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/Partitions.cpp
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/TerminatedArrayBuilder.h
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/TypedArrayBase.h
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/Vector.h
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/WTF.cpp
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/dtoa/utils.h
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/text/AtomicString.cpp
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/text/CString.cpp
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/text/StringConcatenate.cpp
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/text/StringConcatenate.h
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/text/StringImpl.cpp
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/text/StringImpl.h
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/text/TextCodecUTF16.cpp
[modify] https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c/third_party/WebKit/Source/wtf/text/WTFString.cpp
Project Member

Comment 24 by bugdroid1@chromium.org, Mar 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db675b5b6f9d0e08c13908c6ec73546ee912e2ed

commit db675b5b6f9d0e08c13908c6ec73546ee912e2ed
Author: yosin <yosin@chromium.org>
Date: Thu Mar 31 10:25:44 2016

Move Position printer to Pointer.cpp

This patch moves |Position| printer implementation to "Pointer.cpp" from
"CoreTestPrinters.cpp" to utilize |Position| printer with |DCHECK()| macros
other than unit tests and removes "CoreTestPrinters.cpp" since it is now empty.

Note: crrev.com/383236 moves |Node| printer to "Node.cpp" from
"CoreTestPrinters.cpp"

BUG=596760
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1843403002

Cr-Commit-Position: refs/heads/master@{#384238}

[modify] https://crrev.com/db675b5b6f9d0e08c13908c6ec73546ee912e2ed/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/db675b5b6f9d0e08c13908c6ec73546ee912e2ed/third_party/WebKit/Source/core/editing/Position.cpp
[modify] https://crrev.com/db675b5b6f9d0e08c13908c6ec73546ee912e2ed/third_party/WebKit/Source/core/editing/Position.h
[delete] https://crrev.com/f6c2701c8ad1c3dbde1aafb69f66861dfd1159ec/third_party/WebKit/Source/core/testing/CoreTestPrinters.cpp
Project Member

Comment 25 by bugdroid1@chromium.org, Apr 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/151deeb377f9456660e9ab835d1c7fa46edc7499

commit 151deeb377f9456660e9ab835d1c7fa46edc7499
Author: kotenkov <kotenkov@yandex-team.ru>
Date: Fri Apr 01 17:56:23 2016

RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

BUG=596760

Review URL: https://codereview.chromium.org/1839643009

Cr-Commit-Position: refs/heads/master@{#384626}

[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/AssociatedURLLoader.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/AudioOutputDeviceClientImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/ColorChooserUIController.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/ContextFeaturesClientImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/DatabaseClientImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/DragClientImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/FindInPageCoordinates.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/FullscreenController.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/InspectorOverlay.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/LinkHighlightImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/LocalFileSystemClient.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/PageOverlay.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/PopupMenuImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/RemoteFrameOwner.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/RotationViewportAnchor.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/StorageQuotaClientImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/TextFinder.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/TextFinder.h
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebAXObject.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebArrayBufferConverter.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebBlob.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebCache.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebDOMActivityLogger.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebDOMFileSystem.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebDataSourceImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebDocument.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebElementTest.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebEntities.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebFrame.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebFrameSerializer.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebGeolocationController.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebGeolocationPermissionRequestManager.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebHeap.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebImageDecoder.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebInputEventConversion.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebKit.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebLeakDetector.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebMediaDevicesRequest.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebNode.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebScopedWindowFocusAllowedIndicator.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebSelection.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebSettingsImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebSpeechRecognitionResult.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebSurroundingText.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebUserMediaRequest.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/WorkerContentSettingsClient.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/tests/PrerenderingTest.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/tests/WebDocumentTest.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/tests/sim/SimCompositor.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp
[modify] https://crrev.com/151deeb377f9456660e9ab835d1c7fa46edc7499/third_party/WebKit/Source/web/tests/sim/SimRequest.cpp
Project Member

Comment 26 by bugdroid1@chromium.org, Apr 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7

commit 6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7
Author: toyoshim <toyoshim@chromium.org>
Date: Mon Apr 04 12:25:50 2016

Revert of Replace all occurrences of RELEASE_ASSERT in wtf with CHECK. (patchset #4 id:60001 of https://codereview.chromium.org/1840163002/ )

Reason for revert:
Caused performance regression.

Original issue's description:
> Replace all occurrences of RELEASE_ASSERT in wtf with CHECK.
>
> BUG=596760
>
> Committed: https://crrev.com/d181f524c11e0d456bc48261334beda61e6f852c
> Cr-Commit-Position: refs/heads/master@{#384213}

TBR=haraken@chromium.org,yutak@chromium.org,kotenkov@yandex-team.ru
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=596760, 599867

Review URL: https://codereview.chromium.org/1859513002

Cr-Commit-Position: refs/heads/master@{#384889}

[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/ArrayBuffer.h
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/Deque.h
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/Functional.h
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/HashTable.h
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/Optional.h
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/PageAllocator.cpp
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/PartitionAlloc.cpp
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/PartitionAlloc.h
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/PartitionAllocator.h
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/Partitions.cpp
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/TerminatedArrayBuilder.h
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/TypedArrayBase.h
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/Vector.h
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/WTF.cpp
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/dtoa/utils.h
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/text/AtomicString.cpp
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/text/CString.cpp
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/text/StringConcatenate.cpp
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/text/StringConcatenate.h
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/text/StringImpl.cpp
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/text/StringImpl.h
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/text/TextCodecUTF16.cpp
[modify] https://crrev.com/6f9ac9d3e4eaaf5185d6c9067277119bfedc72d7/third_party/WebKit/Source/wtf/text/WTFString.cpp

Comment 27 by toyoshim@chromium.org, Apr 5 2016

Cc: toyoshim@chromium.org
I reverted a change that replaced RELEASE_ASSERT with CHECK as a perf regression sheriff.
This is because the change caused triggered many performance regression alerts.
I closed the bug 599867 for tracking the regression because the revert just fixed it, but probably this migration effort will need some investigation before going ahead.
Our infra just caught a regression for the last change, but others also could have caused similar issues bit by bit, but just our infra missed to catch.

If RELEASE_ASSERT realized better performance, could we improve base/logging performance before adopting these migrations?
Project Member

Comment 28 by bugdroid1@chromium.org, Apr 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/579ac73af399f0f16cfde8d0cda23ff1ec30750a

commit 579ac73af399f0f16cfde8d0cda23ff1ec30750a
Author: mcasas <mcasas@chromium.org>
Date: Wed Apr 06 18:56:12 2016

MediaRecorder: ASSERT-->DCHECK and a tiny cleanup in CanvasCapture

Blink now supports DCHECK()s and NOTREACHED(), this CL
uses them instead of ASSERT() and ASSERT_NOT_REACHED(),
respectively.

I was going to do the same HTMLCanvasElementCapture, but
removed the DCHECK instead bc of Chrome StyleGuide [1]:
> you should not handle DCHECK() failures, even if failure would
> result in a crash. Attempting to handle a DCHECK() failure is a
> statement that the DCHECK() can fail, which contradicts the point
> of writing the DCHECK(). In particular, do not write code like
> the following:
>
>  DCHECK(foo);
>  if (!foo) ...  // Can't succeed!

BUG=596760

[1] https://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED-

Review URL: https://codereview.chromium.org/1861963004

Cr-Commit-Position: refs/heads/master@{#385515}

[modify] https://crrev.com/579ac73af399f0f16cfde8d0cda23ff1ec30750a/third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp
[modify] https://crrev.com/579ac73af399f0f16cfde8d0cda23ff1ec30750a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp

Comment 29 by koten...@yandex-team.ru, Apr 7 2016 

I've investigated the performance degradation of the RELEASE_ASSERT -> CHECK conversion on android here: https://bugs.chromium.org/p/chromium/issues/detail?id=599867

The problem is that android uses a slow version of CHECK since https://codereview.chromium.org/336413005 .

We can utilize BLINK_IMPLEMENTATION define in logging.h to always use fast checks on blink. Or we can use fast checks everywhere if the problem with minidumps from the aforementioned cl is gone (I doubt it).

Comment 30 by toyoshim@chromium.org, Apr 7 2016 

Re #29
IIUC, we are collecting minidump even for Android Chrome now. So using fast checks everywhere sounds fine.

Comment 31 by koten...@yandex-team.ru, Apr 7 2016 

Re #30
I guess the minidumps were working on android even before the CL that changed the CHECK behavior. Were the issues mentioned in the CL fixed? Issues like
> A user may not be on WiFi for days, I don't know how to fix it.
Project Member

Comment 32 by bugdroid1@chromium.org, Apr 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f

commit 629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f
Author: mcasas <mcasas@chromium.org>
Date: Thu Apr 07 23:46:59 2016

WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED etc

Blink now supports DCHECK()s and relatives,
this CL replaces:

ASSERT --> DCHECK
ASSERT_NOT_REACHED --> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION --> SECURITY_DCHECK

This change
RELEASE_ASSERT --> CHECK
is not exercised due to http://crbug.com/599867
but a TODO is left for that.

See bug for + context.

BUG=596760
TBR=peter@chromium.org

Review URL: https://codereview.chromium.org/1862163002

Cr-Commit-Position: refs/heads/master@{#385926}

[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/MediaDeviceInfo.cpp
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.cpp
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/MediaErrorState.cpp
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/MediaStream.cpp
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/MediaStreamRegistry.cpp
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/MediaStreamTrackSourcesRequestImpl.cpp
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/NavigatorMediaStream.cpp
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/NavigatorUserMediaError.h
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/RTCDTMFToneChangeEvent.cpp
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestPromiseImpl.cpp
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.cpp
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/RTCStatsResponse.cpp
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.cpp
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/RTCVoidRequestPromiseImpl.cpp
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/SourceInfo.cpp
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/URLMediaStream.cpp
[modify] https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp
Project Member

Comment 33 by bugdroid1@chromium.org, Apr 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f18776c132b68a9be0541c730b72cb3806171bd

commit 4f18776c132b68a9be0541c730b72cb3806171bd
Author: dtapuska <dtapuska@chromium.org>
Date: Fri Apr 08 02:56:11 2016

Remove WTF_LOG(FileAPI,...)

Replace logging with DVLOG(1). I chose DVLOG since
it seems a little odd that arbirtary data would be logged
to the system log and we can save binary size with DVLOG.

BUG=596760

Review URL: https://codereview.chromium.org/1861603003

Cr-Commit-Position: refs/heads/master@{#385950}

[modify] https://crrev.com/4f18776c132b68a9be0541c730b72cb3806171bd/third_party/WebKit/Source/core/fileapi/FileReader.cpp
[modify] https://crrev.com/4f18776c132b68a9be0541c730b72cb3806171bd/third_party/WebKit/Source/platform/Logging.cpp
[modify] https://crrev.com/4f18776c132b68a9be0541c730b72cb3806171bd/third_party/WebKit/Source/platform/Logging.h
Project Member

Comment 34 by bugdroid1@chromium.org, Apr 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63915eb8cbda0af155de9e774283fa0828e9f446

commit 63915eb8cbda0af155de9e774283fa0828e9f446
Author: hayato <hayato@chromium.org>
Date: Fri Apr 08 03:14:10 2016

ASSERT -> {DCHECK|DCHECK_XX}, ENABLE(ASSERT) -> DCHECK_IS_ON() in dom

There are several places where DCHECK_{EQ/NE} can not be used because
"operator<<(ostream&, T&)" is not defined for T.

To isolate issues, other macros, such as RELEASE_ASSERT, will be replaced in another CL.

BUG=596760,601669

Review URL: https://codereview.chromium.org/1854423002

Cr-Commit-Position: refs/heads/master@{#385971}

[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/AXObjectCache.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ActiveDOMObject.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ActiveDOMObject.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/Attr.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/CharacterData.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/CharacterData.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ChildFrameDisconnector.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ChildListMutationScope.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ChildNodeList.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/CompositorProxiedPropertySet.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/CompositorProxy.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ContainerNode.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ContainerNode.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ContextFeatures.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DOMArrayBuffer.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DOMArrayBufferBase.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DOMArrayBufferView.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DOMDataView.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DOMException.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DOMImplementation.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DOMSharedArrayBuffer.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DOMSharedArrayBuffer.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DOMTypedArray.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DOMURL.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DocumentInit.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DocumentLifecycle.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DocumentOrderedMap.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DocumentOrderedMap.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DocumentParser.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DocumentParser.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DocumentParserTiming.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DocumentType.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/DocumentVisibilityObserver.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ElementData.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ElementDataCache.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ElementRareData.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ElementTest.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/FirstLetterPseudoElement.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/FlexibleArrayBufferView.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/Fullscreen.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/IconURL.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/IdTargetObserverRegistry.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/IdTargetObserverRegistry.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/LiveNodeListBase.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/MainThreadTaskRunner.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/MessageChannel.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/MessagePort.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/MutationObserver.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/MutationObserverInterestGroup.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/MutationObserverRegistration.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/NamedNodeMap.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/NamedNodeMap.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/NodeComputedStyle.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/NodeIntersectionObserverData.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/NodeIterator.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/NodeListsNodeData.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/NodeRareData.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/NodeTraversal.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/NodeWithIndex.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/NthIndexCache.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/NthIndexCache.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/PendingScript.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/PresentationAttributeStyle.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/PseudoElement.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/QualifiedName.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/QualifiedName.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/Range.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/Range.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/RemoteSecurityContext.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ScriptRunner.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ScriptedAnimationController.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/SecurityContext.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/SelectorQuery.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/SpaceSplitString.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/StyleChangeReason.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/StyleElement.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/StyleEngine.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/StyleSheetCollection.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/TagCollection.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/TagCollection.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/Text.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/TreeScope.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/TreeScopeAdopter.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/TreeScopeAdopter.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/TreeShared.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/TreeWalker.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/TypedFlexibleArrayBufferView.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/URLSearchParams.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/UserActionElementSet.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/VisitedLinkState.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/WeakIdentifierMap.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/custom/CustomElement.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/custom/CustomElementCallbackInvocation.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/custom/CustomElementCallbackQueue.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/custom/CustomElementCallbackQueue.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskDispatcher.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskImportStep.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/custom/CustomElementProcessingStack.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/custom/CustomElementProcessingStack.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/custom/CustomElementRegistrationContext.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/custom/CustomElementScheduler.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/shadow/DistributedNodes.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/shadow/ElementShadow.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversalTest.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/shadow/InsertionPoint.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/shadow/ShadowRootRareData.h
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp
[modify] https://crrev.com/63915eb8cbda0af155de9e774283fa0828e9f446/third_party/WebKit/Source/core/dom/shadow/SlotScopedTraversal.cpp

Comment 35 by toyoshim@chromium.org, Apr 8 2016 

kotenkov: Could you ask feng@ or other Android Chrome specialists?
Project Member

Comment 36 by bugdroid1@chromium.org, Apr 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff

commit 7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff
Author: kotenkov <kotenkov@yandex-team.ru>
Date: Fri Apr 08 06:52:09 2016

Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros.

BUG=596760

Review URL: https://codereview.chromium.org/1851293002

Cr-Commit-Position: refs/heads/master@{#386010}

[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/content/test/mock_webblob_registry_impl.cc
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/content/test/mock_webblob_registry_impl.h
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/Source/modules/encryptedmedia/MediaKeyStatusMap.cpp
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/Source/platform/blink_platform.gyp
[delete] https://crrev.com/a34111d476c333a6e7b182f0d703e67d8172d2d3/third_party/WebKit/Source/platform/exported/WebCommon.cpp
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/Source/web/WebSpeechGrammar.cpp
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/Source/web/tests/FrameLoaderClientImplTest.cpp
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/Source/web/tests/LayoutGeometryMapTest.cpp
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/public/platform/DEPS
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/public/platform/WebBlobRegistry.h
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/public/platform/WebCommon.h
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/public/platform/WebCryptoAlgorithmParams.h
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/public/platform/WebFileSystem.h
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/public/platform/WebMemoryAllocatorDump.h
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/public/platform/WebPrivateOwnPtr.h
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/public/platform/WebPrivatePtr.h
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/public/platform/WebProcessMemoryDump.h
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/public/platform/WebRTCKeyParams.h
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/public/platform/WebVector.h
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/public/platform/modules/indexeddb/WebIDBCursor.h
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabaseCallbacks.h
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/public/platform/modules/indexeddb/WebIDBFactory.h
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorker.h
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/public/web/WebFrameClient.h
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/public/web/WebSpeechRecognizer.h
[modify] https://crrev.com/7104e93bb1a32ba3cd9e1d798d02a1f54cf0c0ff/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
Project Member

Comment 37 by bugdroid1@chromium.org, Apr 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/964a5538825981c66dd7a09f7c52741b3be36b0f

commit 964a5538825981c66dd7a09f7c52741b3be36b0f
Author: kotenkov <kotenkov@yandex-team.ru>
Date: Mon Apr 11 00:36:51 2016

ASSERT_NOT_REACHED() -> NOTREACHED() in web.

BUG=596760

Review URL: https://codereview.chromium.org/1878493002

Cr-Commit-Position: refs/heads/master@{#386321}

[modify] https://crrev.com/964a5538825981c66dd7a09f7c52741b3be36b0f/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/964a5538825981c66dd7a09f7c52741b3be36b0f/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp
[modify] https://crrev.com/964a5538825981c66dd7a09f7c52741b3be36b0f/third_party/WebKit/Source/web/LocalFileSystemClient.cpp
[modify] https://crrev.com/964a5538825981c66dd7a09f7c52741b3be36b0f/third_party/WebKit/Source/web/PageWidgetDelegate.cpp
[modify] https://crrev.com/964a5538825981c66dd7a09f7c52741b3be36b0f/third_party/WebKit/Source/web/PopupMenuImpl.cpp
[modify] https://crrev.com/964a5538825981c66dd7a09f7c52741b3be36b0f/third_party/WebKit/Source/web/WebDOMFileSystem.cpp
[modify] https://crrev.com/964a5538825981c66dd7a09f7c52741b3be36b0f/third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp
[modify] https://crrev.com/964a5538825981c66dd7a09f7c52741b3be36b0f/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/964a5538825981c66dd7a09f7c52741b3be36b0f/third_party/WebKit/Source/web/WebIDBKey.cpp
[modify] https://crrev.com/964a5538825981c66dd7a09f7c52741b3be36b0f/third_party/WebKit/Source/web/WebInputEventConversion.cpp
[modify] https://crrev.com/964a5538825981c66dd7a09f7c52741b3be36b0f/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/964a5538825981c66dd7a09f7c52741b3be36b0f/third_party/WebKit/Source/web/WebPerformance.cpp
[modify] https://crrev.com/964a5538825981c66dd7a09f7c52741b3be36b0f/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
[modify] https://crrev.com/964a5538825981c66dd7a09f7c52741b3be36b0f/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/964a5538825981c66dd7a09f7c52741b3be36b0f/third_party/WebKit/Source/web/WorkerGlobalScopeProxyProviderImpl.cpp

Comment 38 by dtapu...@chromium.org, Apr 14 2016

Components: -Blink Blink>Architecture
Project Member

Comment 39 by bugdroid1@chromium.org, Apr 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4021ae18b9410d496adc92077e00672253f3876d

commit 4021ae18b9410d496adc92077e00672253f3876d
Author: kotenkov <kotenkov@yandex-team.ru>
Date: Tue Apr 19 07:09:39 2016

ASSERT -> DCHECK in core/editing.

BUG=596760

Review URL: https://codereview.chromium.org/1878473002

Cr-Commit-Position: refs/heads/master@{#388153}

[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/CaretBase.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/DOMSelection.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/EditingStrategy.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/EditingStyle.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/Editor.h
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/EphemeralRange.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/EphemeralRange.h
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/InputMethodController.h
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/PendingSelection.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/PlainTextRange.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/PlainTextRange.h
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/Position.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/Position.h
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/PositionIterator.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/RenderedPosition.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/SelectionEditor.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/SurroundingText.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/AppendNodeCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/EditingState.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/InsertNodeBeforeCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/MergeIdenticalElementsCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/RemoveCSSPropertyCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/RemoveNodeCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/RemoveNodePreservingChildrenCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/SetNodeAttributeCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/SimplifyMarkupCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/SmartReplaceICU.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/SplitTextNodeCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/SplitTextNodeContainingElementCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/UndoStack.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/commands/WrapContentsInDummySpanCommand.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/iterators/BackwardsCharacterIterator.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/iterators/BackwardsTextBuffer.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/iterators/ForwardsTextBuffer.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/iterators/FullyClippedStateStack.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/iterators/TextBufferBase.h
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/iterators/WordAwareIterator.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
[modify] https://crrev.com/4021ae18b9410d496adc92077e00672253f3876d/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp
Project Member

Comment 40 by bugdroid1@chromium.org, Apr 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/faf5a858a3d7d507ad4732abc25f8210ad0f79ce

commit faf5a858a3d7d507ad4732abc25f8210ad0f79ce
Author: nhiroki <nhiroki@chromium.org>
Date: Thu Apr 21 06:39:22 2016

Worker: Replace ASSERT macros with DCHECK macros

  * ASSERT -> DCHECK
  * ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK
  * ASSERT_NOT_REACHED -> NOTREACHED
  * ENABLE(ASSERT) -> DCHECK_IS_ON()

NOTE: RELEASE_ASSERT is not replaced with CHECK in this CL because CHECK has a
performance problem. See the following link for details.

The background of this change:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TL0NkNXIT1w

BUG=596760

Review URL: https://codereview.chromium.org/1902683005

Cr-Commit-Position: refs/heads/master@{#388705}

[modify] https://crrev.com/faf5a858a3d7d507ad4732abc25f8210ad0f79ce/third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp
[modify] https://crrev.com/faf5a858a3d7d507ad4732abc25f8210ad0f79ce/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp
[modify] https://crrev.com/faf5a858a3d7d507ad4732abc25f8210ad0f79ce/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
[modify] https://crrev.com/faf5a858a3d7d507ad4732abc25f8210ad0f79ce/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp
[modify] https://crrev.com/faf5a858a3d7d507ad4732abc25f8210ad0f79ce/third_party/WebKit/Source/core/workers/SharedWorker.cpp
[modify] https://crrev.com/faf5a858a3d7d507ad4732abc25f8210ad0f79ce/third_party/WebKit/Source/core/workers/Worker.cpp
[modify] https://crrev.com/faf5a858a3d7d507ad4732abc25f8210ad0f79ce/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp
[modify] https://crrev.com/faf5a858a3d7d507ad4732abc25f8210ad0f79ce/third_party/WebKit/Source/core/workers/WorkerBackingThread.h
[modify] https://crrev.com/faf5a858a3d7d507ad4732abc25f8210ad0f79ce/third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp
[modify] https://crrev.com/faf5a858a3d7d507ad4732abc25f8210ad0f79ce/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/faf5a858a3d7d507ad4732abc25f8210ad0f79ce/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp
[modify] https://crrev.com/faf5a858a3d7d507ad4732abc25f8210ad0f79ce/third_party/WebKit/Source/core/workers/WorkerLoaderProxy.cpp
[modify] https://crrev.com/faf5a858a3d7d507ad4732abc25f8210ad0f79ce/third_party/WebKit/Source/core/workers/WorkerLocation.h
[modify] https://crrev.com/faf5a858a3d7d507ad4732abc25f8210ad0f79ce/third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp
[modify] https://crrev.com/faf5a858a3d7d507ad4732abc25f8210ad0f79ce/third_party/WebKit/Source/core/workers/WorkerThread.cpp
Project Member

Comment 41 by bugdroid1@chromium.org, Apr 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/347e843fe7af26e06d8598b47e579105d60a9c47

commit 347e843fe7af26e06d8598b47e579105d60a9c47
Author: toyoshim <toyoshim@chromium.org>
Date: Thu Apr 21 06:48:58 2016

Web MIDI: Replace ASSERT macros with DCHECK macros

Replace ASSERT like macros in modules/webmidi.

- ASSERT -> DCHECK
- ASSERT_NOT_REACHED -> NOTREACHED

BUG=596760

Review URL: https://codereview.chromium.org/1901103006

Cr-Commit-Position: refs/heads/master@{#388706}

[modify] https://crrev.com/347e843fe7af26e06d8598b47e579105d60a9c47/third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp
[modify] https://crrev.com/347e843fe7af26e06d8598b47e579105d60a9c47/third_party/WebKit/Source/modules/webmidi/MIDIAccess.h
[modify] https://crrev.com/347e843fe7af26e06d8598b47e579105d60a9c47/third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp
[modify] https://crrev.com/347e843fe7af26e06d8598b47e579105d60a9c47/third_party/WebKit/Source/modules/webmidi/MIDIAccessor.cpp
[modify] https://crrev.com/347e843fe7af26e06d8598b47e579105d60a9c47/third_party/WebKit/Source/modules/webmidi/MIDIController.cpp
[modify] https://crrev.com/347e843fe7af26e06d8598b47e579105d60a9c47/third_party/WebKit/Source/modules/webmidi/MIDIInput.cpp
[modify] https://crrev.com/347e843fe7af26e06d8598b47e579105d60a9c47/third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp
[modify] https://crrev.com/347e843fe7af26e06d8598b47e579105d60a9c47/third_party/WebKit/Source/modules/webmidi/MIDIPort.cpp
Project Member

Comment 42 by bugdroid1@chromium.org, Apr 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66fd92ea8b1f316c6af4807f50ca91aca2ba0fbe

commit 66fd92ea8b1f316c6af4807f50ca91aca2ba0fbe
Author: kotenkov <kotenkov@yandex-team.ru>
Date: Tue Apr 26 03:15:01 2016

Add outputs for DCHECKs in InsertParagraphSeparatorCommand.cpp.

This is a followup for https://codereview.chromium.org/1878473002.

BUG=596760
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1914983003

Cr-Commit-Position: refs/heads/master@{#389678}

[modify] https://crrev.com/66fd92ea8b1f316c6af4807f50ca91aca2ba0fbe/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
Project Member

Comment 43 by bugdroid1@chromium.org, May 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9d5931295b7eab7bd2f029b8d896082b911d776

commit b9d5931295b7eab7bd2f029b8d896082b911d776
Author: danakj <danakj@chromium.org>
Date: Wed May 04 20:06:31 2016

Stop compiling and printing logging strings for CHECK() on Android.

This is a performance regression in general, and causes visible
regression when Blink used CHECK instead of their own RELEASE_ASSERT.

This behaviour was introduced in https://codereview.chromium.org/336413005

If Android continues to need something special here (radio silence
from previously-interested parties for the last few weeks), we should
print __FILE__ and __LINE__ or something, and not support the full
string logging that this patch reverts.

R=haraken, thakis@chromium.org
BUG=599867,596760, 378974

Review-Url: https://codereview.chromium.org/1937613002
Cr-Commit-Position: refs/heads/master@{#391613}

[modify] https://crrev.com/b9d5931295b7eab7bd2f029b8d896082b911d776/base/logging.h
Project Member

Comment 44 by bugdroid1@chromium.org, May 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fa0092a4064ea88eab950dc8e1c7a7fa587b639

commit 7fa0092a4064ea88eab950dc8e1c7a7fa587b639
Author: tkent <tkent@chromium.org>
Date: Mon May 16 04:54:53 2016

check-webkit-style: Add checks for deprecated wtf/Assertions.h macros.

It warns about:
 - ASSERT
 - ASSERT_UNUSED
 - ASSERT_NOT_REACHED
 - ASSERT_WITH_SECURITY_IMPLICATION
 - WTF_LOG

It doesn't warn about RELEASE_ASSERT yet.

BUG=596760

Review-Url: https://codereview.chromium.org/1981763002
Cr-Commit-Position: refs/heads/master@{#393789}

[modify] https://crrev.com/7fa0092a4064ea88eab950dc8e1c7a7fa587b639/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
[modify] https://crrev.com/7fa0092a4064ea88eab950dc8e1c7a7fa587b639/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
Project Member

Comment 45 by bugdroid1@chromium.org, May 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d0d91ff393599cb9e605b10b09eb59983145cd4

commit 4d0d91ff393599cb9e605b10b09eb59983145cd4
Author: kotenkov <kotenkov@yandex-team.ru>
Date: Tue May 24 17:24:49 2016

Replace all occurrences of RELEASE_ASSERT in wtf with CHECK.

This is a reland of https://codereview.chromium.org/1840163002.

Performance regressions were addressed in
https://codereview.chromium.org/1937613002
and https://codereview.chromium.org/1840163002.

BUG=596760,599867

Review-Url: https://codereview.chromium.org/1992873004
Cr-Commit-Position: refs/heads/master@{#395624}

[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/Deque.h
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/Functional.h
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/HashTable.h
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/TerminatedArrayBuilder.h
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/Vector.h
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/WTF.cpp
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/allocator/PartitionAlloc.cpp
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/allocator/PartitionAllocator.h
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/allocator/Partitions.cpp
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/dtoa/utils.h
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/text/AtomicString.cpp
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/text/CString.cpp
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/text/StringConcatenate.cpp
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/text/StringConcatenate.h
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/text/StringImpl.cpp
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/text/StringImpl.h
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/text/TextCodecUTF16.cpp
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/text/WTFString.cpp
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h
[modify] https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4/third_party/WebKit/Source/wtf/typed_arrays/TypedArrayBase.h
Project Member

Comment 46 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/060d0889ac68f2bd629ab3b684723dd32fce7a88

commit 060d0889ac68f2bd629ab3b684723dd32fce7a88
Author: srirama.m <srirama.m@samsung.com>
Date: Wed May 25 03:25:26 2016

encryptedmedia: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Replaced wtf/Assertions.h macros in favor of base/logging.h
macros in encryptedmedia module.

WTF_LOG -> DVLOG
ASSERT -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED

BUG=596522, 596760

Review-Url: https://codereview.chromium.org/2001173002
Cr-Commit-Position: refs/heads/master@{#395791}

[modify] https://crrev.com/060d0889ac68f2bd629ab3b684723dd32fce7a88/third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.cpp
[modify] https://crrev.com/060d0889ac68f2bd629ab3b684723dd32fce7a88/third_party/WebKit/Source/modules/encryptedmedia/EncryptedMediaUtils.cpp
[modify] https://crrev.com/060d0889ac68f2bd629ab3b684723dd32fce7a88/third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp
[modify] https://crrev.com/060d0889ac68f2bd629ab3b684723dd32fce7a88/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp
[modify] https://crrev.com/060d0889ac68f2bd629ab3b684723dd32fce7a88/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySystemAccess.cpp
[modify] https://crrev.com/060d0889ac68f2bd629ab3b684723dd32fce7a88/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp
[modify] https://crrev.com/060d0889ac68f2bd629ab3b684723dd32fce7a88/third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp
Project Member

Comment 47 by bugdroid1@chromium.org, May 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90ab609c3dcf497cb08af396f552ca1c8c56e10a

commit 90ab609c3dcf497cb08af396f552ca1c8c56e10a
Author: kotenkov <kotenkov@yandex-team.ru>
Date: Fri May 27 11:46:46 2016

Revert of Replace all occurrences of RELEASE_ASSERT in wtf with CHECK. (patchset #3 id:40001 of https://codereview.chromium.org/1992873004/ )

Reason for revert:
12.5%-56.9% regression in blink_perf.layout at 395611:395672

Original issue's description:
> Replace all occurrences of RELEASE_ASSERT in wtf with CHECK.
>
> This is a reland of https://codereview.chromium.org/1840163002.
>
> Performance regressions were addressed in
> https://codereview.chromium.org/1937613002
> and https://codereview.chromium.org/1840163002.
>
> BUG=596760,599867
>
> Committed: https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4
> Cr-Commit-Position: refs/heads/master@{#395624}

TBR=haraken@chromium.org,yutak@chromium.org,tkent@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=596760,599867,614852

Review-Url: https://codereview.chromium.org/2016223002
Cr-Commit-Position: refs/heads/master@{#396441}

[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/Deque.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/Functional.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/HashTable.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/TerminatedArrayBuilder.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/Vector.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/WTF.cpp
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/allocator/PartitionAlloc.cpp
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/allocator/PartitionAllocator.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/allocator/Partitions.cpp
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/dtoa/utils.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/text/AtomicString.cpp
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/text/CString.cpp
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/text/StringConcatenate.cpp
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/text/StringConcatenate.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/text/StringImpl.cpp
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/text/StringImpl.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/text/TextCodecUTF16.cpp
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/text/WTFString.cpp
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h
[modify] https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a/third_party/WebKit/Source/wtf/typed_arrays/TypedArrayBase.h
Project Member

Comment 48 by bugdroid1@chromium.org, Jun 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/673555a5d9c7a1bc26dc67813e1110cdc2e07268

commit 673555a5d9c7a1bc26dc67813e1110cdc2e07268
Author: kotenkov <kotenkov@yandex-team.ru>
Date: Tue Jun 21 08:47:50 2016

ASSERT -> DCHECK conversions in core/editing.

ENABLE(ASSERT) -> DCHECK_IS_ON() in core/editing.
ASSERT_NOT_REACHED() -> NOTREACHED() in core/editing.

BUG=596760

Review-Url: https://codereview.chromium.org/2082503003
Cr-Commit-Position: refs/heads/master@{#400923}

[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/EditingStyle.cpp
[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/EphemeralRange.cpp
[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/EphemeralRange.h
[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/Position.cpp
[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/RenderedPosition.cpp
[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/commands/EditingState.cpp
[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/commands/EditingState.h
[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp
[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp
[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp
[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.cpp
[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
[modify] https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268/third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp

Comment 49 by tkent@chromium.org, Jun 23 2016

Components: -Blink>Architecture Blink>Internals
Renaming Blink>Architecture to Blink>Internals
Project Member

Comment 50 by bugdroid1@chromium.org, Jun 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d757af7db879cc7c00c888deecf07d6469986209

commit d757af7db879cc7c00c888deecf07d6469986209
Author: tkent <tkent@chromium.org>
Date: Mon Jun 27 07:49:45 2016

Replase ASSERT macros with DCHECK, etc. in core/html/forms/.

Replace deprecated ASSERT-family macros.

- ASSERT* -> DCHECK*
- ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK
- ASSERT_NOT_REACHED -> NOTREACHED

This CL has no behavior changes.

BUG=596760

Review-Url: https://codereview.chromium.org/2097313002
Cr-Commit-Position: refs/heads/master@{#402132}

[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/BaseTemporalInputType.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/ChooserOnlyTemporalInputTypeView.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/DateInputType.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/DateTimeLocalInputType.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/EmailInputType.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/FileInputType.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/FormController.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/HiddenInputType.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/InputType.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/InputTypeView.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/MonthInputType.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/NumberInputType.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/PasswordInputType.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/SearchInputType.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/StepRange.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/TimeInputType.cpp
[modify] https://crrev.com/d757af7db879cc7c00c888deecf07d6469986209/third_party/WebKit/Source/core/html/forms/WeekInputType.cpp
Project Member

Comment 51 by bugdroid1@chromium.org, Jun 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f044c4cd141000df0c789d02a0bbee2643884562

commit f044c4cd141000df0c789d02a0bbee2643884562
Author: tkent <tkent@chromium.org>
Date: Tue Jun 28 12:41:46 2016

Remove LogTimers for WTF_LOG().

WTF_LOG(Timers) is used only in a single file. We may replace it with DVLOG().
This CL doesn't affect release/official build.

BUG=596760

Review-Url: https://codereview.chromium.org/2106663003
Cr-Commit-Position: refs/heads/master@{#402447}

[modify] https://crrev.com/f044c4cd141000df0c789d02a0bbee2643884562/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
[modify] https://crrev.com/f044c4cd141000df0c789d02a0bbee2643884562/third_party/WebKit/Source/platform/Logging.cpp
[modify] https://crrev.com/f044c4cd141000df0c789d02a0bbee2643884562/third_party/WebKit/Source/platform/Logging.h
Project Member

Comment 52 by bugdroid1@chromium.org, Aug 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83ced803a3b4c0d55efd2a07f17af7b5809d67b4

commit 83ced803a3b4c0d55efd2a07f17af7b5809d67b4
Author: tkent <tkent@chromium.org>
Date: Fri Aug 12 01:04:16 2016

Web SQL: Replace WTF_LOG() with STORAGE_DVLOG() or SQL_DVLOG().

WTF_LOG() is deprecated. This CL introduce STORAGE_DVLOG(level), which shows
logs with --vmodule=StorageLog=N, and SQL_DVLOG(level), which shows logs with
--vmodule=SQLLog=N, and replace WTF_LOG(StorageAPI, ...) and
WTF_LOG(SQLDatabase, ...).

This CL doesn't affect production.

BUG=596760

Review-Url: https://codereview.chromium.org/2229213002
Cr-Commit-Position: refs/heads/master@{#411499}

[modify] https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4/third_party/WebKit/Source/modules/modules.gypi
[modify] https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4/third_party/WebKit/Source/modules/webdatabase/Database.cpp
[modify] https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4/third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp
[modify] https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4/third_party/WebKit/Source/modules/webdatabase/DatabaseTask.cpp
[modify] https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4/third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h
[modify] https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp
[modify] https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4/third_party/WebKit/Source/modules/webdatabase/SQLStatement.cpp
[modify] https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4/third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp
[modify] https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4/third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp
[modify] https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4/third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.cpp
[modify] https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4/third_party/WebKit/Source/modules/webdatabase/SQLTransactionStateMachine.cpp
[modify] https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4/third_party/WebKit/Source/modules/webdatabase/SQLTransactionStateMachine.h
[add] https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4/third_party/WebKit/Source/modules/webdatabase/StorageLog.h
[add] https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLLog.h
[modify] https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp
[modify] https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp
[modify] https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4/third_party/WebKit/Source/platform/Logging.cpp
[modify] https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4/third_party/WebKit/Source/platform/Logging.h
Project Member

Comment 53 by bugdroid1@chromium.org, Aug 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b300917ad36438a8bcf700980f8991bf55cf2581

commit b300917ad36438a8bcf700980f8991bf55cf2581
Author: tkent <tkent@chromium.org>
Date: Fri Aug 12 10:05:08 2016

Replace WTF_LOG() with NETWORK_DVLOG() or RESOURCE_LOADING_DVLOG().

WTF_LOG() is deprecated. Like crrev.com/411499, this CL introduce
NETWORK_DVLOG(level), which shows logs with --vmodule=NetworkLog=N, and
RESOURCE_LOADING_DVLOG(level), which shows logs with --vmodule=ResourceLoadingLog=N,
and replace WTF_LOG(Network, ...) and WTF_LOG(ResourceLoading, ...).

This CL also adds a stream printer for WTF::CString.

This CL doesn't affect production.

BUG=596760

Review-Url: https://codereview.chromium.org/2240053002
Cr-Commit-Position: refs/heads/master@{#411588}

[modify] https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581/third_party/WebKit/Source/core/fetch/ImageResource.cpp
[modify] https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581/third_party/WebKit/Source/core/fetch/MemoryCache.cpp
[modify] https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
[add] https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581/third_party/WebKit/Source/core/fetch/ResourceLoadingLog.h
[modify] https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581/third_party/WebKit/Source/core/html/HTMLImageLoader.cpp
[modify] https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581/third_party/WebKit/Source/core/loader/ImageLoader.cpp
[modify] https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
[modify] https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h
[modify] https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
[modify] https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
[modify] https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h
[modify] https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581/third_party/WebKit/Source/platform/Logging.cpp
[modify] https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581/third_party/WebKit/Source/platform/Logging.h
[modify] https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581/third_party/WebKit/Source/platform/blink_platform.gypi
[add] https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581/third_party/WebKit/Source/platform/network/NetworkLog.h
[modify] https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581/third_party/WebKit/Source/wtf/text/CString.cpp
[modify] https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581/third_party/WebKit/Source/wtf/text/CString.h
[modify] https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581/third_party/WebKit/Source/wtf/text/CStringTest.cpp

Comment 54 by toyoshim@chromium.org, Aug 15 2016

Cc: -toyoshim@chromium.org
Project Member

Comment 55 by bugdroid1@chromium.org, Aug 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37b59c155f248d35040ceff1a3e8e893b5eb99c0

commit 37b59c155f248d35040ceff1a3e8e893b5eb99c0
Author: skobes <skobes@chromium.org>
Date: Tue Aug 16 20:28:12 2016

Use DCHECK_IS_ON consistently in DatabaseTask.

This fixes compile errors with blink_logging_always_on, introduced by
http://crrev.com/411499.

Also remove unused method hasSynchronizer().

BUG=596760

Review-Url: https://codereview.chromium.org/2245103004
Cr-Commit-Position: refs/heads/master@{#412328}

[modify] https://crrev.com/37b59c155f248d35040ceff1a3e8e893b5eb99c0/third_party/WebKit/Source/modules/webdatabase/DatabaseTask.cpp
[modify] https://crrev.com/37b59c155f248d35040ceff1a3e8e893b5eb99c0/third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h
Project Member

Comment 56 by bugdroid1@chromium.org, Aug 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0316d5ad84ef5409cabb2b477fc4c5864604f9e8

commit 0316d5ad84ef5409cabb2b477fc4c5864604f9e8
Author: tkent <tkent@chromium.org>
Date: Wed Aug 17 03:19:42 2016

Remove WTF_LOG().

No one uses it.
The command-line flag --blink-platform-log-channels is also removed. It
affects nothing.

BUG=596760

Review-Url: https://codereview.chromium.org/2240043002
Cr-Commit-Position: refs/heads/master@{#412440}

[modify] https://crrev.com/0316d5ad84ef5409cabb2b477fc4c5864604f9e8/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/0316d5ad84ef5409cabb2b477fc4c5864604f9e8/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/0316d5ad84ef5409cabb2b477fc4c5864604f9e8/content/public/common/content_switches.cc
[modify] https://crrev.com/0316d5ad84ef5409cabb2b477fc4c5864604f9e8/content/public/common/content_switches.h
[modify] https://crrev.com/0316d5ad84ef5409cabb2b477fc4c5864604f9e8/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/0316d5ad84ef5409cabb2b477fc4c5864604f9e8/content/test/blink_test_environment.cc
[modify] https://crrev.com/0316d5ad84ef5409cabb2b477fc4c5864604f9e8/third_party/WebKit/Source/config.gni
[delete] https://crrev.com/7efb3a116b75670b77d6141decc82b2f117877a6/third_party/WebKit/Source/platform/Logging.cpp
[delete] https://crrev.com/7efb3a116b75670b77d6141decc82b2f117877a6/third_party/WebKit/Source/platform/Logging.h
[modify] https://crrev.com/0316d5ad84ef5409cabb2b477fc4c5864604f9e8/third_party/WebKit/Source/platform/blink_platform.gypi
[modify] https://crrev.com/0316d5ad84ef5409cabb2b477fc4c5864604f9e8/third_party/WebKit/Source/platform/fonts/ScriptRunIteratorTest.cpp
[modify] https://crrev.com/0316d5ad84ef5409cabb2b477fc4c5864604f9e8/third_party/WebKit/Source/web/WebKit.cpp
[modify] https://crrev.com/0316d5ad84ef5409cabb2b477fc4c5864604f9e8/third_party/WebKit/Source/wtf/Assertions.cpp
[modify] https://crrev.com/0316d5ad84ef5409cabb2b477fc4c5864604f9e8/third_party/WebKit/Source/wtf/Assertions.h
[modify] https://crrev.com/0316d5ad84ef5409cabb2b477fc4c5864604f9e8/third_party/WebKit/Source/wtf/ScopedLogger.md
[modify] https://crrev.com/0316d5ad84ef5409cabb2b477fc4c5864604f9e8/third_party/WebKit/public/web/WebKit.h

Comment 57 by tkent@chromium.org, Aug 18 2016

Blockedon: 638849
Project Member

Comment 58 by bugdroid1@chromium.org, Aug 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d348310d0f641df4021694b95084707919ade5be

commit d348310d0f641df4021694b95084707919ade5be
Author: tkent <tkent@chromium.org>
Date: Fri Aug 19 08:06:01 2016

Fix style errors in core/html/shadow/.

Mainly ASSERT() -> DCHECK*().
This CL has no behavior changes.

BUG=596760

Review-Url: https://codereview.chromium.org/2259173002
Cr-Commit-Position: refs/heads/master@{#413083}

[modify] https://crrev.com/d348310d0f641df4021694b95084707919ade5be/third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp
[modify] https://crrev.com/d348310d0f641df4021694b95084707919ade5be/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp
[modify] https://crrev.com/d348310d0f641df4021694b95084707919ade5be/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElements.cpp
[modify] https://crrev.com/d348310d0f641df4021694b95084707919ade5be/third_party/WebKit/Source/core/html/shadow/DateTimeNumericFieldElement.cpp
[modify] https://crrev.com/d348310d0f641df4021694b95084707919ade5be/third_party/WebKit/Source/core/html/shadow/DateTimeSymbolicFieldElement.cpp
[modify] https://crrev.com/d348310d0f641df4021694b95084707919ade5be/third_party/WebKit/Source/core/html/shadow/PickerIndicatorElement.cpp
[modify] https://crrev.com/d348310d0f641df4021694b95084707919ade5be/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp
Project Member

Comment 59 by bugdroid1@chromium.org, Aug 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8dd9554617bcac53dea5173d382d7e66b96109f

commit c8dd9554617bcac53dea5173d382d7e66b96109f
Author: tkent <tkent@chromium.org>
Date: Fri Aug 19 09:57:08 2016

Replace ASSERT()s with DCHECK*() in core/html/imports/.

This CL has no behavior changes.

BUG=596760

Review-Url: https://codereview.chromium.org/2264483002
Cr-Commit-Position: refs/heads/master@{#413095}

[modify] https://crrev.com/c8dd9554617bcac53dea5173d382d7e66b96109f/third_party/WebKit/Source/core/html/imports/HTMLImport.cpp
[modify] https://crrev.com/c8dd9554617bcac53dea5173d382d7e66b96109f/third_party/WebKit/Source/core/html/imports/HTMLImportChild.cpp
[modify] https://crrev.com/c8dd9554617bcac53dea5173d382d7e66b96109f/third_party/WebKit/Source/core/html/imports/HTMLImportChild.h
[modify] https://crrev.com/c8dd9554617bcac53dea5173d382d7e66b96109f/third_party/WebKit/Source/core/html/imports/HTMLImportLoader.cpp
[modify] https://crrev.com/c8dd9554617bcac53dea5173d382d7e66b96109f/third_party/WebKit/Source/core/html/imports/HTMLImportState.h
[modify] https://crrev.com/c8dd9554617bcac53dea5173d382d7e66b96109f/third_party/WebKit/Source/core/html/imports/HTMLImportTreeRoot.cpp
[modify] https://crrev.com/c8dd9554617bcac53dea5173d382d7e66b96109f/third_party/WebKit/Source/core/html/imports/HTMLImportsController.cpp
[modify] https://crrev.com/c8dd9554617bcac53dea5173d382d7e66b96109f/third_party/WebKit/Source/core/html/imports/LinkImport.cpp
Project Member

Comment 60 by bugdroid1@chromium.org, Aug 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dca762e900f2da52b428327f9c80447667c76ac

commit 5dca762e900f2da52b428327f9c80447667c76ac
Author: tkent <tkent@chromium.org>
Date: Fri Aug 19 23:59:34 2016

Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}.

This CL has no behavior changes.

BUG=596760

Review-Url: https://codereview.chromium.org/2258033002
Cr-Commit-Position: refs/heads/master@{#413289}

[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/ClassList.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/CollectionIndexCache.h
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/CollectionItemsCache.h
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/DocumentNameCollection.h
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/FormAssociatedElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/FormData.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLAllCollection.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLAreaElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLCollection.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLCollection.h
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLContentElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLDataListOptionsCollection.h
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLDialogElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLDialogElement.h
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLDocument.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLElement.h
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLFontElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLFormControlsCollection.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLImageElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLLIElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLLinkElement.h
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLMapElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLMeterElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLNameCollection.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLObjectElement.h
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLProgressElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLQuoteElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLScriptElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLShadowElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLStyleElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLTableElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLTableRowsCollection.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLTagCollection.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLTagCollection.h
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/HTMLViewSourceDocument.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/ImageData.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/ImageDocument.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/LabelsNodeList.h
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/MediaDocument.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/PluginDocument.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/RadioNodeList.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/RadioNodeList.h
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/TimeRanges.cpp
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/URLRegistry.h
[modify] https://crrev.com/5dca762e900f2da52b428327f9c80447667c76ac/third_party/WebKit/Source/core/html/WindowNameCollection.h
Project Member

Comment 61 by bugdroid1@chromium.org, Aug 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23d946cd78876b44e611fbab188a66f80cfd9017

commit 23d946cd78876b44e611fbab188a66f80cfd9017
Author: tkent <tkent@chromium.org>
Date: Wed Aug 24 03:40:45 2016

Replace ASSERT*() with DCHECK*() in core/xml/.

This CL has no behavior changes.

BUG=596760

Review-Url: https://codereview.chromium.org/2274573004
Cr-Commit-Position: refs/heads/master@{#413971}

[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/DocumentXSLT.cpp
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/DocumentXSLT.h
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/XMLSerializer.cpp
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/XPathFunctions.cpp
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/XPathNodeSet.cpp
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/XPathParser.cpp
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/XPathPredicate.cpp
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/XPathResult.cpp
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/XPathStep.cpp
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/XPathStep.h
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/XPathUtil.cpp
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/XPathValue.cpp
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/XPathVariableReference.h
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/XSLImportRule.cpp
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/XSLImportRule.h
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/XSLStyleSheet.h
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/XSLStyleSheetLibxslt.cpp
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/XSLTExtensions.cpp
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/XSLTProcessor.h
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/parser/MarkupTokenizerInlines.h
[modify] https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
Project Member

Comment 62 by bugdroid1@chromium.org, Aug 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9838bdfb2709677aacdad97fdd2ede40b49420c

commit a9838bdfb2709677aacdad97fdd2ede40b49420c
Author: tkent <tkent@chromium.org>
Date: Wed Aug 24 08:08:04 2016

Replace ASSERT*() with DCHECK*() in core/events/.

This CL has no behavior changes.

BUG=596760

Review-Url: https://codereview.chromium.org/2270293002
Cr-Commit-Position: refs/heads/master@{#414015}

[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/ApplicationCacheErrorEvent.cpp
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/DOMWindowEventQueue.cpp
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/ErrorEvent.cpp
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/Event.cpp
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/Event.h
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/EventDispatchMediator.cpp
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/EventDispatchMediator.h
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/EventDispatcher.cpp
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/EventDispatcher.h
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/EventListenerMap.cpp
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/EventListenerMap.h
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/EventPath.cpp
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/EventPath.h
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/EventSender.h
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/EventTarget.h
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/GenericEventQueue.cpp
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/GestureEvent.cpp
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/KeyboardEvent.cpp
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/MessageEvent.cpp
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/MessageEvent.h
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/NodeEventContext.cpp
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/NodeEventContext.h
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/PointerEvent.cpp
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/PopStateEvent.h
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/RegisteredEventListener.h
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/ScopedEventQueue.cpp
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/TouchEventContext.cpp
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/TreeScopeEventContext.cpp
[modify] https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c/third_party/WebKit/Source/core/events/TreeScopeEventContext.h
Project Member

Comment 63 by bugdroid1@chromium.org, Aug 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fb35e4705573752a8c348a3879885e560b5f93c

commit 9fb35e4705573752a8c348a3879885e560b5f93c
Author: tkent <tkent@chromium.org>
Date: Thu Aug 25 10:42:29 2016

Replace two ASSERT()s for HashMap iterators with DCHECK_NE()s.

These ASSERT()s compare HashMap iterators, and DCHECK*() requires stream printers
for the iterators. This CL adds them.

BUG=596760

Review-Url: https://codereview.chromium.org/2274403002
Cr-Commit-Position: refs/heads/master@{#414383}

[modify] https://crrev.com/9fb35e4705573752a8c348a3879885e560b5f93c/third_party/WebKit/Source/core/events/EventPath.cpp
[modify] https://crrev.com/9fb35e4705573752a8c348a3879885e560b5f93c/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp
[modify] https://crrev.com/9fb35e4705573752a8c348a3879885e560b5f93c/third_party/WebKit/Source/wtf/HashTable.h
Project Member

Comment 65 by bugdroid1@chromium.org, Sep 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a115f803fe701b0039de012617c298f588839581

commit a115f803fe701b0039de012617c298f588839581
Author: hiroshige <hiroshige@chromium.org>
Date: Tue Sep 13 16:23:51 2016

Fix a comment: ALLOW_UNUSED_LOCAL() is not needed for replacing ASSERT_UNUSED()

From review comments:
https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Source/core/fetch/Resource.cpp#newcode754

BUG=596760

Review-Url: https://codereview.chromium.org/2337053002
Cr-Commit-Position: refs/heads/master@{#418268}

[modify] https://crrev.com/a115f803fe701b0039de012617c298f588839581/third_party/WebKit/Source/wtf/Assertions.h
Project Member

Comment 66 by bugdroid1@chromium.org, Sep 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4c242bce2dd77f07a5d2b051088688f1ebbab86

commit b4c242bce2dd77f07a5d2b051088688f1ebbab86
Author: hiroshige <hiroshige@chromium.org>
Date: Wed Sep 14 17:38:55 2016

Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

sed -i 's/ ASSERT(/ DCHECK(/g'
sed -i 's/ RELEASE_ASSERT(/ CHECK(/g'
sed -i 's/ ASSERT_NOT_REACHED(/ NOTREACHED(/g'
sed -i 's/ ASSERT_WITH_SECURITY_IMPLICATION(/ SECURITY_DCHECK(/g'
perl -npe '$_ =~ s/ASSERT_UNUSED\((.*?), (.*)\);$/DCHECK($2);/g'

for `find third_party/WebKit/Source/core/{fetch,loader}/ -name '*.*'`.

This CL replaces
- DCHECK(a == b) with DCHECK_EQ(a, b)
- DCHECK(a && b) with DCHECK(a) and DCHECK(b)
etc. manually.

BUG=645395, 596760

Review-Url: https://codereview.chromium.org/2327643003
Cr-Commit-Position: refs/heads/master@{#418606}

[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/DocumentResource.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/FetchRequest.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/FontResource.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/ImageResource.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/LinkFetchResource.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/MemoryCache.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/RawResource.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/RawResource.h
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/Resource.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/ScriptResource.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/DocumentLoadTiming.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/DocumentWriter.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/FormSubmission.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/FrameLoaderStateMachine.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/HistoryItem.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/HttpEquiv.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/ImageLoader.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/LinkLoader.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/MixedContentChecker.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/NavigationPolicy.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/NavigationScheduler.h
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/PingLoader.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/ProgressTracker.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/TextTrackLoader.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/ThreadableLoader.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp
[modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp
Project Member

Comment 68 by bugdroid1@chromium.org, Oct 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/808f09ae9b773d69c271aedd63157b2b020cd0a2

commit 808f09ae9b773d69c271aedd63157b2b020cd0a2
Author: tkent <tkent@chromium.org>
Date: Thu Oct 06 14:15:43 2016

Remove ASSERT_UNUSED

This CL has no behavior changes.

BUG=596760

Review-Url: https://codereview.chromium.org/2394683005
Cr-Commit-Position: refs/heads/master@{#423519}

[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/frame/PlatformEventController.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/html/parser/HTMLEntityParser.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/layout/FloatingObjects.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/layout/LayoutInline.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/layout/LayoutTableCell.h
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/layout/LayoutTableCol.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/page/EventSource.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/page/PagePopupController.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/svg/SVGElement.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/modules/filesystem/FileWriterSync.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/platform/DateComponents.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/platform/heap/ThreadState.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/platform/mediastream/MediaStreamCenter.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/platform/text/SegmentedString.h
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/web/AssociatedURLLoader.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/wtf/Assertions.h
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/wtf/ThreadRestrictionVerifier.h
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/wtf/ThreadingPthreads.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/wtf/ThreadingWin.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/wtf/text/WTFString.cpp
Project Member

Comment 69 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/241ea4031fccfda293385b4ce806f2596b3c4d97

commit 241ea4031fccfda293385b4ce806f2596b3c4d97
Author: tkent <tkent@chromium.org>
Date: Thu Oct 06 06:51:53 2016

Replace ASSERT family with DCHECK and so on in core/dom/.

- ASSERT_UNUSED -> DCHECK*
- ASSERT_NOT_REACHED -> NOTREACHED
- ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

* core/dom/SpaceSplitString.h
 Remove two ASSERT_WITH_SECURITY_IMPLICATIONs. Vector[] has a RELEASE_ASSERT for
 the same condition. These ASSERT_WITH_SECURITY_IMPLICATIONs were redundant.

BUG=596760

Review-Url: https://codereview.chromium.org/2401523002
Cr-Commit-Position: refs/heads/master@{#423455}

[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/ClassCollection.h
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/DOMArrayBufferBase.h
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/DOMArrayBufferView.h
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/DOMStringList.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/DOMURL.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/DOMURLUtils.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/DocumentParser.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/IconURL.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/NameNodeList.h
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/NodeListsNodeData.h
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/PresentationAttributeStyle.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/PseudoElement.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/PseudoElementData.h
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/Range.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/RawDataDocumentParser.h
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/SecurityContext.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/SpaceSplitString.h
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/TagCollection.h
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/TreeScopeAdopter.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/URLSearchParams.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/URLSearchParams.h
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/ViewportDescription.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/custom/V0CustomElement.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/custom/V0CustomElementCallbackInvocation.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/custom/V0CustomElementException.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskDispatcher.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/custom/V0CustomElementObserver.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/custom/V0CustomElementUpgradeCandidateMap.cpp
[modify] https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97/third_party/WebKit/Source/core/dom/shadow/ShadowRootRareDataV0.h
Project Member

Comment 70 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/808f09ae9b773d69c271aedd63157b2b020cd0a2

commit 808f09ae9b773d69c271aedd63157b2b020cd0a2
Author: tkent <tkent@chromium.org>
Date: Thu Oct 06 14:15:43 2016

Remove ASSERT_UNUSED

This CL has no behavior changes.

BUG=596760

Review-Url: https://codereview.chromium.org/2394683005
Cr-Commit-Position: refs/heads/master@{#423519}

[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/frame/PlatformEventController.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/html/parser/HTMLEntityParser.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/layout/FloatingObjects.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/layout/LayoutInline.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/layout/LayoutTableCell.h
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/layout/LayoutTableCol.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/page/EventSource.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/page/PagePopupController.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/core/svg/SVGElement.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/modules/filesystem/FileWriterSync.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/platform/DateComponents.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/platform/heap/ThreadState.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/platform/mediastream/MediaStreamCenter.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/platform/text/SegmentedString.h
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/web/AssociatedURLLoader.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/wtf/Assertions.h
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/wtf/ThreadRestrictionVerifier.h
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/wtf/ThreadingPthreads.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/wtf/ThreadingWin.cpp
[modify] https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2/third_party/WebKit/Source/wtf/text/WTFString.cpp
Project Member

Comment 71 by bugdroid1@chromium.org, Oct 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ed6ce9088448d73aa7466bfe706190b5c28b093

commit 0ed6ce9088448d73aa7466bfe706190b5c28b093
Author: mbarbella <mbarbella@chromium.org>
Date: Fri Oct 28 06:47:22 2016

Remove ASSERT_WITH_SECURITY_IMPLICATION.

Existing usage will be replaced with SECURITY_DCHECK.

This will allow ClusterFuzz to distinguish between security and
non-security ASSERTs/DCHECKs.

This CL is close to a functional no-op. If you're seeing this in
git blame, you will likely want to check an older revision to see
who actually introduced the assertion in question.

R=tkent@chromium.org
BUG=596760
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2458003002
Cr-Commit-Position: refs/heads/master@{#428300}

[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/css/CSSImageSetValue.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/css/FontStyleMatcher.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/css/StyleSheetContents.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/inspector/InspectorTaskRunner.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/LayoutGrid.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/LayoutText.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LayoutBlockItem.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LayoutBoxItem.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LayoutBoxModel.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LayoutEmbeddedItem.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LayoutImageItem.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LayoutLIItem.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LayoutMediaItem.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LayoutMenuListItem.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LayoutPartItem.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LayoutProgressItem.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LayoutSliderItem.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LayoutTextControlItem.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LayoutTextFragmentItem.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LayoutTextItem.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LayoutViewItem.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LineLayoutBR.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LineLayoutBlockFlow.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LineLayoutBox.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LineLayoutBoxModel.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LineLayoutInline.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LineLayoutListMarker.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LineLayoutRubyBase.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LineLayoutRubyRun.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LineLayoutRubyText.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LineLayoutSVGInline.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LineLayoutSVGInlineText.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LineLayoutSVGTextPath.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LineLayoutText.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/api/LineLayoutTextCombine.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/layout/svg/SVGResources.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/page/WindowFeatures.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/paint/SVGMaskPainter.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/svg/SVGElement.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/modules/indexeddb/IDBAny.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/platform/SharedBuffer.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/platform/SharedBufferChunkReader.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/platform/audio/AudioArray.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/platform/audio/AudioFIFO.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/platform/audio/HRTFDatabase.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/platform/fonts/GlyphBuffer.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/platform/fonts/GlyphMetricsMap.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/platform/geometry/Region.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/platform/graphics/filters/FEComponentTransfer.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/platform/text/QuotedPrintable.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/platform/text/SegmentedString.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/platform/text/TextRun.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/web/ContextFeaturesClientImpl.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/web/IndexedDBClientImpl.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/web/TextFinder.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/web/WebAXObject.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/wtf/Assertions.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/wtf/BitVector.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/wtf/HashTable.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/wtf/RefCounted.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/wtf/ThreadRestrictionVerifier.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/wtf/Vector.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/wtf/dtoa/utils.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/wtf/text/StringBuffer.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/wtf/text/StringBuilder.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/wtf/text/StringImpl.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/wtf/text/TextCodecUTF8.cpp
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Source/wtf/typed_arrays/TypedArrayBase.h
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
[modify] https://crrev.com/0ed6ce9088448d73aa7466bfe706190b5c28b093/third_party/WebKit/public/web/WebNode.h

Comment 72 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Project Member

Comment 73 by bugdroid1@chromium.org, Nov 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/618a03472d837aa934ab9c9a8f2b326f031d0e88

commit 618a03472d837aa934ab9c9a8f2b326f031d0e88
Author: tkent <tkent@chromium.org>
Date: Mon Nov 21 05:47:02 2016

Remove RELEASE_NOTREACHED().

It was introduced to replace RELEASE_ASSERT_NOT_REACHED() inherited from WebKit.
However, it's not so popular and using LOG(FATAL) directly is enough.

BUG=596760

Review-Url: https://codereview.chromium.org/2518933002
Cr-Commit-Position: refs/heads/master@{#433478}

[modify] https://crrev.com/618a03472d837aa934ab9c9a8f2b326f031d0e88/third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp
[modify] https://crrev.com/618a03472d837aa934ab9c9a8f2b326f031d0e88/third_party/WebKit/Source/core/frame/DOMWindow.cpp
[modify] https://crrev.com/618a03472d837aa934ab9c9a8f2b326f031d0e88/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/618a03472d837aa934ab9c9a8f2b326f031d0e88/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp
[modify] https://crrev.com/618a03472d837aa934ab9c9a8f2b326f031d0e88/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
[modify] https://crrev.com/618a03472d837aa934ab9c9a8f2b326f031d0e88/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp
[modify] https://crrev.com/618a03472d837aa934ab9c9a8f2b326f031d0e88/third_party/WebKit/Source/platform/heap/ThreadState.cpp
[modify] https://crrev.com/618a03472d837aa934ab9c9a8f2b326f031d0e88/third_party/WebKit/Source/wtf/Assertions.h
Project Member

Comment 74 by bugdroid1@chromium.org, Nov 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0d60458381abc2d150df4c505d4b857c6f83783

commit d0d60458381abc2d150df4c505d4b857c6f83783
Author: tkent <tkent@chromium.org>
Date: Mon Nov 21 14:20:59 2016

WTF: Remove NO_RETURN, NO_RETURN_DUE_TO_CRASH, and NO_RETURN_DUE_TO_ASSERT.

There are only two instances of NO_RETURN_DUE_TO_ASSERT in Mac-only code.
Remove them for simplicity.

BUG=596760

Review-Url: https://codereview.chromium.org/2515213002
Cr-Commit-Position: refs/heads/master@{#433534}

[modify] https://crrev.com/d0d60458381abc2d150df4c505d4b857c6f83783/third_party/WebKit/Source/platform/mac/BlockExceptions.h
[modify] https://crrev.com/d0d60458381abc2d150df4c505d4b857c6f83783/third_party/WebKit/Source/wtf/Assertions.h
[modify] https://crrev.com/d0d60458381abc2d150df4c505d4b857c6f83783/third_party/WebKit/Source/wtf/Compiler.h
[modify] https://crrev.com/d0d60458381abc2d150df4c505d4b857c6f83783/third_party/WebKit/Source/wtf/text/StringImplCF.cpp
Project Member

Comment 75 by bugdroid1@chromium.org, Nov 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab725021cade9b879960ee8e8e493e33b537cbfe

commit ab725021cade9b879960ee8e8e493e33b537cbfe
Author: tkent <tkent@chromium.org>
Date: Tue Nov 22 09:30:58 2016

Remove WTF_ATTRIBUTE_PRINTF.

Use PRINTF_FORMAT defined in base/compiler_specific.h instead.
Also, prepend PRINTF_FORMAT to functions.

https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions
> Attributes, and macros that expand to attributes, appear at the very beginning
> of the function declaration or definition, before the return type:

BUG=596760

Review-Url: https://codereview.chromium.org/2513363002
Cr-Commit-Position: refs/heads/master@{#433825}

[modify] https://crrev.com/ab725021cade9b879960ee8e8e493e33b537cbfe/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
[modify] https://crrev.com/ab725021cade9b879960ee8e8e493e33b537cbfe/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.h
[modify] https://crrev.com/ab725021cade9b879960ee8e8e493e33b537cbfe/third_party/WebKit/Source/wtf/Assertions.cpp
[modify] https://crrev.com/ab725021cade9b879960ee8e8e493e33b537cbfe/third_party/WebKit/Source/wtf/Assertions.h
[modify] https://crrev.com/ab725021cade9b879960ee8e8e493e33b537cbfe/third_party/WebKit/Source/wtf/DataLog.h
[modify] https://crrev.com/ab725021cade9b879960ee8e8e493e33b537cbfe/third_party/WebKit/Source/wtf/FilePrintStream.h
[modify] https://crrev.com/ab725021cade9b879960ee8e8e493e33b537cbfe/third_party/WebKit/Source/wtf/PrintStream.h
[modify] https://crrev.com/ab725021cade9b879960ee8e8e493e33b537cbfe/third_party/WebKit/Source/wtf/text/WTFString.h
Project Member

Comment 77 by bugdroid1@chromium.org, Nov 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b12c489b9a470b61f23de3aa27c627eb3a733b4f

commit b12c489b9a470b61f23de3aa27c627eb3a733b4f
Author: Yoonjae.Cho92 <Yoonjae.Cho92@gmail.com>
Date: Mon Nov 28 04:30:02 2016

Replace ASSERT_NOT_REACHED -> NOTREACHED

BUG=596760

Review-Url: https://codereview.chromium.org/2522043003
Cr-Commit-Position: refs/heads/master@{#434601}

[modify] https://crrev.com/b12c489b9a470b61f23de3aa27c627eb3a733b4f/third_party/WebKit/Source/core/css/CSSSelector.cpp
[modify] https://crrev.com/b12c489b9a470b61f23de3aa27c627eb3a733b4f/third_party/WebKit/Source/core/css/CSSValue.cpp
[modify] https://crrev.com/b12c489b9a470b61f23de3aa27c627eb3a733b4f/third_party/WebKit/Source/core/css/FontFace.cpp
[modify] https://crrev.com/b12c489b9a470b61f23de3aa27c627eb3a733b4f/third_party/WebKit/Source/core/css/StyleRule.cpp
[modify] https://crrev.com/b12c489b9a470b61f23de3aa27c627eb3a733b4f/third_party/WebKit/Source/core/frame/BarProp.cpp
[modify] https://crrev.com/b12c489b9a470b61f23de3aa27c627eb3a733b4f/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/b12c489b9a470b61f23de3aa27c627eb3a733b4f/third_party/WebKit/Source/core/layout/LayoutText.h
[modify] https://crrev.com/b12c489b9a470b61f23de3aa27c627eb3a733b4f/third_party/WebKit/Source/core/style/ShapeValue.h
[modify] https://crrev.com/b12c489b9a470b61f23de3aa27c627eb3a733b4f/third_party/WebKit/Source/core/svg/SVGAngle.cpp
[modify] https://crrev.com/b12c489b9a470b61f23de3aa27c627eb3a733b4f/third_party/WebKit/Source/core/svg/SVGPoint.cpp
[modify] https://crrev.com/b12c489b9a470b61f23de3aa27c627eb3a733b4f/third_party/WebKit/Source/core/svg/SVGString.cpp
Project Member

Comment 78 by bugdroid1@chromium.org, Nov 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67f3e693b8b02c8a7b2fc15f12e985924cf539a7

commit 67f3e693b8b02c8a7b2fc15f12e985924cf539a7
Author: haraken <haraken@chromium.org>
Date: Wed Nov 30 09:20:59 2016

Add a comment that CHECK should not be used until the performance issue is fixed.

BUG=596760

Review-Url: https://codereview.chromium.org/2544443002
Cr-Commit-Position: refs/heads/master@{#435197}

[modify] https://crrev.com/67f3e693b8b02c8a7b2fc15f12e985924cf539a7/third_party/WebKit/Source/wtf/Assertions.h
Project Member

Comment 79 by bugdroid1@chromium.org, Dec 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03e415cffc61351a6b97d069aedbb22edcfc8aec

commit 03e415cffc61351a6b97d069aedbb22edcfc8aec
Author: tkent <tkent@chromium.org>
Date: Mon Dec 19 04:28:14 2016

Replace ASSERT, ENABLE(ASSERT), and ASSERT_NOT_REACHED in wtf

with DCHECK_op, DCHECK_IS_ON(), and NOTREACHED respectively.
This CL added some functions to WTF::HashTable to reduce '#if DCHECK_IS_ON()'.
UNIMPLEMENTED macro in OffscreenCanvasRenderingContext2D.cpp is removed because
it conflicts to utils.h and is not used.

This CL has no behavior changes.

BUG=596760

Review-Url: https://codereview.chromium.org/2585673002
Cr-Commit-Position: refs/heads/master@{#439409}

[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/ASCIICType.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/Atomics.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/BitVector.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/BitVector.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/BloomFilter.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/DateMath.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/Deque.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/DoublyLinkedList.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/HashCountedSet.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/HashMapTest.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/HashTable.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/HexNumber.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/InstanceCounter.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/LinkedHashSet.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/LinkedStack.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/ListHashSet.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/MathExtras.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/RefCounted.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/SizeLimits.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/StdLibExtras.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/StringHasher.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/TerminatedArrayBuilder.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/ThreadRestrictionVerifier.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/ThreadSpecific.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/ThreadingPrimitives.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/TreeNode.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/Vector.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/allocator/PartitionAllocator.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/allocator/Partitions.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/allocator/Partitions.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/dtoa.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/dtoa/diy-fp.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/dtoa/double-conversion.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/dtoa/double.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/dtoa/utils.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/text/ASCIIFastPath.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/text/IntegerToStringConversion.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/text/StringBuffer.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/text/StringConcatenate.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/text/StringHash.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/text/StringImpl.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/text/StringImpl.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/text/StringImplCF.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/text/StringOperators.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/text/StringStatics.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/text/TextCodec.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/text/TextCodecICU.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/text/TextCodecUTF16.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/text/TextCodecUTF8.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/text/TextEncoding.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/text/UTF8.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/text/WTFString.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/text/WTFString.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/text/icu/CollatorICU.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferBuilder.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferContents.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferContents.h
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferView.cpp
[modify] https://crrev.com/03e415cffc61351a6b97d069aedbb22edcfc8aec/third_party/WebKit/Source/wtf/typed_arrays/ArrayPiece.cpp

Comment 80 by tkent@chromium.org, Dec 19 2016

Blockedon: 672699
Project Member

Comment 82 by bugdroid1@chromium.org, Jan 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4203db424afef97fd382185990f0308383803d6

commit e4203db424afef97fd382185990f0308383803d6
Author: wez <wez@chromium.org>
Date: Thu Jan 12 21:56:37 2017

Alias all wtf/Assertions.h macros to their base/ equivalents.

BUG=596760

Review-Url: https://codereview.chromium.org/2623143006
Cr-Commit-Position: refs/heads/master@{#443377}

[modify] https://crrev.com/e4203db424afef97fd382185990f0308383803d6/third_party/WebKit/Source/wtf/Assertions.h
Project Member

Comment 83 by bugdroid1@chromium.org, Jan 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/696cda00223a1d0d90fe27c7d401b129e58ea245

commit 696cda00223a1d0d90fe27c7d401b129e58ea245
Author: tkent <tkent@chromium.org>
Date: Thu Jan 19 15:15:23 2017

Replace ENABLE(ASSERT) with DCHECK_IS_ON().

This CL doesn't affect production code.

BUG=596760
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2640163004
Cr-Commit-Position: refs/heads/master@{#444735}

[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/LayoutTests/svg/text/tspan-outline-multiple-inline-box-expected.txt
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/LayoutTests/svg/text/tspan-outline-multiple-inline-box.svg
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/bindings/core/v8/ScriptFunction.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/bindings/core/v8/ScriptFunction.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/bindings/core/v8/ScriptState.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/bindings/core/v8/V8StringResource.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/clipboard/DataObject.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/fileapi/File.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/frame/EventHandlerRegistry.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/frame/FrameHost.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/frame/SuspendableTimer.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/frame/SuspendableTimer.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/html/parser/BackgroundHTMLInputStream.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/html/parser/HTMLToken.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/FloatingObjects.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/FloatingObjects.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/LayoutBlock.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/LayoutGeometryMap.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/LayoutGrid.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/LayoutMedia.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/LayoutTableCell.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/LayoutText.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/LayoutText.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/LayoutView.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/PaintInvalidationState.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/TextAutosizer.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerTreeBuilder.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/line/InlineBox.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/line/InlineBox.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/line/LineBoxList.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/line/LineBoxList.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/page/Page.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/paint/PaintLayerStackingNode.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/paint/PaintLayerStackingNode.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/paint/SVGPaintContext.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/paint/SVGPaintContext.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/style/GridArea.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/svg/SVGElement.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/svg/SVGElement.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/svg/SVGUseElement.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/modules/indexeddb/IDBKeyPath.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/modules/webdatabase/Database.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/modules/webdatabase/DatabaseManager.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/modules/webdatabase/SQLTransactionStateMachine.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/audio/ffmpeg/FFTFrameFFMPEG.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/fonts/FontCache.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/geometry/FloatRect.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/geometry/FloatRect.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/graphics/GraphicsContext.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/graphics/GraphicsLayerClient.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/graphics/Path.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/graphics/Path.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClientTest.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/CallbackStack.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/CallbackStack.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/GCInfo.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/GCInfo.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/Heap.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/Heap.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/HeapAllocator.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/HeapCompact.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/HeapPage.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/HeapPage.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/InlinedGlobalMarkingVisitor.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/MarkingVisitor.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/PagePool.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/PagePool.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/Persistent.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/PersistentNode.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/ThreadState.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/ThreadState.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/TraceTraits.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/Visitor.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/heap/Visitor.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/text/BidiResolver.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/platform/weborigin/KURL.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/wtf/Assertions.h
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/wtf/AssertionsTest.cpp
[modify] https://crrev.com/696cda00223a1d0d90fe27c7d401b129e58ea245/third_party/WebKit/Source/wtf/dtoa/cached-powers.cc
Project Member

Comment 84 by bugdroid1@chromium.org, Jan 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95e14f9bd10025985df163114945a270e2d69bc3

commit 95e14f9bd10025985df163114945a270e2d69bc3
Author: tkent <tkent@chromium.org>
Date: Fri Jan 20 08:55:47 2017

Replace ENABLE(ASSERT) leftovers with DCHECK_IS_ON().

BUG=596760

Review-Url: https://codereview.chromium.org/2649523002
Cr-Commit-Position: refs/heads/master@{#445020}

[modify] https://crrev.com/95e14f9bd10025985df163114945a270e2d69bc3/third_party/WebKit/Source/core/layout/FloatingObjects.cpp

Comment 85 by w...@chromium.org, Jan 24 2017

Blockedon: 598886
Project Member

Comment 86 by bugdroid1@chromium.org, Jan 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf51bcfadc991bbf00161d8a28fa7fdad74b8222

commit bf51bcfadc991bbf00161d8a28fa7fdad74b8222
Author: wez <wez@chromium.org>
Date: Thu Jan 26 19:40:26 2017

Remove outdated __GLIBCXX_ checks in base::StackTrace for POSIX.

This fixes symbol name unmangling under Mac OS X, where we have switched
from building against libstdc++, which defines __GLIBCXX__, to libc++,
which does not. All we actually care about is that the C++ library
provides the abi::__cxa_demangle() API, which both libraries do.

BUG=598886,596760

Review-Url: https://codereview.chromium.org/2651893002
Cr-Commit-Position: refs/heads/master@{#446398}

[modify] https://crrev.com/bf51bcfadc991bbf00161d8a28fa7fdad74b8222/base/debug/stack_trace_posix.cc

Comment 88 by tkent@chromium.org, Feb 7 2017

Labels: -Type-Bug Type-Task

Comment 89 by tkent@chromium.org, Mar 2 2017

Blockedon: 697685

Comment 90 by tkent@chromium.org, Mar 2 2017

Blockedon: 697688

Comment 91 by tkent@chromium.org, Mar 2 2017

Blockedon: 697687

Comment 92 by tkent@chromium.org, Mar 2 2017

Blockedon: 697692
Project Member

Comment 94 by bugdroid1@chromium.org, Mar 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/020397fbdf70bb4398dab310bccb437ba5b2377a

commit 020397fbdf70bb4398dab310bccb437ba5b2377a
Author: tkent <tkent@chromium.org>
Date: Thu Mar 02 09:18:26 2017

Replace RELEASE_ASSERT with CHECK in core/{dom,editing,html}

BUG=596760

Review-Url: https://codereview.chromium.org/2727843003
Cr-Commit-Position: refs/heads/master@{#454217}

[modify] https://crrev.com/020397fbdf70bb4398dab310bccb437ba5b2377a/third_party/WebKit/Source/core/dom/AttributeCollection.h
[modify] https://crrev.com/020397fbdf70bb4398dab310bccb437ba5b2377a/third_party/WebKit/Source/core/dom/DOMDataView.cpp
[modify] https://crrev.com/020397fbdf70bb4398dab310bccb437ba5b2377a/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/020397fbdf70bb4398dab310bccb437ba5b2377a/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp
[modify] https://crrev.com/020397fbdf70bb4398dab310bccb437ba5b2377a/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/020397fbdf70bb4398dab310bccb437ba5b2377a/third_party/WebKit/Source/core/dom/NodeRareData.cpp
[modify] https://crrev.com/020397fbdf70bb4398dab310bccb437ba5b2377a/third_party/WebKit/Source/core/dom/NodeRareData.h
[modify] https://crrev.com/020397fbdf70bb4398dab310bccb437ba5b2377a/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/020397fbdf70bb4398dab310bccb437ba5b2377a/third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskQueueBase.cpp
[modify] https://crrev.com/020397fbdf70bb4398dab310bccb437ba5b2377a/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp
[modify] https://crrev.com/020397fbdf70bb4398dab310bccb437ba5b2377a/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp
[modify] https://crrev.com/020397fbdf70bb4398dab310bccb437ba5b2377a/third_party/WebKit/Source/core/html/ImageDocument.cpp
[modify] https://crrev.com/020397fbdf70bb4398dab310bccb437ba5b2377a/third_party/WebKit/Source/core/html/PluginDocument.cpp
[modify] https://crrev.com/020397fbdf70bb4398dab310bccb437ba5b2377a/third_party/WebKit/Source/core/html/forms/FormController.cpp

Comment 95 by tkent@chromium.org, Apr 3 2017

Blockedon: 707638

Comment 96 by tkent@chromium.org, Apr 3 2017

Blockedon: 707641

Comment 97 by tkent@chromium.org, Apr 3 2017

Blockedon: 707642

Comment 98 by tkent@chromium.org, Apr 4 2017

Blockedon: 708056

Comment 99 by tkent@chromium.org, Apr 4 2017

Blockedon: 708057
Project Member

Comment 100 by bugdroid1@chromium.org, May 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67e8cb2a0da35fe657eb91028b49f4340492b935

commit 67e8cb2a0da35fe657eb91028b49f4340492b935
Author: pilgrim <pilgrim@chromium.org>
Date: Wed May 03 12:18:50 2017

Remove obsolete ASSERT_NOT_REACHED

BUG=596760

Review-Url: https://codereview.chromium.org/2858613002
Cr-Commit-Position: refs/heads/master@{#468944}

[modify] https://crrev.com/67e8cb2a0da35fe657eb91028b49f4340492b935/third_party/WebKit/Source/platform/wtf/Assertions.h
Project Member

Comment 101 by bugdroid1@chromium.org, May 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6

commit a30679c30fc4d5074fe2f7ff1d27a404fca84ff6
Author: pilgrim <pilgrim@chromium.org>
Date: Tue May 09 04:22:40 2017

Replace ASSERT with DCHECK in core/

This CL only affects instances of ASSERT() that have unary parameters
with no (in)equality checks.

BUG=596760

Review-Url: https://codereview.chromium.org/2858963002
Cr-Commit-Position: refs/heads/master@{#470199}

[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/CoreInitializer.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/clipboard/DataObject.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/clipboard/DataObject.h
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/clipboard/DataObjectItem.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/clipboard/DraggedIsolatedFileSystem.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/clipboard/Pasteboard.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/css/RuleSet.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/css/SelectorFilter.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/DOMTimer.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/DOMWindow.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/Frame.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/FrameSerializer.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/FrameViewAutoSizeInfo.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/LayoutSubtreeRootList.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/PlatformEventController.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/PlatformEventDispatcher.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/RemoteFrame.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/RemoteFrameView.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/RemoteFrameView.h
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/RootFrameViewport.h
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/SmartClip.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/SuspendableTimer.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/VisualViewport.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/html/canvas/CanvasFontCache.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/input/TouchEventManager.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/inspector/DOMEditor.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/inspector/DOMPatchSupport.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/page/ChromeClient.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/page/ContextMenuController.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/page/CreateWindow.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/page/PagePopupController.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/page/PagePopupSupplement.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/page/PrintContext.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/page/SpatialNavigation.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/page/TouchAdjustment.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/streams/ReadableStreamOperationsTest.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/timing/PerformanceObserver.cpp
[modify] https://crrev.com/a30679c30fc4d5074fe2f7ff1d27a404fca84ff6/third_party/WebKit/Source/core/timing/SharedWorkerPerformance.cpp
Project Member

Comment 102 by bugdroid1@chromium.org, May 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53082dc60af4f4f0586b86e1dc92bf6355b7af07

commit 53082dc60af4f4f0586b86e1dc92bf6355b7af07
Author: pilgrim <pilgrim@chromium.org>
Date: Tue May 09 04:40:03 2017

Replace ASSERT with DCHECK in modules/

This CL only affects instances of ASSERT() that have unary parameters
with no (in)equality checks.

BUG=596760
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2862963003
Cr-Commit-Position: refs/heads/master@{#470215}

[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/audio_output_devices/SetSinkIdCallbacks.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/cachestorage/Cache.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/canvas2d/CanvasStyle.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/compositorworker/CompositorWorker.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/csspaint/PaintWorkletTest.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/encoding/TextDecoder.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/netinfo/NavigatorNetworkInformation.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/netinfo/WorkerNavigatorNetworkInformation.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/presentation/Presentation.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityCallbacks.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/speech/SpeechRecognition.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/speech/testing/PlatformSpeechSynthesizerMock.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/webgl/WebGLActiveInfo.h
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/webgl/WebGLBuffer.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/webgl/WebGLObject.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/webgl/WebGLQuery.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/webgl/WebGLUniformLocation.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/webusb/USBAlternateInterface.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/webusb/USBConfiguration.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/webusb/USBDevice.cpp
[modify] https://crrev.com/53082dc60af4f4f0586b86e1dc92bf6355b7af07/third_party/WebKit/Source/modules/webusb/USBEndpoint.cpp
Project Member

Comment 103 by bugdroid1@chromium.org, May 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a469806c5653b6fae16b055d017f0c55cfaf9a59

commit a469806c5653b6fae16b055d017f0c55cfaf9a59
Author: pilgrim <pilgrim@chromium.org>
Date: Mon May 15 18:22:16 2017

Replace ASSERT with DCHECK_EQ as appropriate

BUG=596760
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2873293002
Cr-Commit-Position: refs/heads/master@{#471834}

[modify] https://crrev.com/a469806c5653b6fae16b055d017f0c55cfaf9a59/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp
[modify] https://crrev.com/a469806c5653b6fae16b055d017f0c55cfaf9a59/third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl
[modify] https://crrev.com/a469806c5653b6fae16b055d017f0c55cfaf9a59/third_party/WebKit/Source/build/scripts/templates/MakeQualifiedNames.cpp.tmpl
[modify] https://crrev.com/a469806c5653b6fae16b055d017f0c55cfaf9a59/third_party/WebKit/Source/core/clipboard/DataObject.cpp
[modify] https://crrev.com/a469806c5653b6fae16b055d017f0c55cfaf9a59/third_party/WebKit/Source/core/clipboard/DataObjectItem.cpp
[modify] https://crrev.com/a469806c5653b6fae16b055d017f0c55cfaf9a59/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp
[modify] https://crrev.com/a469806c5653b6fae16b055d017f0c55cfaf9a59/third_party/WebKit/Source/core/frame/DeprecatedScheduleStyleRecalcDuringLayout.cpp
[modify] https://crrev.com/a469806c5653b6fae16b055d017f0c55cfaf9a59/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/a469806c5653b6fae16b055d017f0c55cfaf9a59/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/a469806c5653b6fae16b055d017f0c55cfaf9a59/third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp
[modify] https://crrev.com/a469806c5653b6fae16b055d017f0c55cfaf9a59/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
[modify] https://crrev.com/a469806c5653b6fae16b055d017f0c55cfaf9a59/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/a469806c5653b6fae16b055d017f0c55cfaf9a59/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/a469806c5653b6fae16b055d017f0c55cfaf9a59/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp
[modify] https://crrev.com/a469806c5653b6fae16b055d017f0c55cfaf9a59/third_party/WebKit/Source/platform/mhtml/MHTMLParser.cpp
Project Member

Comment 104 by bugdroid1@chromium.org, May 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2679a47b0241a1012b2b0710663993fd6d10ee29

commit 2679a47b0241a1012b2b0710663993fd6d10ee29
Author: pilgrim <pilgrim@chromium.org>
Date: Tue May 16 23:41:00 2017

Replace ASSERT with DCHECK in Nullable

This CL is separate from the others because I want to have a discussion
about possible performance regressions before committing.

BUG=596760

Review-Url: https://codereview.chromium.org/2887883002
Cr-Commit-Position: refs/heads/master@{#472251}

[modify] https://crrev.com/2679a47b0241a1012b2b0710663993fd6d10ee29/third_party/WebKit/Source/bindings/core/v8/Nullable.h
Project Member

Comment 105 by bugdroid1@chromium.org, May 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9146f39d166a427f4030a5a8f7f22548a75f1744

commit 9146f39d166a427f4030a5a8f7f22548a75f1744
Author: pilgrim <pilgrim@chromium.org>
Date: Wed May 17 00:58:19 2017

Remove obsolete RELEASE_ASSERT macro definition

BUG=596760

Review-Url: https://codereview.chromium.org/2885003003
Cr-Commit-Position: refs/heads/master@{#472274}

[modify] https://crrev.com/9146f39d166a427f4030a5a8f7f22548a75f1744/third_party/WebKit/Source/platform/wtf/Assertions.h
Project Member

Comment 106 by bugdroid1@chromium.org, May 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60ff31cedabb9cde2a0fd70d74f3eaf7be94abda

commit 60ff31cedabb9cde2a0fd70d74f3eaf7be94abda
Author: pilgrim <pilgrim@chromium.org>
Date: Thu May 18 21:53:50 2017

Replace ASSERT with DCHECK_LE/GE/GT/LT/NE as appropriate

BUG=596760

Review-Url: https://codereview.chromium.org/2883353002
Cr-Commit-Position: refs/heads/master@{#472943}

[modify] https://crrev.com/60ff31cedabb9cde2a0fd70d74f3eaf7be94abda/third_party/WebKit/Source/build/scripts/templates/StyleBuilder.cpp.tmpl
[modify] https://crrev.com/60ff31cedabb9cde2a0fd70d74f3eaf7be94abda/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
[modify] https://crrev.com/60ff31cedabb9cde2a0fd70d74f3eaf7be94abda/third_party/WebKit/Source/core/frame/DOMTimer.cpp
[modify] https://crrev.com/60ff31cedabb9cde2a0fd70d74f3eaf7be94abda/third_party/WebKit/Source/core/frame/FrameViewAutoSizeInfo.cpp
[modify] https://crrev.com/60ff31cedabb9cde2a0fd70d74f3eaf7be94abda/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
[modify] https://crrev.com/60ff31cedabb9cde2a0fd70d74f3eaf7be94abda/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/60ff31cedabb9cde2a0fd70d74f3eaf7be94abda/third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp
[modify] https://crrev.com/60ff31cedabb9cde2a0fd70d74f3eaf7be94abda/third_party/WebKit/Source/core/frame/SuspendableTimer.cpp
[modify] https://crrev.com/60ff31cedabb9cde2a0fd70d74f3eaf7be94abda/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
[modify] https://crrev.com/60ff31cedabb9cde2a0fd70d74f3eaf7be94abda/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp
[modify] https://crrev.com/60ff31cedabb9cde2a0fd70d74f3eaf7be94abda/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp
[modify] https://crrev.com/60ff31cedabb9cde2a0fd70d74f3eaf7be94abda/third_party/WebKit/Source/core/page/PrintContext.cpp
[modify] https://crrev.com/60ff31cedabb9cde2a0fd70d74f3eaf7be94abda/third_party/WebKit/Source/core/page/scrolling/ScrollStateCallback.h
[modify] https://crrev.com/60ff31cedabb9cde2a0fd70d74f3eaf7be94abda/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
[modify] https://crrev.com/60ff31cedabb9cde2a0fd70d74f3eaf7be94abda/third_party/WebKit/Source/modules/bluetooth/BluetoothCharacteristicProperties.cpp
Project Member

Comment 107 by bugdroid1@chromium.org, May 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dc16ecb4daf2aca6cb20a7c7bc29f2f22a8948e

commit 1dc16ecb4daf2aca6cb20a7c7bc29f2f22a8948e
Author: gyuyoung <gyuyoung@igalia.com>
Date: Fri May 19 07:07:11 2017

Replace remaining ASSERT with DCHECK|DCHECK_FOO in core/frame

As a step to reduce uses of wtf/Assertions.h, This CL changes uses of ASSERT with
DCHECK() or DCHECK_FOO() in core/frame.

BUG=596760

Review-Url: https://codereview.chromium.org/2891843004
Cr-Commit-Position: refs/heads/master@{#473115}

[modify] https://crrev.com/1dc16ecb4daf2aca6cb20a7c7bc29f2f22a8948e/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp
[modify] https://crrev.com/1dc16ecb4daf2aca6cb20a7c7bc29f2f22a8948e/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/1dc16ecb4daf2aca6cb20a7c7bc29f2f22a8948e/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
[modify] https://crrev.com/1dc16ecb4daf2aca6cb20a7c7bc29f2f22a8948e/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/1dc16ecb4daf2aca6cb20a7c7bc29f2f22a8948e/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp
[modify] https://crrev.com/1dc16ecb4daf2aca6cb20a7c7bc29f2f22a8948e/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
[modify] https://crrev.com/1dc16ecb4daf2aca6cb20a7c7bc29f2f22a8948e/third_party/WebKit/Source/core/frame/csp/MediaListDirective.cpp
Project Member

Comment 108 by bugdroid1@chromium.org, May 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b65c469423afabf0a29df2dfbf04db9b2a209eb

commit 9b65c469423afabf0a29df2dfbf04db9b2a209eb
Author: gyuyoung <gyuyoung@igalia.com>
Date: Sun May 21 09:05:02 2017

Clean up remaining uses of ASSERT in core

As a step to reduce uses of wtf/Assertions.h, This CL changes all uses of ASSERT with
DCHECK() or DCHECK_FOO() in core.

BUG=596760

Review-Url: https://codereview.chromium.org/2899573002
Cr-Commit-Position: refs/heads/master@{#473464}

[modify] https://crrev.com/9b65c469423afabf0a29df2dfbf04db9b2a209eb/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
[modify] https://crrev.com/9b65c469423afabf0a29df2dfbf04db9b2a209eb/third_party/WebKit/Source/core/css/CSSBasicShapeValues.cpp
[modify] https://crrev.com/9b65c469423afabf0a29df2dfbf04db9b2a209eb/third_party/WebKit/Source/core/html/canvas/CanvasFontCache.cpp
[modify] https://crrev.com/9b65c469423afabf0a29df2dfbf04db9b2a209eb/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
[modify] https://crrev.com/9b65c469423afabf0a29df2dfbf04db9b2a209eb/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/9b65c469423afabf0a29df2dfbf04db9b2a209eb/third_party/WebKit/Source/core/inspector/InspectorTaskRunner.cpp
[modify] https://crrev.com/9b65c469423afabf0a29df2dfbf04db9b2a209eb/third_party/WebKit/Source/core/page/ContextMenuController.cpp
[modify] https://crrev.com/9b65c469423afabf0a29df2dfbf04db9b2a209eb/third_party/WebKit/Source/core/page/CreateWindow.cpp
[modify] https://crrev.com/9b65c469423afabf0a29df2dfbf04db9b2a209eb/third_party/WebKit/Source/core/page/FrameTree.cpp
[modify] https://crrev.com/9b65c469423afabf0a29df2dfbf04db9b2a209eb/third_party/WebKit/Source/core/page/SpatialNavigation.cpp
[modify] https://crrev.com/9b65c469423afabf0a29df2dfbf04db9b2a209eb/third_party/WebKit/Source/core/page/TouchAdjustment.cpp
[modify] https://crrev.com/9b65c469423afabf0a29df2dfbf04db9b2a209eb/third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp
Project Member

Comment 109 by bugdroid1@chromium.org, May 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc46f058031dbb3c94c9b032e1b0f54028bee885

commit dc46f058031dbb3c94c9b032e1b0f54028bee885
Author: pilgrim <pilgrim@chromium.org>
Date: Tue May 23 02:54:17 2017

Replace remaining ASSERT with DCHECK/_EQ as appropriate

BUG=596760
TBR=mkwst

Review-Url: https://codereview.chromium.org/2896443003
Cr-Commit-Position: refs/heads/master@{#473792}

[modify] https://crrev.com/dc46f058031dbb3c94c9b032e1b0f54028bee885/third_party/WebKit/Source/build/scripts/make_css_value_keywords.py
[modify] https://crrev.com/dc46f058031dbb3c94c9b032e1b0f54028bee885/third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl
[modify] https://crrev.com/dc46f058031dbb3c94c9b032e1b0f54028bee885/third_party/WebKit/Source/build/scripts/templates/StyleBuilder.cpp.tmpl
[modify] https://crrev.com/dc46f058031dbb3c94c9b032e1b0f54028bee885/third_party/WebKit/Source/build/scripts/templates/StylePropertyShorthand.cpp.tmpl
[modify] https://crrev.com/dc46f058031dbb3c94c9b032e1b0f54028bee885/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/dc46f058031dbb3c94c9b032e1b0f54028bee885/third_party/WebKit/Source/core/input/TouchEventManager.cpp
[modify] https://crrev.com/dc46f058031dbb3c94c9b032e1b0f54028bee885/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp
[modify] https://crrev.com/dc46f058031dbb3c94c9b032e1b0f54028bee885/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp
[modify] https://crrev.com/dc46f058031dbb3c94c9b032e1b0f54028bee885/third_party/WebKit/Source/platform/mojo/ReferrerStructTraits.h
[modify] https://crrev.com/dc46f058031dbb3c94c9b032e1b0f54028bee885/third_party/WebKit/Source/platform/weborigin/KURL.cpp
[modify] https://crrev.com/dc46f058031dbb3c94c9b032e1b0f54028bee885/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/dc46f058031dbb3c94c9b032e1b0f54028bee885/third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp
Project Member

Comment 110 by bugdroid1@chromium.org, May 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d465e31bd450870f7191218231b0180f163421bb

commit d465e31bd450870f7191218231b0180f163421bb
Author: pilgrim <pilgrim@chromium.org>
Date: Tue May 23 16:28:24 2017

Remove obsolete ASSERT macros

BUG=596760

Review-Url: https://codereview.chromium.org/2901843002
Cr-Commit-Position: refs/heads/master@{#473932}

[modify] https://crrev.com/d465e31bd450870f7191218231b0180f163421bb/third_party/WebKit/Source/platform/wtf/Assertions.h

Comment 111 by thakis@chromium.org, May 23 2017 

\o/
Project Member

Comment 112 by bugdroid1@chromium.org, May 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f5c1c21e2ff5135de2ba685ae5c3454f6542aad

commit 3f5c1c21e2ff5135de2ba685ae5c3454f6542aad
Author: gyuyoung <gyuyoung@igalia.com>
Date: Wed May 31 19:13:43 2017

Use IMMEDIATE_CRASH() instead of CRASH() directly

As a step to reduce uses of macros defined in wtf/Assertions.h, this CL cleans
all uses of CRASH() up. Instead we uses IMMEDIATE_CRASH() directly.

BUG=596760

Review-Url: https://codereview.chromium.org/2919443002
Cr-Commit-Position: refs/heads/master@{#475978}

[modify] https://crrev.com/3f5c1c21e2ff5135de2ba685ae5c3454f6542aad/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/3f5c1c21e2ff5135de2ba685ae5c3454f6542aad/third_party/WebKit/Source/core/dom/Text.cpp
[modify] https://crrev.com/3f5c1c21e2ff5135de2ba685ae5c3454f6542aad/third_party/WebKit/Source/core/layout/LayoutTableCell.h
[modify] https://crrev.com/3f5c1c21e2ff5135de2ba685ae5c3454f6542aad/third_party/WebKit/Source/core/layout/LayoutTableRow.h
[modify] https://crrev.com/3f5c1c21e2ff5135de2ba685ae5c3454f6542aad/third_party/WebKit/Source/core/layout/LayoutText.cpp
[modify] https://crrev.com/3f5c1c21e2ff5135de2ba685ae5c3454f6542aad/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp
[modify] https://crrev.com/3f5c1c21e2ff5135de2ba685ae5c3454f6542aad/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/3f5c1c21e2ff5135de2ba685ae5c3454f6542aad/third_party/WebKit/Source/platform/mac/BlockExceptions.mm
[modify] https://crrev.com/3f5c1c21e2ff5135de2ba685ae5c3454f6542aad/third_party/WebKit/Source/platform/wtf/Assertions.h
[modify] https://crrev.com/3f5c1c21e2ff5135de2ba685ae5c3454f6542aad/third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp
[modify] https://crrev.com/3f5c1c21e2ff5135de2ba685ae5c3454f6542aad/third_party/WebKit/Source/platform/wtf/ThreadSpecific.h
[modify] https://crrev.com/3f5c1c21e2ff5135de2ba685ae5c3454f6542aad/third_party/WebKit/Source/platform/wtf/ThreadSpecificWin.cpp
[modify] https://crrev.com/3f5c1c21e2ff5135de2ba685ae5c3454f6542aad/third_party/WebKit/Source/platform/wtf/text/StringImpl.cpp
[modify] https://crrev.com/3f5c1c21e2ff5135de2ba685ae5c3454f6542aad/third_party/WebKit/Source/platform/wtf/text/TextCodecUTF8.cpp
[modify] https://crrev.com/3f5c1c21e2ff5135de2ba685ae5c3454f6542aad/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
Project Member

Comment 113 by bugdroid1@chromium.org, Jun 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46740f4e99de22f90302e72ca3a91730521b5827

commit 46740f4e99de22f90302e72ca3a91730521b5827
Author: gyuyoung <gyuyoung@igalia.com>
Date: Mon Jun 05 05:29:54 2017

Use LOG(FATAL) or CHECK*() instead of IMMEDIATE_CRASH

Apply review comments in issue 2919443002. Use LOG() and CHECK*() to simplify
the code.

BUG=596760

Review-Url: https://codereview.chromium.org/2919653004
Cr-Commit-Position: refs/heads/master@{#476946}

[modify] https://crrev.com/46740f4e99de22f90302e72ca3a91730521b5827/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/46740f4e99de22f90302e72ca3a91730521b5827/third_party/WebKit/Source/core/dom/Text.cpp
[modify] https://crrev.com/46740f4e99de22f90302e72ca3a91730521b5827/third_party/WebKit/Source/core/layout/LayoutTableCell.h
[modify] https://crrev.com/46740f4e99de22f90302e72ca3a91730521b5827/third_party/WebKit/Source/core/layout/LayoutTableRow.h
[modify] https://crrev.com/46740f4e99de22f90302e72ca3a91730521b5827/third_party/WebKit/Source/core/layout/LayoutText.cpp
[modify] https://crrev.com/46740f4e99de22f90302e72ca3a91730521b5827/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp
[modify] https://crrev.com/46740f4e99de22f90302e72ca3a91730521b5827/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/46740f4e99de22f90302e72ca3a91730521b5827/third_party/WebKit/Source/platform/mac/BlockExceptions.mm
[modify] https://crrev.com/46740f4e99de22f90302e72ca3a91730521b5827/third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp
[modify] https://crrev.com/46740f4e99de22f90302e72ca3a91730521b5827/third_party/WebKit/Source/platform/wtf/ThreadSpecific.h
[modify] https://crrev.com/46740f4e99de22f90302e72ca3a91730521b5827/third_party/WebKit/Source/platform/wtf/ThreadSpecificWin.cpp
[modify] https://crrev.com/46740f4e99de22f90302e72ca3a91730521b5827/third_party/WebKit/Source/platform/wtf/text/StringImpl.cpp
[modify] https://crrev.com/46740f4e99de22f90302e72ca3a91730521b5827/third_party/WebKit/Source/platform/wtf/text/TextCodecUTF8.cpp
[modify] https://crrev.com/46740f4e99de22f90302e72ca3a91730521b5827/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
Project Member

Comment 115 by bugdroid1@chromium.org, Jul 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb977908abd082a0e0c8fed12f81e67628236fe0

commit fb977908abd082a0e0c8fed12f81e67628236fe0
Author: Gyuyoung Kim <gyuyoung@igalia.com>
Date: Mon Jul 31 13:43:06 2017

Separate ScopedLogger class from wtf/Assertion.cpp/h

As a step to reduce uses of wtf/Assertions.cpp/h, this CL extracts ScopedLogger class
from Assertions.cpp/h files.

BUG=596760

TEST: The unit test for ScopedLogger starts to work on ScopedLoggerTest.cpp.
Change-Id: Iceaee21136fae9244c96579f3a7bd963f89b2eec
Reviewed-on: https://chromium-review.googlesource.com/577576
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490753}
[modify] https://crrev.com/fb977908abd082a0e0c8fed12f81e67628236fe0/third_party/WebKit/Source/platform/wtf/Assertions.cpp
[modify] https://crrev.com/fb977908abd082a0e0c8fed12f81e67628236fe0/third_party/WebKit/Source/platform/wtf/Assertions.h
[modify] https://crrev.com/fb977908abd082a0e0c8fed12f81e67628236fe0/third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp
[modify] https://crrev.com/fb977908abd082a0e0c8fed12f81e67628236fe0/third_party/WebKit/Source/platform/wtf/BUILD.gn
[add] https://crrev.com/fb977908abd082a0e0c8fed12f81e67628236fe0/third_party/WebKit/Source/platform/wtf/ScopedLogger.cpp
[add] https://crrev.com/fb977908abd082a0e0c8fed12f81e67628236fe0/third_party/WebKit/Source/platform/wtf/ScopedLogger.h
[add] https://crrev.com/fb977908abd082a0e0c8fed12f81e67628236fe0/third_party/WebKit/Source/platform/wtf/ScopedLoggerTest.cpp

Comment 116 by tkent@chromium.org, Jan 9 2018

Status: Fixed (was: Available)
I think we have done this.
Showing comments 17 - 116 of 116 Older ›
►

Sign in to add a comment