New issue
Advanced search Search tips

Issue 596737 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature

Blocking:
issue 597789



Sign in to add a comment

Blimp 0.5 client: Version info

Project Member Reported by mdw@chromium.org, Mar 22 2016

Issue description

The client needs a three dots menu with information on the current client version as well as the current engine version and other useful information. Difficult to diagnose problems when we don't know what we're running.

 

Comment 1 by klo...@chromium.org, Mar 22 2016

Owner: shaktisahu@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by w...@chromium.org, Apr 1 2016

Blocking: 597789
Labels: -Type-Bug -Pri-2 Pri-3 Type-Feature
Labels: M-52
Labels: Blimp-M52-Proj-Scope
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c8d461d1897b9ea842ffae9056a2530b3e33b5f

commit 2c8d461d1897b9ea842ffae9056a2530b3e33b5f
Author: shaktisahu <shaktisahu@chromium.org>
Date: Wed Apr 13 22:24:39 2016

Added Version Info page to toolbar menu

Added an option "Version Info" to the three dots menu in toolbar. This page would show blimp client version (same as version from manifest), operating System, engine IP, engine version, assigner info etc.

BUG= 596737 

Review URL: https://codereview.chromium.org/1842403003

Cr-Commit-Position: refs/heads/master@{#387123}

[modify] https://crrev.com/2c8d461d1897b9ea842ffae9056a2530b3e33b5f/blimp/client/BUILD.gn
[modify] https://crrev.com/2c8d461d1897b9ea842ffae9056a2530b3e33b5f/blimp/client/app/android/AndroidManifest.xml.jinja2
[modify] https://crrev.com/2c8d461d1897b9ea842ffae9056a2530b3e33b5f/blimp/client/app/android/blimp_client_session_android.cc
[modify] https://crrev.com/2c8d461d1897b9ea842ffae9056a2530b3e33b5f/blimp/client/app/android/blimp_client_session_android.h
[add] https://crrev.com/2c8d461d1897b9ea842ffae9056a2530b3e33b5f/blimp/client/app/android/java/res/xml/about_blimp_preferences.xml
[modify] https://crrev.com/2c8d461d1897b9ea842ffae9056a2530b3e33b5f/blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java
[modify] https://crrev.com/2c8d461d1897b9ea842ffae9056a2530b3e33b5f/blimp/client/app/android/java/src/org/chromium/blimp/session/BlimpClientSession.java
[add] https://crrev.com/2c8d461d1897b9ea842ffae9056a2530b3e33b5f/blimp/client/app/android/java/src/org/chromium/blimp/session/EngineInfo.java
[add] https://crrev.com/2c8d461d1897b9ea842ffae9056a2530b3e33b5f/blimp/client/app/android/java/src/org/chromium/blimp/settings/AboutBlimpPreferences.java
[add] https://crrev.com/2c8d461d1897b9ea842ffae9056a2530b3e33b5f/blimp/client/app/android/java/src/org/chromium/blimp/settings/Preferences.java
[modify] https://crrev.com/2c8d461d1897b9ea842ffae9056a2530b3e33b5f/blimp/client/app/android/java/src/org/chromium/blimp/toolbar/Toolbar.java
[modify] https://crrev.com/2c8d461d1897b9ea842ffae9056a2530b3e33b5f/blimp/client/app/android/java/strings/android_blimp_strings.grd
[modify] https://crrev.com/2c8d461d1897b9ea842ffae9056a2530b3e33b5f/blimp/client/session/blimp_client_session.cc
[modify] https://crrev.com/2c8d461d1897b9ea842ffae9056a2530b3e33b5f/blimp/client/session/blimp_client_session.h

Status: Fixed (was: Assigned)
Labels: Archive-Blimp

Sign in to add a comment