New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596708 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Support displaying Nearby URLs according to distance

Project Member Reported by cco3@chromium.org, Mar 21 2016

Issue description

Currently, we sort URLs arbitrarily.  We need to add the necessary code to receive, store, and sort distances.
 
Labels: M-53
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b45c71553394235e1fac316479461b59b2d00dd

commit 3b45c71553394235e1fac316479461b59b2d00dd
Author: cco3 <cco3@chromium.org>
Date: Mon Apr 18 19:12:30 2016

Clear settings in Physical Web test setup

Some of the Physical Web tests have broken while we weren't looking.
First, the preferences are not being reset in setup.  Second, a race
condition has been introduced into one test, so we need to sleep
appropriately.

BUG= 596708 

Review URL: https://codereview.chromium.org/1891273005

Cr-Commit-Position: refs/heads/master@{#387979}

[modify] https://crrev.com/3b45c71553394235e1fac316479461b59b2d00dd/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
[modify] https://crrev.com/3b45c71553394235e1fac316479461b59b2d00dd/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java
[modify] https://crrev.com/3b45c71553394235e1fac316479461b59b2d00dd/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c74b5484e8ca993ee2cc47b115806e483189b1b

commit 9c74b5484e8ca993ee2cc47b115806e483189b1b
Author: cco3 <cco3@chromium.org>
Date: Wed Apr 20 00:17:03 2016

Add a UrlInfo class for the Physical Web

The UrlManager will store instances of UrlInfo instead of raw strings.
This will permit us to include distances when we are supplied with
those in the future.

BUG= 596708 

Review URL: https://codereview.chromium.org/1821823003

Cr-Commit-Position: refs/heads/master@{#388370}

[modify] https://crrev.com/9c74b5484e8ca993ee2cc47b115806e483189b1b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
[modify] https://crrev.com/9c74b5484e8ca993ee2cc47b115806e483189b1b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
[modify] https://crrev.com/9c74b5484e8ca993ee2cc47b115806e483189b1b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwsClient.java
[modify] https://crrev.com/9c74b5484e8ca993ee2cc47b115806e483189b1b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwsClientImpl.java
[add] https://crrev.com/9c74b5484e8ca993ee2cc47b115806e483189b1b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlInfo.java
[modify] https://crrev.com/9c74b5484e8ca993ee2cc47b115806e483189b1b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
[modify] https://crrev.com/9c74b5484e8ca993ee2cc47b115806e483189b1b/chrome/android/java_sources.gni
[modify] https://crrev.com/9c74b5484e8ca993ee2cc47b115806e483189b1b/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/MockPwsClient.java
[modify] https://crrev.com/9c74b5484e8ca993ee2cc47b115806e483189b1b/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java

Comment 4 by mmo...@chromium.org, May 16 2016

Labels: -Pri-3 Pri-2
Project Member

Comment 5 by bugdroid1@chromium.org, May 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/297ef9cd6d1ba95e027349a7d8ec76b8c5123dcb

commit 297ef9cd6d1ba95e027349a7d8ec76b8c5123dcb
Author: cco3 <cco3@chromium.org>
Date: Thu May 26 17:20:10 2016

Sort Physical Web URLs by distance

When displaying Physical Web URLs, it makes the most sense
to show the nearest URLs first.  This change sorts according
to distance (even though the distance currently in place is a
placeholder)

BUG= 596708 

Review-Url: https://codereview.chromium.org/2015523003
Cr-Commit-Position: refs/heads/master@{#396214}

[modify] https://crrev.com/297ef9cd6d1ba95e027349a7d8ec76b8c5123dcb/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
[modify] https://crrev.com/297ef9cd6d1ba95e027349a7d8ec76b8c5123dcb/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/982215050d8813f0c6d548c4d6f385ab94e29720

commit 982215050d8813f0c6d548c4d6f385ab94e29720
Author: Conley Owens <cco3@google.com>
Date: Thu Jul 07 18:24:48 2016

Comment 7 by cco3@chromium.org, Jul 7 2016

Status: Fixed (was: Untriaged)

Sign in to add a comment