New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596697 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

pp::Graphics2D: Only part of an image is repainted on Chrome OS

Reported by sergey.s...@gmail.com, Mar 21 2016

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 7978.18.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.32 Safari/537.36
Platform: 7978.18.0 (Official Build) beta-channel link

Example URL:

Steps to reproduce the problem:
1. Build the test application "Graphics 2D" from NaCl SDK (<nacl_sdk>/pepper_44/examplea/api/graphics_2d).
2. Install the test app using "Load unpacked extension...".
3. Launch the app.

What is the expected behavior?
You should be able to observe simulated flames when clicking on any area of the plugin.

What went wrong?
The image updates are happening only in the top-left quadrant of the screen.

Did this work before? Yes It works in Chrome OS version 49

Is it a problem with Flash or HTML5? N/A

Does this work in other browsers? N/A 

Chrome version: 50.0.2661.32  Channel: beta
OS Version: 7978.18.0
Flash Version: Shockwave Flash 21.0 r0

THe problem is observed on Chromebook Pixel.
It is not observed in a Chrome browser running on Windows.
 
IMG_4489.JPG
1.1 MB View Download
Attached a pre-built test app
graphics_2d.zip
1.0 MB Download

Comment 2 by xtralo...@gmail.com, Mar 22 2016

This is a major regression, which probably breaks a lot of apps using pp::Graphics2D and running on Chromebooks. We already received complaints from customers which are on beta channel.
Cc: osh...@chromium.org

Comment 4 by osh...@chromium.org, Mar 23 2016

Cc: keta...@chromium.org
use-zoom-for-dsf has been disabled on m50 (https://codereview.chromium.org/1794393004/ 50.0.2661.33), which is supposed to be in beta, but your version was older than that.

ketakid@, any idea what happened?

Comment 5 by osh...@chromium.org, Mar 23 2016

#2 you can disable this manually using #enable-use-zoom-for-dsf flag for the time being.

Comment 6 by osh...@chromium.org, Mar 23 2016

Owner: osh...@chromium.org
Status: Assigned (was: Unconfirmed)
I'll keep it open until next beta is shipped.
beta channel has updated to 50.0.2661.50 on ChromeOS, shall we mark this fixed?

Note, dev channel hasn't rolled past .32 yet, so until dev channel does I'd expect dev channel to exhibit this behavior.

Comment 8 by osh...@chromium.org, May 11 2016

Status: Started (was: Assigned)
I'm fixing this for use-zoom-for-dsf mode.
Project Member

Comment 9 by bugdroid1@chromium.org, May 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68dcc6407d1af4c37cc6d0452f7ab6b853eb4333

commit 68dcc6407d1af4c37cc6d0452f7ab6b853eb4333
Author: oshima <oshima@chromium.org>
Date: Wed May 11 19:43:59 2016

Apply viewport to dip scale to PepperGraphics2DHost, PepperCompositorHost

* Compositor's layer is set in DIP and has to be scaled to viewport coordinates when use-zoom-for-dsf is on. (viewport_to_dip_scale_ is always 1 when this is off)
*Graphics2D's damage/clip rects should also be scaled accordingly.

BUG= 596697 ,599547, 591881 

Review-Url: https://codereview.chromium.org/1964423003
Cr-Commit-Position: refs/heads/master@{#393031}

[modify] https://crrev.com/68dcc6407d1af4c37cc6d0452f7ab6b853eb4333/content/renderer/pepper/pepper_compositor_host.cc
[modify] https://crrev.com/68dcc6407d1af4c37cc6d0452f7ab6b853eb4333/content/renderer/pepper/pepper_compositor_host.h
[modify] https://crrev.com/68dcc6407d1af4c37cc6d0452f7ab6b853eb4333/content/renderer/pepper/pepper_graphics_2d_host.cc
[modify] https://crrev.com/68dcc6407d1af4c37cc6d0452f7ab6b853eb4333/content/renderer/pepper/pepper_graphics_2d_host.h
[modify] https://crrev.com/68dcc6407d1af4c37cc6d0452f7ab6b853eb4333/content/renderer/pepper/pepper_plugin_instance_impl.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Bulk verified

Sign in to add a comment