New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596690 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 575732



Sign in to add a comment

Implement better timezone detection.

Project Member Reported by alemate@chromium.org, Mar 21 2016

Issue description

We need to implement better timezone detection for those who need it.
 

Comment 1 Deleted

Comment 2 Deleted

I should add that my laptop has been compromised as I wasn't aware of the intrusion of a hopeful data/identity thief who apart from masquerading himself under my identity, also has a remote computer which linked to mine and acquired properties.Something I certainly wasn't prepared for so went a miss! I am not sure as to whether or not I even downloaded drivers which the foreign object accompanied instead of the true/legal receiver! I took note of the properties the remote computer has once I became aware of the copycat culprit and devices for the same purpose! If there may be any means of help through which I am going to spell out,I would be more than grateful?
  Driver instance path - Value:ACP\HPQ6001\2&DABA3FF&0
 Security User ID - "S-1-5-18"
 Event record ID - 103
 Execution process- ID - 936
 Computer DESKTOP- UCM802P
 Device setup manager - Guido = {FCBB06BB-6A2A-46E3-ABBA-246CB4E508B2}/>Event ID> 200
 Thread ID - 5776/> channel > "To be known" Corporate body!
 Realteck PCIE FE family controllerun
 Property- Matching device ID
 Value - PCI\VEN_IOEC&DEV_8136&REV_07
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9af1adea25a1a643a7f849616d3f51b33a9657aa

commit 9af1adea25a1a643a7f849616d3f51b33a9657aa
Author: alemate <alemate@chromium.org>
Date: Wed Mar 23 23:21:44 2016

SimpleGeolocation should support sending WiFi AP data.

BUG= 596690 
TEST=unittest

Review URL: https://codereview.chromium.org/1819173002

Cr-Commit-Position: refs/heads/master@{#382968}

[modify] https://crrev.com/9af1adea25a1a643a7f849616d3f51b33a9657aa/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/9af1adea25a1a643a7f849616d3f51b33a9657aa/chromeos/BUILD.gn
[modify] https://crrev.com/9af1adea25a1a643a7f849616d3f51b33a9657aa/chromeos/chromeos.gyp
[modify] https://crrev.com/9af1adea25a1a643a7f849616d3f51b33a9657aa/chromeos/geolocation/simple_geolocation_provider.cc
[modify] https://crrev.com/9af1adea25a1a643a7f849616d3f51b33a9657aa/chromeos/geolocation/simple_geolocation_provider.h
[modify] https://crrev.com/9af1adea25a1a643a7f849616d3f51b33a9657aa/chromeos/geolocation/simple_geolocation_request.cc
[modify] https://crrev.com/9af1adea25a1a643a7f849616d3f51b33a9657aa/chromeos/geolocation/simple_geolocation_request.h
[add] https://crrev.com/9af1adea25a1a643a7f849616d3f51b33a9657aa/chromeos/geolocation/simple_geolocation_request_test_monitor.cc
[add] https://crrev.com/9af1adea25a1a643a7f849616d3f51b33a9657aa/chromeos/geolocation/simple_geolocation_request_test_monitor.h
[modify] https://crrev.com/9af1adea25a1a643a7f849616d3f51b33a9657aa/chromeos/geolocation/simple_geolocation_unittest.cc
[modify] https://crrev.com/9af1adea25a1a643a7f849616d3f51b33a9657aa/chromeos/network/geolocation_handler.h
[modify] https://crrev.com/9af1adea25a1a643a7f849616d3f51b33a9657aa/chromeos/timezone/timezone_resolver.cc
[modify] https://crrev.com/9af1adea25a1a643a7f849616d3f51b33a9657aa/chromeos/timezone/timezone_resolver.h
[modify] https://crrev.com/9af1adea25a1a643a7f849616d3f51b33a9657aa/tools/metrics/histograms/histograms.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75b7a5c0d16c45d5c96664343f1d77daa63d7212

commit 75b7a5c0d16c45d5c96664343f1d77daa63d7212
Author: alemate <alemate@chromium.org>
Date: Tue Mar 29 06:39:46 2016

ChromeOS: Refactor TimeZoneResolver, add TimeZoneResolverManager.

This CL adds TimeZoneResolverManager as asingle point of TimeZoneResolver
control.

BUG= 596690 
TEST=manual

Review URL: https://codereview.chromium.org/1837893003

Cr-Commit-Position: refs/heads/master@{#383680}

[modify] https://crrev.com/75b7a5c0d16c45d5c96664343f1d77daa63d7212/chrome/browser/browser_process_platform_part_chromeos.cc
[modify] https://crrev.com/75b7a5c0d16c45d5c96664343f1d77daa63d7212/chrome/browser/browser_process_platform_part_chromeos.h
[modify] https://crrev.com/75b7a5c0d16c45d5c96664343f1d77daa63d7212/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
[modify] https://crrev.com/75b7a5c0d16c45d5c96664343f1d77daa63d7212/chrome/browser/chromeos/login/ui/login_display_host_impl.h
[modify] https://crrev.com/75b7a5c0d16c45d5c96664343f1d77daa63d7212/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/75b7a5c0d16c45d5c96664343f1d77daa63d7212/chrome/browser/chromeos/preferences.cc
[add] https://crrev.com/75b7a5c0d16c45d5c96664343f1d77daa63d7212/chrome/browser/chromeos/system/timezone_resolver_manager.cc
[add] https://crrev.com/75b7a5c0d16c45d5c96664343f1d77daa63d7212/chrome/browser/chromeos/system/timezone_resolver_manager.h
[modify] https://crrev.com/75b7a5c0d16c45d5c96664343f1d77daa63d7212/chrome/browser/chromeos/system/timezone_util.cc
[modify] https://crrev.com/75b7a5c0d16c45d5c96664343f1d77daa63d7212/chrome/chrome_browser_chromeos.gypi
[modify] https://crrev.com/75b7a5c0d16c45d5c96664343f1d77daa63d7212/chromeos/timezone/timezone_resolver.cc
[modify] https://crrev.com/75b7a5c0d16c45d5c96664343f1d77daa63d7212/chromeos/timezone/timezone_resolver.h

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc3524a0efece0f2b55b08980b74c23be65ed8dd

commit fc3524a0efece0f2b55b08980b74c23be65ed8dd
Author: alemate <alemate@chromium.org>
Date: Sat Apr 02 01:17:52 2016

ChromeOS: Add SystemTimezoneAutomaticDetection policy.

This CL adds SystemTimezoneAutomaticDetection device policy
and modifies all necessary components to support it.

BUG= 596690 
TEST=unittest,browsertest

Review URL: https://codereview.chromium.org/1843523002

Cr-Commit-Position: refs/heads/master@{#384768}

[modify] https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd/chrome/browser/about_flags.cc
[modify] https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
[modify] https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto
[modify] https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd/chrome/browser/chromeos/system/timezone_resolver_manager.cc
[modify] https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd/chrome/browser/chromeos/system/timezone_resolver_manager.h
[modify] https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd/chrome/browser/resources/options/browser_options.js
[modify] https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd/chrome/browser/ui/webui/options/browser_options_handler.h
[modify] https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd/chrome/common/pref_names.cc
[modify] https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd/chrome/common/pref_names.h
[modify] https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd/chromeos/chromeos_switches.cc
[modify] https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd/chromeos/chromeos_switches.h
[modify] https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd/components/policy/resources/policy_templates.json
[modify] https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Comment 8 by dbeam@chromium.org, Apr 2 2016

note: we're dropping options in the future, it will be replaced by the new Material Design version (called settings).

basically, if you change:
chrome/browser/resources/options
chrome/browser/ui/webui/options

there's likely somewhere in:
chrome/browser/resources/settings
chrome/browser/ui/webui/settings

you have to update (respectively)
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/048b30171ae6db3249101801d814b8f7a4b21c53

commit 048b30171ae6db3249101801d814b8f7a4b21c53
Author: Alexander Alekseev <alemate@chromium.org>
Date: Sat Apr 02 01:53:01 2016

Revert "ChromeOS: Add SystemTimezoneAutomaticDetection policy."

This reverts commit fc3524a0efece0f2b55b08980b74c23be65ed8dd.

Reason for revert: Broke "Closure Compilation Linux" bot.

Original issue's description:
> ChromeOS: Add SystemTimezoneAutomaticDetection policy.
>
> This CL adds SystemTimezoneAutomaticDetection device policy
> and modifies all necessary components to support it.
>
> BUG= 596690 
> TEST=unittest,browsertest
>
> Review URL: https://codereview.chromium.org/1843523002
>
> Cr-Commit-Position: refs/heads/master@{#384768}

TBR=stevenjb@chromium.org,cschuet@chromium.org,bartfab@chromium.org,isherman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 596690 

Review URL: https://codereview.chromium.org/1849133006 .

Cr-Commit-Position: refs/heads/master@{#384783}

[modify] https://crrev.com/048b30171ae6db3249101801d814b8f7a4b21c53/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/048b30171ae6db3249101801d814b8f7a4b21c53/chrome/browser/about_flags.cc
[modify] https://crrev.com/048b30171ae6db3249101801d814b8f7a4b21c53/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
[modify] https://crrev.com/048b30171ae6db3249101801d814b8f7a4b21c53/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto
[modify] https://crrev.com/048b30171ae6db3249101801d814b8f7a4b21c53/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/048b30171ae6db3249101801d814b8f7a4b21c53/chrome/browser/chromeos/system/timezone_resolver_manager.cc
[modify] https://crrev.com/048b30171ae6db3249101801d814b8f7a4b21c53/chrome/browser/chromeos/system/timezone_resolver_manager.h
[modify] https://crrev.com/048b30171ae6db3249101801d814b8f7a4b21c53/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/048b30171ae6db3249101801d814b8f7a4b21c53/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/048b30171ae6db3249101801d814b8f7a4b21c53/chrome/browser/resources/options/browser_options.js
[modify] https://crrev.com/048b30171ae6db3249101801d814b8f7a4b21c53/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/048b30171ae6db3249101801d814b8f7a4b21c53/chrome/browser/ui/webui/options/browser_options_handler.h
[modify] https://crrev.com/048b30171ae6db3249101801d814b8f7a4b21c53/chrome/common/pref_names.cc
[modify] https://crrev.com/048b30171ae6db3249101801d814b8f7a4b21c53/chrome/common/pref_names.h
[modify] https://crrev.com/048b30171ae6db3249101801d814b8f7a4b21c53/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/048b30171ae6db3249101801d814b8f7a4b21c53/chromeos/chromeos_switches.cc
[modify] https://crrev.com/048b30171ae6db3249101801d814b8f7a4b21c53/chromeos/chromeos_switches.h
[modify] https://crrev.com/048b30171ae6db3249101801d814b8f7a4b21c53/components/policy/resources/policy_templates.json
[modify] https://crrev.com/048b30171ae6db3249101801d814b8f7a4b21c53/tools/metrics/histograms/histograms.xml

Status: Started (was: Fixed)
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d70e82f6d166b8f1548e127aaef2114d45a701e3

commit d70e82f6d166b8f1548e127aaef2114d45a701e3
Author: alemate <alemate@chromium.org>
Date: Tue Apr 05 12:21:33 2016

ChromeOS: Add SystemTimezoneAutomaticDetection policy.

This CL adds SystemTimezoneAutomaticDetection device policy
and modifies all necessary components to support it.

BUG= 596690 
TEST=unittest,browsertest

Committed: https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd
Cr-Commit-Position: refs/heads/master@{#384768}

Review URL: https://codereview.chromium.org/1843523002

Cr-Commit-Position: refs/heads/master@{#385157}

[modify] https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3/chrome/browser/about_flags.cc
[modify] https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
[modify] https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto
[modify] https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3/chrome/browser/chromeos/system/timezone_resolver_manager.cc
[modify] https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3/chrome/browser/chromeos/system/timezone_resolver_manager.h
[modify] https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3/chrome/browser/resources/options/browser_options.js
[modify] https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3/chrome/browser/ui/webui/options/browser_options_handler.h
[modify] https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3/chrome/common/pref_names.cc
[modify] https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3/chrome/common/pref_names.h
[modify] https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3/chromeos/chromeos_switches.cc
[modify] https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3/chromeos/chromeos_switches.h
[modify] https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3/components/policy/resources/policy_templates.json
[modify] https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Labels: VerifyIn-51
Cc: trapti@chromium.org
Components: Enterprise
Status: Verified (was: Fixed)
Bulk verified
Verified through YAPS in Peppy Device.

Working in 

M	ChromeOS	Chrome	ARC	Type	Channel
51	8172.43.0	51.0.2704.59	2778284	release	beta

Sign in to add a comment