[MaterialDesign] [Mac] Adding 2px more padding between Chip and Omnibox text |
|||||
Issue descriptionVersion: Version 51.0.2686.0 canary (64-bit) OS: 10.11.3 What steps will reproduce the problem? (1) Please compare the padding between Chip and Omnibox text in the Mock-Up from issue 596594 and in current Canary build. What is the expected output? What do you see instead? In issue 596594 I see that the Omnibox Text in the Mock-Up has approx. 2px more padding. Adjusting it by adding 2px when the security chip and the search chip are visible would be very nice, since the text looks too narrow to the chip at the moment. Please see the attached screenshot. BTW: On Windows there is also a little bit more padding between chip and Omnibox text than actual on Mac. (There is also an open issue ( issue 586423 ) where some adjustments are in work.) Many thanks in advance and kind regards Mehmet
,
Mar 21 2016
,
Mar 21 2016
We do that on views. I think that makes sense. we should be consistent there.
,
Mar 21 2016
OK.
,
Mar 22 2016
Great! Thank you very much :-)
,
Apr 19 2016
,
Apr 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03a74b53c60029b17689f292b828c72df020406a commit 03a74b53c60029b17689f292b828c72df020406a Author: shrike <shrike@chromium.org> Date: Wed Apr 20 19:33:23 2016 [Mac][Material Design] Add space between icon and text in location bar. The spec calls for one additional pt of space between the icon and the text. R=avi@chromium.org BUG= 596684 Review URL: https://codereview.chromium.org/1900873004 Cr-Commit-Position: refs/heads/master@{#388550} [modify] https://crrev.com/03a74b53c60029b17689f292b828c72df020406a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
,
Apr 20 2016
,
Apr 21 2016
Hello shrike@. The padding between Chip (when it has a border) and Omnibox-Text looks fine now. But unfortunately I noticed a side effect: Now, the "single" icons like the lock, magnifying glass and blank-page are no longer horizontally centered :-( Please see the screenshots. Maybe a solution would be to add 1 or 2 px to the left side of the icon? What do you think? Should I open a new report? Thanks, Mehmet
,
Apr 21 2016
It looks like the icon needs 1pt of extra space on the left - I will file a new bug for that.
,
Apr 21 2016
Thanks a lot! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by shrike@chromium.org
, Mar 21 2016Cc: -sgabr...@chromium.org shrike@chromium.org
Labels: -Pri-3 M-51 Pri-2
Owner: sgabr...@chromium.org