New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596674 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2 , 3
Type: Bug-Regression



Sign in to add a comment

Cast Streaming on Mac results in black screen

Project Member Reported by m...@chromium.org, Mar 21 2016

Issue description

Latest Chrome Canary 51.0.2679.0 and cast extension
It happens on Mac Book Air  Early 2013 and Windows 10.

- Cast  a video live TV from CNN.com
- Run for a while 20 mins +

Actual result: It plays fine with first few minutes and video is frozen the rest after. Audio is still heard during the video frozen.
 

Comment 1 by m...@chromium.org, Mar 21 2016

Cc: m...@chromium.org
Labels: OS-Mac
Status: Available (was: Untriaged)
Looks like this Chrome change has broken Cast Streaming Mac: https://chromium.googlesource.com/chromium/src/+/3956fa1cac34dd5682c271d77463accdd7191102

The change enabled the detection of hardware H264 encoders on Mac, and the OFFER/ANSWER messages in the logs confirm the Chrome Sender *is* trying to use H264.

For the short term, we'll commit a patch to revert to the old behavior (i.e., all desktop Macs will use the software VP8 encoder).

For the long term, we should understand why things are broken, as there are [the obvious] reasons to want to use the built-in hardware encoder.  Apple's VideoToolbox library may be broken/unreliable, or broken for the arbitrary resolution changes used by tab mirroring and/or Zero Config resolution changes.  Or, it could be that the Chromecast receiver (and others?) is broken for H264: again, maybe because of the arbitrary resolutions used by tab mirroring, or it is broken when changing resolutions for Zero Config.

Comment 2 Deleted

I have a guess that it might be coming from visible_rect vs. coded_size differences. 

https://code.google.com/p/chromium/codesearch#chromium/src/media/base/mac/video_frame_mac.cc&l=65

Comment 4 by x...@chromium.org, Mar 21 2016

Verified that the revert fixed this problem.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f6bf2ab1d3619432d6d0a5021008d500b7e1c37

commit 5f6bf2ab1d3619432d6d0a5021008d500b7e1c37
Author: miu <miu@chromium.org>
Date: Mon Mar 21 23:20:04 2016

Fix Cast Streaming regression caused by enabling H264 HW encoder on Mac.

A recent commit (3956fa1cac34dd5682c271d77463accdd7191102) turned on
detection and use of the H264 hardware encoder for Mac desktop.  This
caused breakage in the form of a "black screen."  This change reverts to
the prior behavior of always using the software VP8 encoder on Macs.

BUG= 596674 

Review URL: https://codereview.chromium.org/1818203002

Cr-Commit-Position: refs/heads/master@{#382432}

[modify] https://crrev.com/5f6bf2ab1d3619432d6d0a5021008d500b7e1c37/chrome/renderer/media/cast_rtp_stream.cc
[modify] https://crrev.com/5f6bf2ab1d3619432d6d0a5021008d500b7e1c37/chrome/test/data/extensions/api_test/cast_streaming/end_to_end_sender.js

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57ad17882fe82d222ffc20d8d03140c1afa366a8

commit 57ad17882fe82d222ffc20d8d03140c1afa366a8
Author: emircan <emircan@chromium.org>
Date: Tue Mar 29 02:58:20 2016

Allow padding in WrapVideoFrameInCVPixelBuffer

This CL allows visible_rect and coded_size differences in
WrapVideoFrameInCVPixelBuffer.

BUG= 596674 

Review URL: https://codereview.chromium.org/1822103003

Cr-Commit-Position: refs/heads/master@{#383662}

[modify] https://crrev.com/57ad17882fe82d222ffc20d8d03140c1afa366a8/media/base/mac/video_frame_mac.cc
[modify] https://crrev.com/57ad17882fe82d222ffc20d8d03140c1afa366a8/media/base/mac/video_frame_mac_unittests.cc

Components: Internals>Cast

Comment 8 by sko...@chromium.org, Jul 13 2016

Status: Fixed (was: Available)
I think this has been fixed.

Sign in to add a comment