Issue metadata
Sign in to add a comment
|
Keyboard accessibility for WebUSB chooser bubble UI |
||||||||||||||||||||||||
Issue description
OS: Mac
What steps will reproduce the problem?
(1) Use Canary
(2) Turn on the #enable-experimental-web-platform-features flag in chrome://flags
(3) Go to this testing site:
https://webusb.github.io/arduino/demos/rgb/
(4) Click "Connect", a chooser bubble should appear.
(5) Trying to only interact with the bubble with the keyboard, there are no focus styles.
What is the expected output? What do you see instead?
Should be able to press tab to navigate to buttons, and see a visible focus state.
I think other UI may also have similar behaviors, for example:
1. geolocation permission bubble
Try:
http://html5demos.com/geo
And a geolocation permission bubble pops up, and using tab can't navigate to buttons.
2. website settings bubble
Try clicking the lock symbol before the url string at the Omnibox, it will pop up a website settings bubble, and using tab can't navigate to controls.
,
Mar 25 2016
,
Mar 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f0ead0fd04825415795733a60d1cf587fd12b2a commit 9f0ead0fd04825415795733a60d1cf587fd12b2a Author: juncai <juncai@chromium.org> Date: Fri Mar 25 21:38:11 2016 Add keyboard accessibility to ConstrainedWindowButton This patch added keyboard accessibility to ConstrainedWindowButton. ConstrainedWindowButton is used by WebUSB chooser bubble, Geolocation permission bubble, etc. Previously, when trying to only interact with these bubbles with the keyboard, there are no focus styles. User should be able to press tab to navigate to buttons, and see a visible focus state. It will allow the user to only use keyboard to control the bubble, which improves the accessibility of the UI that uses it. BUG= 596671 Review URL: https://codereview.chromium.org/1829393002 Cr-Commit-Position: refs/heads/master@{#383368} [modify] https://crrev.com/9f0ead0fd04825415795733a60d1cf587fd12b2a/chrome/browser/ui/cocoa/constrained_window/constrained_window_button.mm [modify] https://crrev.com/9f0ead0fd04825415795733a60d1cf587fd12b2a/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
,
Mar 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9011b1f0bf8dbf920a95bc32f9ba7c01f0d6c28f commit 9011b1f0bf8dbf920a95bc32f9ba7c01f0d6c28f Author: juncai <juncai@chromium.org> Date: Mon Mar 28 18:21:56 2016 Revert of Add keyboard accessibility to ConstrainedWindowButton (patchset #2 id:20001 of https://codereview.chromium.org/1829393002/ ) Reason for revert: There is a setting on Mac that can control the keyboard access: System Preferences -> Keyboard -> Shortcuts At the bottom, it has: "Full Keyboard Access: In windows and dialogs, press Tab to move keyboard focus between: Text boxes and lists only All controls" When setting to "All controls", without the change in this patch, pressing the tab can navigate the buttons and space works like pressing the button. So this patch is not needed. Original issue's description: > Add keyboard accessibility to ConstrainedWindowButton > > This patch added keyboard accessibility to ConstrainedWindowButton. > > ConstrainedWindowButton is used by WebUSB chooser bubble, > Geolocation permission bubble, etc. Previously, when trying to only > interact with these bubbles with the keyboard, there are no focus > styles. User should be able to press tab to navigate to buttons, and > see a visible focus state. It will allow the user to only use keyboard > to control the bubble, which improves the accessibility of the UI > that uses it. > > BUG= 596671 > > Committed: https://crrev.com/9f0ead0fd04825415795733a60d1cf587fd12b2a > Cr-Commit-Position: refs/heads/master@{#383368} TBR=rsesek@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 596671 Review URL: https://codereview.chromium.org/1837803002 Cr-Commit-Position: refs/heads/master@{#383523} [modify] https://crrev.com/9011b1f0bf8dbf920a95bc32f9ba7c01f0d6c28f/chrome/browser/ui/cocoa/constrained_window/constrained_window_button.mm [modify] https://crrev.com/9011b1f0bf8dbf920a95bc32f9ba7c01f0d6c28f/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
,
Apr 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4788666880388f82f62affc3499678f18b39b246 commit 4788666880388f82f62affc3499678f18b39b246 Author: juncai <juncai@chromium.org> Date: Mon Apr 04 19:17:18 2016 Add keyboard accessibility to "Get help" link text on chooser UI The "Get help" link text was a HyperlinkTextView before, and pressing the Tab doesn't navigate to it. This patch modified it using HyperlinkButtonCell so that pressing the Tab can navigate to it. This patch doesn't change the UI of the "Get help" link text. It looks the same as before when using HyperlinkTextView. BUG= 596671 , 583479 Review URL: https://codereview.chromium.org/1835133002 Cr-Commit-Position: refs/heads/master@{#384972} [modify] https://crrev.com/4788666880388f82f62affc3499678f18b39b246/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
,
Apr 15 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lpalmaro@chromium.org
, Mar 21 2016Components: UI>Accessibility
Labels: -Pri-3 Pri-2