New issue
Advanced search Search tips

Issue 596653 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 597789



Sign in to add a comment

Prevent resize of blimp view on showing IME

Project Member Reported by shaktisahu@chromium.org, Mar 21 2016

Issue description

Currently during text input, blimp view resizes to make room for the floating web input box. Find a better way to prevent that.

 

Comment 1 by amin...@google.com, Mar 24 2016

Blocking: 597789
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68de803474c115c96b034175b7e6f4db7bc25dff

commit 68de803474c115c96b034175b7e6f4db7bc25dff
Author: shaktisahu <shaktisahu@chromium.org>
Date: Thu Mar 24 23:05:13 2016

Resize of blimpview on text input

This is a temporary fix to prevent resize of blimp view and at the same time be able to show the WebInputBox right above IME to enable the user to see what they type. Without resize, WebInputBox hides under IME. Current fix is to resize the view only when text input is required and resize it back after hiding IME.

BUG= 596653 

Review URL: https://codereview.chromium.org/1824813002

Cr-Commit-Position: refs/heads/master@{#383178}

[modify] https://crrev.com/68de803474c115c96b034175b7e6f4db7bc25dff/blimp/client/app/android/java/src/org/chromium/blimp/input/WebInputBox.java

Comment 3 by klo...@chromium.org, Mar 28 2016

Cc: klo...@chromium.org
Status: Assigned (was: Untriaged)
Is this fixed?
No. The commit refers to the temporary fix. 
However, this shouldn't be a blocker any more.

There is also another issue filed by Haibin
https://bugs.chromium.org/p/chromium/issues/detail?id=598053

Probably one of them can be closed as duplicate.


Comment 5 by klo...@chromium.org, Mar 28 2016

How about we close this and you follow the rest in the other bug?
Sure. Thanks.
Status: Fixed (was: Assigned)
Labels: Archive-Blimp

Sign in to add a comment