New issue
Advanced search Search tips

Issue 596650 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 604823

Blocking:
issue 539572



Sign in to add a comment

UBSan build for Libfuzzer

Project Member Reported by aizatsky@chromium.org, Mar 21 2016

Issue description

A new build configuration should be created and new build on a bot defined.
 

Comment 1 by mmoroz@google.com, Mar 24 2016

FYI, we think that it would be better to have new build-bot for UBSan builds, because we already spend about ~2h for ASan and ~2h for MSan on one buildbot: https://build.chromium.org/p/chromium.fyi/buildslaves/slave43-c1

Also I can take this task if you are busy.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/04f6108c8cad0de19d87d564a470100e275df265

commit 04f6108c8cad0de19d87d564a470100e275df265
Author: aizatsky@chromium.org <aizatsky@chromium.org>
Date: Sat Mar 26 00:08:13 2016

[libfuzzer] registering ubsan build.

BUG= 596650 ,598097

Review URL: https://codereview.chromium.org/1836713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299499 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/04f6108c8cad0de19d87d564a470100e275df265/masters/master.chromium.fyi/master.cfg
[modify] https://crrev.com/04f6108c8cad0de19d87d564a470100e275df265/masters/master.chromium.fyi/slaves.cfg

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e61554d35d887153220d0ac711c6e77e0f3878c2

commit e61554d35d887153220d0ac711c6e77e0f3878c2
Author: aizatsky <aizatsky@chromium.org>
Date: Mon Mar 28 23:57:21 2016

[libfuzzer] disable nacl in all libfuzzer builds

BUG= 596650 

Review URL: https://codereview.chromium.org/1834223003

Cr-Commit-Position: refs/heads/master@{#383616}

[modify] https://crrev.com/e61554d35d887153220d0ac711c6e77e0f3878c2/tools/mb/mb_config.pyl

Owner: mmoroz@chromium.org
Max, the bot is up and running, the build is green. Please add it to CF.

Comment 8 by mmoroz@chromium.org, Mar 30 2016

Awesome! Thanks!

Comment 9 by mmoroz@chromium.org, Mar 31 2016

I set up ubsan job to be running at 10 bots. Will check logs and then expand the job to 100-200 bots.
Example: https://paste.googleplex.com/5480163756212224
We do not crash when UBSan detects anything right now, correct?

Cc: mbarbe...@chromium.org
For first 642 runs we've got about 3769 UBSan alerts. I think I should enable crashing by default and should not increase number of bots significantly just to avoid too many crashes.
Enabled halt_on_error=1, still 10 bots running, let's see.
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 4 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=86097

------------------------------------------------------------------
r86097 | mmoroz@google.com | 2016-04-04T16:18:29.513526Z

-----------------------------------------------------------------
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=86252

------------------------------------------------------------------
r86252 | mmoroz@google.com | 2016-04-07T10:32:54.162790Z

-----------------------------------------------------------------
Status: Fixed (was: Assigned)
Thanks everyone for taking part in this. First bugs are filed:

https://bugs.chromium.org/p/chromium/issues/list?can=2&q=stability%3DUndefinedBehaviorSanitizer&colspec=ID+Pri+M+Stars+ReleaseBlock+Component+Status+Owner+Summary+OS+Modified&x=m&y=releaseblock&cells=ids

I'm increasing number of bots to 100.
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c5c82d091b1dae3b03961a7048b0e7f6249abcd

commit 0c5c82d091b1dae3b03961a7048b0e7f6249abcd
Author: aizatsky <aizatsky@chromium.org>
Date: Mon Apr 18 22:34:43 2016

[libfuzzer] adding ubsan to the list of supported configurations.

BUG= 596650 

Review URL: https://codereview.chromium.org/1899933002

Cr-Commit-Position: refs/heads/master@{#388057}

[modify] https://crrev.com/0c5c82d091b1dae3b03961a7048b0e7f6249abcd/testing/libfuzzer/getting_started.md

Blockedon: 604823

Sign in to add a comment