New issue
Advanced search Search tips

Issue 596649 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WebAudio with DEBUG_AUDIONODE_REFERENCES doesn't compile

Project Member Reported by rtoy@chromium.org, Mar 21 2016

Issue description

In a recent change to move from Blink style to Chromium style, nodeType() was renamed to getNodeType().  But DEBUG_AUDIONODE_REFERENCES code wasn't updated so the build doesn't work anymore.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/139db7daa31f10c5d136d058ef1995868c7d25dd

commit 139db7daa31f10c5d136d058ef1995868c7d25dd
Author: rtoy <rtoy@chromium.org>
Date: Mon Mar 21 22:14:41 2016

Fix compile errors when DEBUG_AUDIONODE_REFERENCES is set.

BUG= 596649 
TEST=Change DEBUG_AUDIONODE_REFERENCES to 1 in AudioNode.h and compile

Review URL: https://codereview.chromium.org/1816283002

Cr-Commit-Position: refs/heads/master@{#382414}

[modify] https://crrev.com/139db7daa31f10c5d136d058ef1995868c7d25dd/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp

Comment 2 by rtoy@chromium.org, Mar 21 2016

Status: Fixed (was: Started)

Sign in to add a comment