No longer, or never was? :)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9edddb9ded49023460a204675ee4e9bb763b9da7

commit 9edddb9ded49023460a204675ee4e9bb763b9da7
Author: watk <watk@chromium.org>
Date: Mon Mar 21 22:21:10 2016

media: Stop flushing the renderer for pipeline suspend

Previously when performing a pipeline suspend we would flush the
renderer before destructing it. This CL removes the flush because
it's no longer necessary and has issues:
1) it adds ~100-150ms to suspend on a Galaxy Nexus (which makes
   a difference for fullscreen transitions), and
2) on <API level 18 devices it will cause AVDA to go into an
   error state when it handles the flush by creating a new
   MediaCodec without a valid output surface.

BUG= 596641 , 595545 
TEST=media_unittests

Review URL: https://codereview.chromium.org/1815423002

Cr-Commit-Position: refs/heads/master@{#382417}

[modify] https://crrev.com/9edddb9ded49023460a204675ee4e9bb763b9da7/media/base/pipeline_impl.cc
[modify] https://crrev.com/9edddb9ded49023460a204675ee4e9bb763b9da7/media/base/pipeline_impl_unittest.cc

Sadly it turns out the flush was doing something useful after all :) The renderer will wait for outstanding reads to complete before the flush is complete. So without Flush the demuxer may be reading when we suspend.

Perhaps we can investigate cancelling pending reads.

DataSource::Abort() will cancel outstanding reads, but currently is a one-time thing, i.e. once set there's no going back. It's also not specified what an aborted read does to the demuxer. I think Abort() is the right thing to do and will also help us w/ seeking on delayed reads. I.e. we can abort the read when about to seek or suspend. It's something we've long wanted, but haven't gotten around to.

That's a bit of a larger change though. I think it's doable for M51, but might be a bit hairy for M50. We might just want to blacklist API level 16,17 for M50 then if we can't find a simple solution.

Fixed by 165762, yay!