New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596636 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Upgrade to Chrome 49.0.2623.8 breaks shorcuts.

Reported by carpenti...@gmail.com, Mar 21 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2486.0 Safari/537.36 Edge/13.10586

Steps to reproduce the problem:
1. Install an older chrome enterprise version on your machine
2. Open this chrome and browse to a website.
3. Install the 49.x version while the browser is open.
4. you will see that your shortcuts are broken and there is no chrome.Exe anymore only a new_chrome.Exe

What is the expected behavior?
The shortcuts keep working. and there must always be a chrome.Exe file.

What went wrong?
there is after the uprgade no chrome.exe only a new_chrome.Exe

Did this work before? Yes In version 48.0.2564.109

Chrome version: 49.0.2623.87  Channel: stable
OS Version: XP SP3
Flash Version: 

I can't reproduce the problem on windows 7 sp1
 
in attachment the debug log.
debug.log
2.0 KB View Download
a picture of the folder
Capture.PNG
29.6 KB View Download

Comment 3 by grt@chromium.org, Apr 4 2016

Hi. Could you attach C:\Windows\Temp\chrome_installer.log?
here you go
chrome_installer.log
9.5 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1fe3afddbb41f46ef57e226f6f8ae1855dd9dfc

commit e1fe3afddbb41f46ef57e226f6f8ae1855dd9dfc
Author: grt <grt@chromium.org>
Date: Tue Apr 05 22:05:23 2016

Always delete old_chrome.exe last in the rename dance since it cannot be rolled back.

BUG= 596636 
R=fdoray@chromium.org

Review URL: https://codereview.chromium.org/1864663002

Cr-Commit-Position: refs/heads/master@{#385294}

[modify] https://crrev.com/e1fe3afddbb41f46ef57e226f6f8ae1855dd9dfc/chrome/installer/setup/setup_main.cc

Comment 6 by grt@chromium.org, Apr 6 2016

Cc: fdoray@chromium.org tinazh@chromium.org
Labels: Merge-Request-50 M-50
Owner: grt@chromium.org
Status: Fixed (was: Unconfirmed)
r385294 should improve things. In the meantime, re-installing Chrome should repair broken installs.

Comment 7 by tin...@google.com, Apr 6 2016

Labels: -Merge-Request-50 Merge-Approved-50
Merge approved for M50 (branch 2661). Pls go ahead merge.
Please merge your change to M50 branch 2661 by 5:00 PM PST on April 8th,Friday to make into the desktop Stable final build cut. Thank you.

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 7 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08b5f1efaecb99db99b2ee8b3ad9cf76c67c2f46

commit 08b5f1efaecb99db99b2ee8b3ad9cf76c67c2f46
Author: Greg Thompson <grt@chromium.org>
Date: Thu Apr 07 00:43:29 2016

Always delete old_chrome.exe last in the rename dance since it cannot be rolled back.

BUG= 596636 
R=fdoray@chromium.org

Review URL: https://codereview.chromium.org/1864663002

Cr-Commit-Position: refs/heads/master@{#385294}
(cherry picked from commit e1fe3afddbb41f46ef57e226f6f8ae1855dd9dfc)
TBR=grt@chromium.org

Review URL: https://codereview.chromium.org/1869443003 .

Cr-Commit-Position: refs/branch-heads/2661@{#505}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/08b5f1efaecb99db99b2ee8b3ad9cf76c67c2f46/chrome/installer/setup/setup_main.cc

Just to update, Windows XP no longer supports M50 version of Chrome. hence unable to verify this CL on Windows XP.

Comment 11 by grt@chromium.org, Apr 21 2016

Labels: Needs-Feedback
OP: Has Chrome 50 resolved this issue for you? If not, are you able to reproduce this problem at-will (i.e., start with a machine where Chrome works, update it to Chrome 50, and observe that chrome.exe disappears)? Thank you.

Sign in to add a comment