New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 596628 link

Starred by 1 user
Status: Fixed
Owner:
█ jialiul@chromium.org
Last visit > 30 days ago
Closed: Mar 2016
Cc:
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Need to move TestSafeBrowsingService* to anonymous namespace

Project Member Reported by jialiul@chromium.org, Mar 21 2016 
Trouble caused by https://codereview.chromium.org/1784433003.
In chrome/browser/download/download_browsertest.cc file, TestSafeBrowsingService* classes are not defined in anonymous namespace. This causes ODR troubles in practice https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/4650/steps/compile/logs/stdio
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd3dbdb8139de35b3e38deb20a3e83406d5b8814

commit bd3dbdb8139de35b3e38deb20a3e83406d5b8814
Author: jialiul <jialiul@chromium.org>
Date: Mon Mar 21 20:47:35 2016

Move TestSafeBrowsingService* to anonymous namespace

BUG= 596628 

Review URL: https://codereview.chromium.org/1818133002

Cr-Commit-Position: refs/heads/master@{#382381}

[modify] https://crrev.com/bd3dbdb8139de35b3e38deb20a3e83406d5b8814/chrome/browser/download/download_browsertest.cc

Comment 2 by jialiul@chromium.org, Mar 21 2016

Labels: Merge-Request-50

Comment 3 by tin...@google.com, Mar 22 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 22 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1935a089617df084c428a3bb79da28fbed6cca3

commit b1935a089617df084c428a3bb79da28fbed6cca3
Author: Jialiu Lin <jialiul@chromium.org>
Date: Tue Mar 22 22:45:32 2016

Move TestSafeBrowsingService* to anonymous namespace

BUG= 596628 

Review URL: https://codereview.chromium.org/1818133002

Cr-Commit-Position: refs/heads/master@{#382381}
(cherry picked from commit bd3dbdb8139de35b3e38deb20a3e83406d5b8814)

Review URL: https://codereview.chromium.org/1828553002 .

Cr-Commit-Position: refs/branch-heads/2661@{#348}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/b1935a089617df084c428a3bb79da28fbed6cca3/chrome/browser/download/download_browsertest.cc

Comment 5 by jialiul@chromium.org, Mar 22 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment