Yusuf, this looks like a themes issue, but only in webview. Know anything changed in the select pop up here in m50?

Not that I know of ... Theme related changes for tab reparenting all landed before 49. So nothing specific to 50.

m49 is fine. Can QA do a bisect?

Hi,  thanks for looking at this.  Just to be extra clear : i haven't tested
m49 only m50 and my factory version which is  43 I think.

Also the background color isn't totaly black, but slightly transparent.

Hope that helps somewhat.

Regards Peter Molyneux

Bisected to between 2630 and 2631. Full changelog here:
https://chromium.googlesource.com/chromium/src/+log/50.0.2630.0..50.0.2631.0?pretty=fuller&n=10000

Two changes that touches pop up things, both from newt:
https://codereview.chromium.org/1622773002
https://codereview.chromium.org/1616043004

molyneux: Could you attach a screenshot of the problem?

Does the dialog itself have a black background (e.g. behind each item in the list: "0 minutes", "1 minutes", etc)?

The date and time pickers look fine fwiw (looks like super old UI from jellybean time or something)

It's the <select> pop up that doesn't look right. Screenshots attached

Deleted: good.png 182 KB

	good.png 182 KB View Download

Deleted: bad.png 173 KB

	bad.png 173 KB View Download

Looks like an issue with the theme, which might be related to using the wrong context (e.g. an application context instead of activity context).

Here's a test page with a <select> element and various other input types (date, time, etc): http://jsfiddle.net/qg4h2bhw/4/embedded/result/

In Chrome, and in some webview apps (e.g. android_webview_apk), all the various input dialogs are nicely themed (with a dark gray background, white text, and green buttons). In another webview app, where I was was able to reproduce the bug (as in #7), all the dialogs were themed using ancient Holo-looking widgets and the black-text-on-black-background bug was present for the <select> element.

Screenshots comparing the "good" theming with the "bad" theming.

Deleted: webview_nicely_themed.png 164 KB

	webview_nicely_themed.png 164 KB View Download

Deleted: webview_badly_themed.png 185 KB

	webview_badly_themed.png 185 KB View Download

More investigation: this bug happens when the WebView is using one of the pre-Holo themes (ugh...), such as android:Theme.Light or android:Theme.Black.

Fix uploaded: https://codereview.chromium.org/1826573002

Screenshot with the fix attached (compare to "bad.png" in #7).

Deleted: fixed.png 142 KB

	fixed.png 142 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58873c3c518c096f1717ed5683963ae989e83ef8

commit 58873c3c518c096f1717ed5683963ae989e83ef8
Author: newt <newt@chromium.org>
Date: Tue Mar 22 22:26:37 2016

Fix black text on black background in <select> dialog.

This happened when a <select> HTML element was used in WebView, and the
activity containing the WebView had a pre-Holo theme (e.g.
android:Theme.Black).

BUG= 596626 

Review URL: https://codereview.chromium.org/1826573002

Cr-Commit-Position: refs/heads/master@{#382711}

[modify] https://crrev.com/58873c3c518c096f1717ed5683963ae989e83ef8/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java

Your change meets the bar and is auto-approved for M50 (branch: 2661)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91765a3bc8ea02e419ea44897ceae4cc942d1875

commit 91765a3bc8ea02e419ea44897ceae4cc942d1875
Author: Newton Allen <newt@google.com>
Date: Tue Mar 22 23:50:27 2016

Fix black text on black background in <select> dialog.

This happened when a <select> HTML element was used in WebView, and the
activity containing the WebView had a pre-Holo theme (e.g.
android:Theme.Black).

BUG= 596626 

Review URL: https://codereview.chromium.org/1826573002

Cr-Commit-Position: refs/heads/master@{#382711}
(cherry picked from commit 58873c3c518c096f1717ed5683963ae989e83ef8)

Review URL: https://codereview.chromium.org/1824233002 .

Cr-Commit-Position: refs/branch-heads/2661@{#351}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/91765a3bc8ea02e419ea44897ceae4cc942d1875/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java

molyneux: whatever app you are testing this on is using a super old theme, probably want to look into that

Thanks,  you've done a great job. I'll change the theme,  just standard
visual Studio cordova project.  Had no idea what theme it was using.

Thanks for reporting with clear repro steps :)

Verified issue mentioned in comment #7 good.png is observed with the fixes on the latest web view build M50 on Sony Xperia Z3(5.0.2) and other few devices.
Btw we are still observing the webview_badly_themed.png with the test page mentioned in comment #8 : http://jsfiddle.net/qg4h2bhw/4/embedded/result/

webview_badly_themed.png is OK. It's not pretty, but it's not broken either -- it's just an old theme.

As long as you're no longer seeing bad.png from #7 (black text on a black background), then this bug is fixed.

Thanks for verifying!

Tested.
The new version works fine.