Chip design needs some tweaks |
|||
Issue descriptionThe current green lock chip in canary needs some size adjustments. I attached a comparison. Top is the expected design, bottom is current. List of changes: - Rounded corners need to be 2pt - Text needs to be 11pt - Height needs to be 18pt - Chip fill color should be #2E8732 5%
,
Apr 20 2016
,
Apr 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41af3ca181bd1abeda8ef5264a646da9d58e6821 commit 41af3ca181bd1abeda8ef5264a646da9d58e6821 Author: shrike <shrike@chromium.org> Date: Wed Apr 27 17:46:42 2016 [Mac][Material Design] Adjust EV chip to match Material Design spec. Tweak the EV chip to match the spec, per sgabriel@. R=avi@chromium.org BUG= 596594 Review-Url: https://codereview.chromium.org/1909453004 Cr-Commit-Position: refs/heads/master@{#390116} [modify] https://crrev.com/41af3ca181bd1abeda8ef5264a646da9d58e6821/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h [modify] https://crrev.com/41af3ca181bd1abeda8ef5264a646da9d58e6821/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm [modify] https://crrev.com/41af3ca181bd1abeda8ef5264a646da9d58e6821/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.h [modify] https://crrev.com/41af3ca181bd1abeda8ef5264a646da9d58e6821/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm [modify] https://crrev.com/41af3ca181bd1abeda8ef5264a646da9d58e6821/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm [modify] https://crrev.com/41af3ca181bd1abeda8ef5264a646da9d58e6821/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h [modify] https://crrev.com/41af3ca181bd1abeda8ef5264a646da9d58e6821/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
,
Apr 27 2016
,
Apr 28 2016
Hi shrike@: I noticed two things after the change. 1.) The lock icon is very small and blurry now on Non-Retina. (Not sure, how it looks on retina with the change.) In the mockup in comment 0, the lock icon is not smaller after the tweaks. 2.) In the mockup there are also 2px more padding between Omnibox border and the left side of the chip. With the +2px more padding it would match the padding above and under the chip. Enclosed are two screenshots (actual vs expected). What do you think? Thanks. Mehmet
,
Apr 28 2016
I filed Issue 607586 on the 2pt of padding. Re: the lock, it's true that the lock size did not change in the screenshot in #1, the size of lock is 9pt, which is smaller than it was before.
,
Apr 28 2016
Okay, thanks for your feedback and filing the report. |
|||
►
Sign in to add a comment |
|||
Comment 1 by shrike@chromium.org
, Mar 22 2016