New issue
Advanced search Search tips

Issue 596573 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 596523



Sign in to add a comment

AddKDESetting() in proxy/proxy_config_service_linux.cc does not check return value from base::StringToInt()

Project Member Reported by eroman@chromium.org, Mar 21 2016

Issue description

This looks like it could lead to use of an uninitialized value...
 

Comment 1 by eroman@chromium.org, Mar 21 2016

Actually StringToInt() may be setting to 0 on failure, need to verify.

Comment 2 by eroman@chromium.org, Mar 21 2016

Components: Internals>Network>Proxy

Comment 3 by eroman@chromium.org, Mar 23 2016

Owner: eroman@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e44498c3ea4925a4868cad26fcee8fb91cd139cd

commit e44498c3ea4925a4868cad26fcee8fb91cd139cd
Author: eroman <eroman@chromium.org>
Date: Fri Jun 30 00:02:37 2017

Check the return value of base::StringToInt() in
ProxyConfigServiceLinux.

The code was assuming it would set the result to 0 on failure, however
this is not part of the API contract (the actual contract is weirder).

This wouldn't have caused any real bugs, other than some
different interpretations of invalid KDE proxy configurations.

The CL changes some of those edge cases in arbitrary ways (i.e. overflowed integer is now 0 rather than max_int).

BUG= 596573 

Review-Url: https://codereview.chromium.org/2968573002
Cr-Commit-Position: refs/heads/master@{#483553}

[modify] https://crrev.com/e44498c3ea4925a4868cad26fcee8fb91cd139cd/net/proxy/proxy_config_service_linux.cc
[modify] https://crrev.com/e44498c3ea4925a4868cad26fcee8fb91cd139cd/net/proxy/proxy_config_service_linux_unittest.cc

Comment 5 by eroman@chromium.org, Jun 30 2017

Status: Fixed (was: Assigned)

Sign in to add a comment