ProxyBypassRules::AddRuleFromStringInternal() accepts invalid port numbers (have leading +) |
||||
Issue descriptionBy virtue of using base::StringToInt()
,
Mar 21 2016
,
Mar 23 2016
,
Mar 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55fa65c5ce1c15d8a492d6876b2324fd576a83a4 commit 55fa65c5ce1c15d8a492d6876b2324fd576a83a4 Author: eroman <eroman@chromium.org> Date: Thu Mar 24 18:57:49 2016 Don't allow a leading plus in ports for proxy bypass rules. For instance will reject the rule "*.org:+443" whereas before it would be accepted. BUG=596523, 596570 Review URL: https://codereview.chromium.org/1831653002 Cr-Commit-Position: refs/heads/master@{#383111} [modify] https://crrev.com/55fa65c5ce1c15d8a492d6876b2324fd576a83a4/net/proxy/proxy_bypass_rules.cc [modify] https://crrev.com/55fa65c5ce1c15d8a492d6876b2324fd576a83a4/net/proxy/proxy_bypass_rules_unittest.cc
,
Mar 24 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by eroman@chromium.org
, Mar 21 2016