New issue
Advanced search Search tips

Issue 596565 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 596523



Sign in to add a comment

port/protocol parsing in HttpStreamFactory::ProcessAlternateProtocol() recognizes invalid ports (with leading plus)

Project Member Reported by eroman@chromium.org, Mar 21 2016

Issue description

By virtue of using base::StringToInt() and not checking for a leading plus.
 
Status: Available (was: Untriaged)

Comment 2 by eroman@chromium.org, Mar 25 2016

Owner: eroman@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad87cd92bcc00ac09aa89a2967e51b82af4da9fb

commit ad87cd92bcc00ac09aa89a2967e51b82af4da9fb
Author: eroman <eroman@chromium.org>
Date: Fri Apr 15 18:58:58 2016

Reject port numbers that contain a leading '+' in HttpStreamFactory::ProcessAlternateProtocol().

BUG= 596565 

Review URL: https://codereview.chromium.org/1893433003

Cr-Commit-Position: refs/heads/master@{#387663}

[modify] https://crrev.com/ad87cd92bcc00ac09aa89a2967e51b82af4da9fb/net/http/http_stream_factory.cc

Comment 4 by eroman@chromium.org, Apr 15 2016

Status: Fixed (was: Assigned)

Sign in to add a comment