New issue
Advanced search Search tips

Issue 596549 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Surfaceless Surfaces for mus

Project Member Reported by rjkroege@chromium.org, Mar 21 2016

Issue description

To run on device, mus needs a surfaceless surface implementation, buffer queues, etc.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/224cf40b93b5bde158e61610e8fd233ab5f776ca

commit 224cf40b93b5bde158e61610e8fd233ab5f776ca
Author: rjkroege <rjkroege@chromium.org>
Date: Sat Apr 02 00:47:01 2016

Plumb GpuSwapBuffers completion from Mus GPU thread to WS thread

Add the necessary code to plumb the SwapBuffersAsync completion indication from
Mus GPU thread back to the invoking WS thread.

BUG= 596549 

Review URL: https://codereview.chromium.org/1854953002

Cr-Commit-Position: refs/heads/master@{#384760}

[modify] https://crrev.com/224cf40b93b5bde158e61610e8fd233ab5f776ca/components/mus/gles2/BUILD.gn
[modify] https://crrev.com/224cf40b93b5bde158e61610e8fd233ab5f776ca/components/mus/gles2/command_buffer_driver.cc
[modify] https://crrev.com/224cf40b93b5bde158e61610e8fd233ab5f776ca/components/mus/gles2/command_buffer_driver.h
[modify] https://crrev.com/224cf40b93b5bde158e61610e8fd233ab5f776ca/components/mus/gles2/command_buffer_impl.cc
[modify] https://crrev.com/224cf40b93b5bde158e61610e8fd233ab5f776ca/components/mus/gles2/command_buffer_impl.h
[modify] https://crrev.com/224cf40b93b5bde158e61610e8fd233ab5f776ca/components/mus/gles2/command_buffer_local.cc
[modify] https://crrev.com/224cf40b93b5bde158e61610e8fd233ab5f776ca/components/mus/gles2/command_buffer_local.h
[modify] https://crrev.com/224cf40b93b5bde158e61610e8fd233ab5f776ca/components/mus/gles2/command_buffer_local_client.h
[add] https://crrev.com/224cf40b93b5bde158e61610e8fd233ab5f776ca/components/mus/gles2/gl_surface_adapter.cc
[add] https://crrev.com/224cf40b93b5bde158e61610e8fd233ab5f776ca/components/mus/gles2/gl_surface_adapter.h
[modify] https://crrev.com/224cf40b93b5bde158e61610e8fd233ab5f776ca/components/mus/surfaces/surfaces_context_provider.cc
[modify] https://crrev.com/224cf40b93b5bde158e61610e8fd233ab5f776ca/components/mus/surfaces/surfaces_context_provider.h
[modify] https://crrev.com/224cf40b93b5bde158e61610e8fd233ab5f776ca/components/mus/surfaces/top_level_display_client.h

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/535fbdccc37f44292266fb16a2e21980b3ef1ce3

commit 535fbdccc37f44292266fb16a2e21980b3ef1ce3
Author: rjkroege <rjkroege@chromium.org>
Date: Wed Apr 06 18:57:44 2016

Mus version of GLHelper

Pending the completion of the ongoing componentization of the GPU code, add a
version of content's GLHelper customized to Mus.

BUG= 596549 

Review URL: https://codereview.chromium.org/1848033006

Cr-Commit-Position: refs/heads/master@{#385516}

[modify] https://crrev.com/535fbdccc37f44292266fb16a2e21980b3ef1ce3/components/mus/gles2/BUILD.gn
[add] https://crrev.com/535fbdccc37f44292266fb16a2e21980b3ef1ce3/components/mus/gles2/gl_helper.cc
[add] https://crrev.com/535fbdccc37f44292266fb16a2e21980b3ef1ce3/components/mus/gles2/gl_helper.h

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f70fe98e9f2c0dbdeabe5c297f1d930347e87b40

commit f70fe98e9f2c0dbdeabe5c297f1d930347e87b40
Author: rjkroege <rjkroege@chromium.org>
Date: Fri Apr 08 19:51:27 2016

Scan-out capable buffers (aka ui::NativePixmap) for Mus

To run on a ChromeBook, Mus needs to support allocation of buffers
that can be used for scanout. This patch extends Mus's GPU
infrastructure to allocate scannable images.

BUG= 596549 

Review URL: https://codereview.chromium.org/1857243005

Cr-Commit-Position: refs/heads/master@{#386164}

[modify] https://crrev.com/f70fe98e9f2c0dbdeabe5c297f1d930347e87b40/components/mus/gles2/BUILD.gn
[modify] https://crrev.com/f70fe98e9f2c0dbdeabe5c297f1d930347e87b40/components/mus/gles2/command_buffer_driver.cc
[modify] https://crrev.com/f70fe98e9f2c0dbdeabe5c297f1d930347e87b40/components/mus/gles2/command_buffer_driver.h
[modify] https://crrev.com/f70fe98e9f2c0dbdeabe5c297f1d930347e87b40/components/mus/gles2/command_buffer_local.cc
[modify] https://crrev.com/f70fe98e9f2c0dbdeabe5c297f1d930347e87b40/components/mus/gles2/command_buffer_local.h
[add] https://crrev.com/f70fe98e9f2c0dbdeabe5c297f1d930347e87b40/components/mus/gles2/gpu_memory_buffer_impl.cc
[add] https://crrev.com/f70fe98e9f2c0dbdeabe5c297f1d930347e87b40/components/mus/gles2/gpu_memory_buffer_impl.h
[modify] https://crrev.com/f70fe98e9f2c0dbdeabe5c297f1d930347e87b40/components/mus/gles2/mojo_gpu_memory_buffer.cc
[modify] https://crrev.com/f70fe98e9f2c0dbdeabe5c297f1d930347e87b40/components/mus/gles2/mojo_gpu_memory_buffer.h
[add] https://crrev.com/f70fe98e9f2c0dbdeabe5c297f1d930347e87b40/components/mus/gles2/ozone_gpu_memory_buffer.cc
[add] https://crrev.com/f70fe98e9f2c0dbdeabe5c297f1d930347e87b40/components/mus/gles2/ozone_gpu_memory_buffer.h

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d068106509793cf3f90916076548faced1fc5e8

commit 4d068106509793cf3f90916076548faced1fc5e8
Author: rjkroege <rjkroege@chromium.org>
Date: Tue Apr 12 18:16:47 2016

mus CommandBufferDriver cleanup detected by static analysis.

BUG= 596549 , 427616 

Review URL: https://codereview.chromium.org/1875303003

Cr-Commit-Position: refs/heads/master@{#386739}

[modify] https://crrev.com/4d068106509793cf3f90916076548faced1fc5e8/components/mus/gles2/command_buffer_driver.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Bulk verified
Components: Internals>Services>WindowService
Components: -MUS>Phase>1

Sign in to add a comment