New issue
Advanced search Search tips

Issue 596547 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 596523



Sign in to add a comment

FTP directory parsing accepts timestamp components containing a leading plus sign.

Project Member Reported by eroman@chromium.org, Mar 21 2016

Issue description

ftp_directory_listing_parser_ls.cc uses base::StringToInt() to parse the components of dates, without checking if the component contained a leading plus.

This is going to recognize more things than expected, but should not be causing harm. However I don't think that was the intent of the code.
 

Comment 1 by eroman@chromium.org, Mar 21 2016

Same thing in a number of other parses in FTP.

Comment 2 by eroman@chromium.org, Mar 21 2016

Components: -Internals>Network Internals>Network>FTP

Comment 3 by eroman@chromium.org, Mar 23 2016

Owner: eroman@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by eroman@chromium.org, Apr 15 2016

Status: WontFix (was: Assigned)
These are using string16 inputs, so the parse_number.h versions aren't currently applicable.

Not much advantage in "fixing" these, as it is just directory listing where strictness is not a thing.

Sign in to add a comment