New issue
Advanced search Search tips

Issue 596540 link

Starred by 1 user
Status: Fixed
Owner:
peter@chromium.org
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Message padding bytes need to be casted before combined

Project Member Reported by peter@chromium.org, Mar 21 2016 
Currently we're ORing two signed chars, which doesn't produce the correct value when the value >127. This means half of the possible padding values for Web Push encryption don't work.

CL upcoming.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8cf0ead8021b74f0898913f86ff5ee4e6f13e53

commit f8cf0ead8021b74f0898913f86ff5ee4e6f13e53
Author: peter <peter@chromium.org>
Date: Mon Mar 21 18:25:16 2016

Add static_casts when combining the padding length

BUG= 596540 

Review URL: https://codereview.chromium.org/1817143003

Cr-Commit-Position: refs/heads/master@{#382332}

[modify] https://crrev.com/f8cf0ead8021b74f0898913f86ff5ee4e6f13e53/components/gcm_driver/crypto/gcm_message_cryptographer.cc

Comment 2 by peter@chromium.org, Mar 21 2016

Labels: Merge-Request-50
Requesting merge. This is a safe and trivial change.

Comment 3 by tin...@google.com, Mar 22 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)

Comment 4 by gov...@chromium.org, Mar 23 2016 

Please merge your change by Friday EOD so we can take it in for next week beta.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 24 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/743afbd039968b4d902a48733da47350f7f999ce

commit 743afbd039968b4d902a48733da47350f7f999ce
Author: Peter Beverloo <peter@chromium.org>
Date: Thu Mar 24 17:09:13 2016

Add static_casts when combining the padding length

BUG= 596540 

Review URL: https://codereview.chromium.org/1817143003

Cr-Commit-Position: refs/heads/master@{#382332}
(cherry picked from commit f8cf0ead8021b74f0898913f86ff5ee4e6f13e53)

Review URL: https://codereview.chromium.org/1828303002 .

Cr-Commit-Position: refs/branch-heads/2661@{#377}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/743afbd039968b4d902a48733da47350f7f999ce/components/gcm_driver/crypto/gcm_message_cryptographer.cc

Comment 6 by peter@chromium.org, Mar 24 2016

Status: Fixed (was: Started)
►

Sign in to add a comment