New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 596536 link

Starred by 1 user
Status: Verified
Owner:
█ ntang@chromium.org
Last visit > 30 days ago
Closed: Apr 2016
Cc:
█ stephenlin@chromium.org
█ jean@chromium.org
█ krk@chromium.org
█ autumn@chromium.org
█ sbasi@chromium.org
█ bhthompson@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Improve Moblab OOBE configuration experience

Project Member Reported by ntang@google.com, Mar 21 2016 
To improve the Moblab OOBE configuration experience, we will add a configuration wizard fucosing on network connectivity check and Google Cloud Storage access set up.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9afc74b7f9f49a1de4f714aff88f53bebcac0f4b

commit 9afc74b7f9f49a1de4f714aff88f53bebcac0f4b
Author: Michael Tang <ntang@google.com>
Date: Mon Mar 21 17:19:23 2016

Backend RPC handlers for Moblab OOBE related calls.

BUG= chromium:596536 

TEST=Unit tested.

Change-Id: Iaa113708138f6a3fe88f44057d66a8faf240b04a
Reviewed-on: https://chromium-review.googlesource.com/334191
Commit-Ready: Michael Tang <ntang@chromium.org>
Tested-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Dan Shi <dshi@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>

[modify] https://crrev.com/9afc74b7f9f49a1de4f714aff88f53bebcac0f4b/frontend/afe/site_rpc_interface.py
[modify] https://crrev.com/9afc74b7f9f49a1de4f714aff88f53bebcac0f4b/frontend/afe/site_rpc_interface_unittest.py
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/159ca506308ec48cf31cfa7dbb908143ed58f071

commit 159ca506308ec48cf31cfa7dbb908143ed58f071
Author: Michael Tang <ntang@google.com>
Date: Mon Mar 21 17:44:23 2016

Moblab configuration wizard UI widget.

BUG= chromium:596536 
TEST=Unit Tests.

Change-Id: I5d31fd30876b32d40980bbce462764ef26da5520
Reviewed-on: https://chromium-review.googlesource.com/334012
Commit-Ready: Michael Tang <ntang@chromium.org>
Tested-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[add] https://crrev.com/159ca506308ec48cf31cfa7dbb908143ed58f071/frontend/client/test/autotest/moblab/wizard/ConfigWizardTest.java
[add] https://crrev.com/159ca506308ec48cf31cfa7dbb908143ed58f071/frontend/client/src/autotest/moblab/rpc/MoblabRpcCallbacks.java
[add] https://crrev.com/159ca506308ec48cf31cfa7dbb908143ed58f071/frontend/client/src/autotest/moblab/rpc/OperationStatus.java
[add] https://crrev.com/159ca506308ec48cf31cfa7dbb908143ed58f071/frontend/client/src/autotest/moblab/wizard/WizardCard.java
[add] https://crrev.com/159ca506308ec48cf31cfa7dbb908143ed58f071/frontend/client/src/autotest/moblab/rpc/NetworkInfo.java
[add] https://crrev.com/159ca506308ec48cf31cfa7dbb908143ed58f071/frontend/client/src/autotest/moblab/wizard/NetworkInfoCard.java
[add] https://crrev.com/159ca506308ec48cf31cfa7dbb908143ed58f071/frontend/client/src/autotest/moblab/rpc/JsonRpcEntity.java
[add] https://crrev.com/159ca506308ec48cf31cfa7dbb908143ed58f071/frontend/client/test/autotest/moblab/rpc/NetworkInfoTest.java
[add] https://crrev.com/159ca506308ec48cf31cfa7dbb908143ed58f071/frontend/client/src/autotest/moblab/rpc/MoblabRpcHelper.java
[add] https://crrev.com/159ca506308ec48cf31cfa7dbb908143ed58f071/frontend/client/test/autotest/moblab/MoblabSetupClientTest.gwt.xml
[add] https://crrev.com/159ca506308ec48cf31cfa7dbb908143ed58f071/frontend/client/src/autotest/moblab/wizard/FlexWizardCard.java
[add] https://crrev.com/159ca506308ec48cf31cfa7dbb908143ed58f071/frontend/client/src/autotest/moblab/wizard/ConfigViewMode.java
[add] https://crrev.com/159ca506308ec48cf31cfa7dbb908143ed58f071/frontend/client/src/autotest/moblab/wizard/ConfigEditMode.java
[add] https://crrev.com/159ca506308ec48cf31cfa7dbb908143ed58f071/frontend/client/test/autotest/moblab/rpc/CloudStorageInfoTest.java
[modify] https://crrev.com/159ca506308ec48cf31cfa7dbb908143ed58f071/frontend/client/src/autotest/public/afeclient.css
[add] https://crrev.com/159ca506308ec48cf31cfa7dbb908143ed58f071/frontend/client/test/autotest/moblab/MoblabTest.java
[add] https://crrev.com/159ca506308ec48cf31cfa7dbb908143ed58f071/frontend/client/src/autotest/moblab/wizard/ConfigWizard.java
[modify] https://crrev.com/159ca506308ec48cf31cfa7dbb908143ed58f071/frontend/client/src/autotest/common/Utils.java
[add] https://crrev.com/159ca506308ec48cf31cfa7dbb908143ed58f071/frontend/client/src/autotest/moblab/wizard/CloudStorageCard.java
[add] https://crrev.com/159ca506308ec48cf31cfa7dbb908143ed58f071/frontend/client/src/autotest/moblab/rpc/CloudStorageInfo.java
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d27059144bb2f6339f5d5aa6c762574fd94200ca

commit d27059144bb2f6339f5d5aa6c762574fd94200ca
Author: Michael Tang <ntang@google.com>
Date: Mon Mar 21 17:49:12 2016

Integrate the wizard into the Moblab UI.

Also adds updated based on some comments from change 334012.

BUG= chromium:596536 
TEST=Manually test.

Change-Id: I70d04718bcec81c326ae9b2aab4550214e795558
Reviewed-on: https://chromium-review.googlesource.com/333993
Commit-Ready: Michael Tang <ntang@chromium.org>
Tested-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Stephen Lin <stephenlin@google.com>
Reviewed-by: Michael Tang <ntang@chromium.org>

[modify] https://crrev.com/d27059144bb2f6339f5d5aa6c762574fd94200ca/frontend/client/src/autotest/moblab/MoblabSetupClient.java
[modify] https://crrev.com/d27059144bb2f6339f5d5aa6c762574fd94200ca/frontend/client/src/autotest/moblab/rpc/OperationStatus.java
[modify] https://crrev.com/d27059144bb2f6339f5d5aa6c762574fd94200ca/frontend/client/src/autotest/moblab/rpc/JsonRpcEntity.java
[modify] https://crrev.com/d27059144bb2f6339f5d5aa6c762574fd94200ca/frontend/client/src/autotest/moblab/rpc/MoblabRpcHelper.java
[modify] https://crrev.com/d27059144bb2f6339f5d5aa6c762574fd94200ca/frontend/client/src/autotest/public/MoblabSetupClient.html
[modify] https://crrev.com/d27059144bb2f6339f5d5aa6c762574fd94200ca/frontend/client/src/autotest/moblab/ConfigSettingsView.java
[modify] https://crrev.com/d27059144bb2f6339f5d5aa6c762574fd94200ca/frontend/client/src/autotest/common/Utils.java
[add] https://crrev.com/d27059144bb2f6339f5d5aa6c762574fd94200ca/frontend/client/src/autotest/moblab/ConfigWizardView.java
[modify] https://crrev.com/d27059144bb2f6339f5d5aa6c762574fd94200ca/frontend/client/src/autotest/moblab/rpc/CloudStorageInfo.java

Comment 4 by ntang@google.com, Mar 31 2016

Labels: Merge-Request-51

Comment 5 by tin...@google.com, Mar 31 2016

Labels: -Merge-Request-51 Merge-Review-51 Hotlist-Merge-Review
[Automated comment] We don't branch for M51 for another 8 days, was this request meant for M50?

Comment 6 by ntang@google.com, Mar 31 2016 

Actually, just try to make sure the change goes into M51.

Comment 7 by ntang@google.com, Apr 8 2016

Status: Fixed (was: Assigned)

Comment 8 by patricia@chromium.org, Apr 11 2016

Labels: VerifyIn-51

Comment 10 by ntang@google.com, May 6 2016

Cc: bhthompson@chromium.org krk@chromium.org
Labels: Merge-Request-51
This is an additional CL attached to the issue.

Comment 11 by bhthompson@chromium.org, May 6 2016

Labels: -Merge-Request-51 Merge-Approved-51

Comment 12 by krk@chromium.org, May 6 2016

Status: Verified (was: Fixed)
Project Member

Comment 13 by bugdroid1@chromium.org, May 6 2016

Labels: merge-merged-release-R51-8172.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8561c9116a3f59e361151c9b613f3d12213d97c4

commit 8561c9116a3f59e361151c9b613f3d12213d97c4
Author: Michael Tang <ntang@google.com>
Date: Fri Mar 25 21:31:14 2016

Reboot the device after wizard configuration.

BUG= chromium:596536 
TEST=Manually test.

Change-Id: I01e6e9fb31a77c0132f92620463d25bf363e0605
Reviewed-on: https://chromium-review.googlesource.com/335332
Commit-Ready: Michael Tang <ntang@chromium.org>
Tested-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>
(cherry picked from commit c05c9efcfdd6a720edd0dfeb6f92284e264b303f)
Reviewed-on: https://chromium-review.googlesource.com/343250
Reviewed-by: Mohan Konduri <krk@chromium.org>
Commit-Queue: Michael Tang <ntang@chromium.org>
Trybot-Ready: Michael Tang <ntang@chromium.org>

[modify] https://crrev.com/8561c9116a3f59e361151c9b613f3d12213d97c4/frontend/afe/site_rpc_interface.py
[modify] https://crrev.com/8561c9116a3f59e361151c9b613f3d12213d97c4/frontend/client/src/autotest/moblab/wizard/ConfigWizard.java
[modify] https://crrev.com/8561c9116a3f59e361151c9b613f3d12213d97c4/frontend/client/src/autotest/moblab/wizard/ConfigEditMode.java
[modify] https://crrev.com/8561c9116a3f59e361151c9b613f3d12213d97c4/frontend/client/src/autotest/moblab/rpc/MoblabRpcHelper.java
Project Member

Comment 14 by sheriffbot@chromium.org, May 10 2016 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 15 by krk@chromium.org, May 10 2016

Labels: -Merge-Approved-51
►

Sign in to add a comment