New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596526 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Integer-overflow in FX_atonum

Project Member Reported by ClusterFuzz, Mar 21 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5736850173460480

Uploader: ochang@google.com
Job Type: linux_ubsan_pdfium
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  FX_atonum
  CPDF_SyntaxParser::GetObject
  CPDF_SyntaxParser::GetObject
  

Minimized Testcase (4.78 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95jloQKU7YuDtAonyFilpWEsr3X5VGqlFRywWizyStaYUKzf5Hgy26ahOYy_wMPdQB_Ppv5BuYfr0YhR-V9FEFZBlCcJIm7LnMiAKDZS24kqN2sNjwChxVvv05T_Ce8FyMQ2hs_s6xmGFRDCWiZNOU161xAQg

Filer: ochang

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by och...@chromium.org, Mar 21 2016

Cc: ivancic@google.com
Components: Internals>Plugins>PDF
Cc: tsepez@chromium.org och...@chromium.org
Cc: kcc@chromium.org aizatsky@chromium.org mmoroz@google.com
 Issue 603546  has been merged into this issue.
Owner: dsinclair@chromium.org
Status: Assigned (was: Available)
There's a TODO(dsinclair) in FX_atonum().
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium.git/+/bc8a64029f898286c3dcad3a6cecdc98ef30b139

commit bc8a64029f898286c3dcad3a6cecdc98ef30b139
Author: dsinclair <dsinclair@chromium.org>
Date: Thu May 19 18:37:10 2016

Correctly check for overflow in FX_atonum.

Instead of the existing method, use the CheckedNumeric class to check for
overflow during conversion.

BUG= chromium:596526 

Review-Url: https://codereview.chromium.org/1992023003

[modify] https://crrev.com/bc8a64029f898286c3dcad3a6cecdc98ef30b139/core/fxcrt/fx_basic_util.cpp

Status: Fixed (was: Started)
Project Member

Comment 8 by ClusterFuzz, Jun 8 2016

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5736850173460480

Uploader: ochang@google.com
Job Type: linux_ubsan_pdfium
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  FX_atonum
  CPDF_SyntaxParser::GetObject
  CPDF_SyntaxParser::GetObject
  

Minimized Testcase (4.78 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95LeuXQBt2rtFFFvUNNVJvTg38pN1ZvP1xKu_4hvoJx5ybkOpgi48LPsPqiyDH011qJXiTf0J4xrfVaA_w5KfgYWgt7Y14anBTTf6Bcj9rcEUPJV_qfL6__A7utw_Te4DmVnUT-5Wz4KrRG513jk84vRz--9A

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
Project Member

Comment 9 by ClusterFuzz, Jun 9 2016

ClusterFuzz has detected this issue as fixed in range 394980:395008.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5736850173460480

Uploader: ochang@google.com
Job Type: linux_ubsan_pdfium
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  FX_atonum
  CPDF_SyntaxParser::GetObject
  CPDF_SyntaxParser::GetObject
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_pdfium&range=370022:370027
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_pdfium&range=394980:395008

Minimized Testcase (4.78 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95LeuXQBt2rtFFFvUNNVJvTg38pN1ZvP1xKu_4hvoJx5ybkOpgi48LPsPqiyDH011qJXiTf0J4xrfVaA_w5KfgYWgt7Y14anBTTf6Bcj9rcEUPJV_qfL6__A7utw_Te4DmVnUT-5Wz4KrRG513jk84vRz--9A

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment