New issue
Advanced search Search tips

Issue 596522 link

Starred by 2 users
Status: Fixed
Owner:
sriram...@samsung.com
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 596760



Sign in to add a comment

media: Replace wtf/Assertions.h macros in favor of base/logging.h macros.

Project Member Reported by xhw...@chromium.org, Mar 21 2016 
See https://codereview.chromium.org/1807853003/ for the context.

For example:
- FATAL() -> DLOG(FATAL)
- WTF_LOG_ERROR -> DLOG(ERROR)
- WTF_LOG -> DVLOG() or VLOG()
- RELEASE_ASSERT -> CHECK()
- ...

Please see third_party/WebKit/Source/wtf/Assertions.h for more details.

Comment 1 by xhw...@chromium.org, Mar 22 2016

Blocking: 596760

Comment 2 by xhw...@chromium.org, Mar 22 2016

Labels: Hotlist-CodeHealth

Comment 3 by sriram...@samsung.com, May 19 2016

Owner: sriram...@samsung.com
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, May 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dbdb7c7b7e7aebe2ab71db16c294699c59d50e1

commit 0dbdb7c7b7e7aebe2ab71db16c294699c59d50e1
Author: srirama.m <srirama.m@samsung.com>
Date: Thu May 19 11:59:11 2016

media: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Replace WTF_LOG macros with DVLOG in HTMLMediaElement.cpp

BUG= 596522 

Review-Url: https://codereview.chromium.org/1988753002
Cr-Commit-Position: refs/heads/master@{#394742}

[modify] https://crrev.com/0dbdb7c7b7e7aebe2ab71db16c294699c59d50e1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
Project Member

Comment 6 by bugdroid1@chromium.org, May 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b713fbf448790f824cf973281e40663b3bc95e67

commit b713fbf448790f824cf973281e40663b3bc95e67
Author: srirama.m <srirama.m@samsung.com>
Date: Thu May 19 16:25:44 2016

media: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Replace WTF_LOG macros with DVLOG in HTMLSourceElement.cpp.

BUG= 596522 

Review-Url: https://codereview.chromium.org/1991043003
Cr-Commit-Position: refs/heads/master@{#394788}

[modify] https://crrev.com/b713fbf448790f824cf973281e40663b3bc95e67/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp
Project Member

Comment 7 by bugdroid1@chromium.org, May 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66881c9f9e22cdd1d7dca58c5b9191069e20346e

commit 66881c9f9e22cdd1d7dca58c5b9191069e20346e
Author: srirama.m <srirama.m@samsung.com>
Date: Fri May 20 15:42:19 2016

media: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Replace WTF_LOG macros with DVLOG in webaudio module.

BUG= 596522 

Review-Url: https://codereview.chromium.org/1988053005
Cr-Commit-Position: refs/heads/master@{#395076}

[modify] https://crrev.com/66881c9f9e22cdd1d7dca58c5b9191069e20346e/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
[modify] https://crrev.com/66881c9f9e22cdd1d7dca58c5b9191069e20346e/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp
Project Member

Comment 8 by bugdroid1@chromium.org, May 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63fee82a587cce7057768670d4b98a6d1660f515

commit 63fee82a587cce7057768670d4b98a6d1660f515
Author: srirama.m <srirama.m@samsung.com>
Date: Fri May 20 15:44:06 2016

media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Replaced wtf/Assertions.h macros in favor of base/logging.h
macros in core/html/track folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG= 596522 

Review-Url: https://codereview.chromium.org/2003543002
Cr-Commit-Position: refs/heads/master@{#395078}

[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp
[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/CueTimeline.cpp
[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/CueTimeline.h
[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp
[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/TextTrack.cpp
[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp
[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/TextTrackCue.cpp
[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/TextTrackCueList.cpp
[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/TextTrackList.cpp
[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/TrackEvent.cpp
[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/TrackListBase.h
[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/VideoTrackList.cpp
[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/vtt/BufferedLineReader.cpp
[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/vtt/BufferedLineReader.h
[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp
[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/vtt/VTTElement.cpp
[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp
[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/vtt/VTTScanner.cpp
[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/vtt/VTTScanner.h
[modify] https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515/third_party/WebKit/Source/core/html/track/vtt/VTTTokenizer.cpp
Project Member

Comment 9 by bugdroid1@chromium.org, May 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45983aa1e8d4b40ba64e2ca387ebbe071514876d

commit 45983aa1e8d4b40ba64e2ca387ebbe071514876d
Author: gogerald <gogerald@chromium.org>
Date: Fri May 20 16:07:44 2016

Revert of media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros (patchset #3 id:40001 of https://codereview.chromium.org/2003543002/ )

Reason for revert:
Crash build http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/44237.

https://chromium.googlesource.com/chromium/src/+blame/master/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp#783

DCHECKs are removed from Release build.

Original issue's description:
> media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros
>
> Replaced wtf/Assertions.h macros in favor of base/logging.h
> macros in core/html/track folder.
>
> ASSERT, ASSERT_UNUSED -> DCHECK
> ASSERT_NOT_REACHED -> NOTREACHED
> ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK
>
> BUG= 596522 
>
> Committed: https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515
> Cr-Commit-Position: refs/heads/master@{#395078}

TBR=fs@opera.com,srirama.m@samsung.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 596522 

Review-Url: https://codereview.chromium.org/1999813002
Cr-Commit-Position: refs/heads/master@{#395080}

[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp
[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/CueTimeline.cpp
[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/CueTimeline.h
[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp
[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/TextTrack.cpp
[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp
[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/TextTrackCue.cpp
[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/TextTrackCueList.cpp
[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/TextTrackList.cpp
[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/TrackEvent.cpp
[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/TrackListBase.h
[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/VideoTrackList.cpp
[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/vtt/BufferedLineReader.cpp
[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/vtt/BufferedLineReader.h
[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp
[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/vtt/VTTElement.cpp
[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp
[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/vtt/VTTScanner.cpp
[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/vtt/VTTScanner.h
[modify] https://crrev.com/45983aa1e8d4b40ba64e2ca387ebbe071514876d/third_party/WebKit/Source/core/html/track/vtt/VTTTokenizer.cpp
Project Member

Comment 10 by bugdroid1@chromium.org, May 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf2181075f253789624f1a76c199182016da9c79

commit bf2181075f253789624f1a76c199182016da9c79
Author: srirama.m <srirama.m@samsung.com>
Date: Sat May 21 15:32:41 2016

media: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Replaced wtf/Assertions.h macros in favor of base/logging.h macros in MediaSource.cpp.
WTF_LOG -> DVLOG
ASSERT -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED

BUG= 596522 

Review-Url: https://codereview.chromium.org/1996603002
Cr-Commit-Position: refs/heads/master@{#395261}

[modify] https://crrev.com/bf2181075f253789624f1a76c199182016da9c79/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
Project Member

Comment 11 by bugdroid1@chromium.org, May 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5a45e57511f817668cdeac2373895a3e88e2c4e

commit a5a45e57511f817668cdeac2373895a3e88e2c4e
Author: srirama.m <srirama.m@samsung.com>
Date: Mon May 23 07:35:11 2016

Reland "media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros"

Replaced wtf/Assertions.h macros in favor of base/logging.h
macros in core/html/track folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG= 596522 

patch from issue 2003543002 at patchset 40001 (http://crrev.com/2003543002#ps40001)

Review-Url: https://codereview.chromium.org/2003433005
Cr-Commit-Position: refs/heads/master@{#395291}

[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp
[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/CueTimeline.cpp
[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/CueTimeline.h
[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp
[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/TextTrack.cpp
[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp
[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/TextTrackCue.cpp
[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/TextTrackCueList.cpp
[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/TextTrackList.cpp
[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/TrackEvent.cpp
[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/TrackListBase.h
[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/VideoTrackList.cpp
[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/vtt/BufferedLineReader.cpp
[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/vtt/BufferedLineReader.h
[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp
[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/vtt/VTTElement.cpp
[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp
[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/vtt/VTTScanner.cpp
[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/vtt/VTTScanner.h
[modify] https://crrev.com/a5a45e57511f817668cdeac2373895a3e88e2c4e/third_party/WebKit/Source/core/html/track/vtt/VTTTokenizer.cpp
Project Member

Comment 12 by bugdroid1@chromium.org, May 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3457a685fe7ed2606c33167570222df0ecda8848

commit 3457a685fe7ed2606c33167570222df0ecda8848
Author: srirama.m <srirama.m@samsung.com>
Date: Mon May 23 18:20:05 2016

media: Replace wtf/Assertions.h macros in favor of base/logging.h macros"

Replaced wtf/Assertions.h macros in favor of
base/logging.h macros in core/html/ folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG= 596522 

Review-Url: https://codereview.chromium.org/2001013003
Cr-Commit-Position: refs/heads/master@{#395366}

[modify] https://crrev.com/3457a685fe7ed2606c33167570222df0ecda8848/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/3457a685fe7ed2606c33167570222df0ecda8848/third_party/WebKit/Source/core/html/HTMLMediaSource.cpp
[modify] https://crrev.com/3457a685fe7ed2606c33167570222df0ecda8848/third_party/WebKit/Source/core/html/HTMLTrackElement.cpp
[modify] https://crrev.com/3457a685fe7ed2606c33167570222df0ecda8848/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp
[modify] https://crrev.com/3457a685fe7ed2606c33167570222df0ecda8848/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp
[modify] https://crrev.com/3457a685fe7ed2606c33167570222df0ecda8848/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h
[modify] https://crrev.com/3457a685fe7ed2606c33167570222df0ecda8848/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/3457a685fe7ed2606c33167570222df0ecda8848/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
Project Member

Comment 13 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/060d0889ac68f2bd629ab3b684723dd32fce7a88

commit 060d0889ac68f2bd629ab3b684723dd32fce7a88
Author: srirama.m <srirama.m@samsung.com>
Date: Wed May 25 03:25:26 2016

encryptedmedia: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Replaced wtf/Assertions.h macros in favor of base/logging.h
macros in encryptedmedia module.

WTF_LOG -> DVLOG
ASSERT -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED

BUG= 596522 ,  596760 

Review-Url: https://codereview.chromium.org/2001173002
Cr-Commit-Position: refs/heads/master@{#395791}

[modify] https://crrev.com/060d0889ac68f2bd629ab3b684723dd32fce7a88/third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.cpp
[modify] https://crrev.com/060d0889ac68f2bd629ab3b684723dd32fce7a88/third_party/WebKit/Source/modules/encryptedmedia/EncryptedMediaUtils.cpp
[modify] https://crrev.com/060d0889ac68f2bd629ab3b684723dd32fce7a88/third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp
[modify] https://crrev.com/060d0889ac68f2bd629ab3b684723dd32fce7a88/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp
[modify] https://crrev.com/060d0889ac68f2bd629ab3b684723dd32fce7a88/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySystemAccess.cpp
[modify] https://crrev.com/060d0889ac68f2bd629ab3b684723dd32fce7a88/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp
[modify] https://crrev.com/060d0889ac68f2bd629ab3b684723dd32fce7a88/third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d88bc593d79030ed8c7dc8caf44d8b4a018b1b6

commit 9d88bc593d79030ed8c7dc8caf44d8b4a018b1b6
Author: srirama.m <srirama.m@samsung.com>
Date: Thu Jun 09 12:05:46 2016

media: Remove logMedia from WTFLogChannel

Removed logMedia from WTFLogChannel as all WTF_LOGs are replaced
with DVLOGs in media modules. Few WTF_LOGs are still present in
HTMLMediaElement.cpp and removed them as well in this CL.

BUG= 596522 

Review-Url: https://codereview.chromium.org/2046473002
Cr-Commit-Position: refs/heads/master@{#398848}

[modify] https://crrev.com/9d88bc593d79030ed8c7dc8caf44d8b4a018b1b6/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/9d88bc593d79030ed8c7dc8caf44d8b4a018b1b6/third_party/WebKit/Source/platform/Logging.cpp
[modify] https://crrev.com/9d88bc593d79030ed8c7dc8caf44d8b4a018b1b6/third_party/WebKit/Source/platform/Logging.h
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3fe6f1821c41ae39804811188937ba6a81e9458

commit c3fe6f1821c41ae39804811188937ba6a81e9458
Author: srirama.m <srirama.m@samsung.com>
Date: Mon Jun 13 11:11:08 2016

media: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Replaced ASSERT with DCHECK in mediasession module.

BUG= 596522 

Review-Url: https://codereview.chromium.org/2058783002
Cr-Commit-Position: refs/heads/master@{#399429}

[modify] https://crrev.com/c3fe6f1821c41ae39804811188937ba6a81e9458/third_party/WebKit/Source/modules/mediasession/MediaSession.cpp
[modify] https://crrev.com/c3fe6f1821c41ae39804811188937ba6a81e9458/third_party/WebKit/Source/modules/mediasession/MediaSessionError.cpp
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d88bc593d79030ed8c7dc8caf44d8b4a018b1b6

commit 9d88bc593d79030ed8c7dc8caf44d8b4a018b1b6
Author: srirama.m <srirama.m@samsung.com>
Date: Thu Jun 09 12:05:46 2016

media: Remove logMedia from WTFLogChannel

Removed logMedia from WTFLogChannel as all WTF_LOGs are replaced
with DVLOGs in media modules. Few WTF_LOGs are still present in
HTMLMediaElement.cpp and removed them as well in this CL.

BUG= 596522 

Review-Url: https://codereview.chromium.org/2046473002
Cr-Commit-Position: refs/heads/master@{#398848}

[modify] https://crrev.com/9d88bc593d79030ed8c7dc8caf44d8b4a018b1b6/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/9d88bc593d79030ed8c7dc8caf44d8b4a018b1b6/third_party/WebKit/Source/platform/Logging.cpp
[modify] https://crrev.com/9d88bc593d79030ed8c7dc8caf44d8b4a018b1b6/third_party/WebKit/Source/platform/Logging.h
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3fe6f1821c41ae39804811188937ba6a81e9458

commit c3fe6f1821c41ae39804811188937ba6a81e9458
Author: srirama.m <srirama.m@samsung.com>
Date: Mon Jun 13 11:11:08 2016

media: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Replaced ASSERT with DCHECK in mediasession module.

BUG= 596522 

Review-Url: https://codereview.chromium.org/2058783002
Cr-Commit-Position: refs/heads/master@{#399429}

[modify] https://crrev.com/c3fe6f1821c41ae39804811188937ba6a81e9458/third_party/WebKit/Source/modules/mediasession/MediaSession.cpp
[modify] https://crrev.com/c3fe6f1821c41ae39804811188937ba6a81e9458/third_party/WebKit/Source/modules/mediasession/MediaSessionError.cpp

Comment 19 by sriram...@samsung.com, Jun 29 2016 

@xhwang, anything pending in this? Can i close this now?
As far i as know i have changed all the media related modules.

Comment 20 by sriram...@samsung.com, Jul 7 2016

Status: Fixed (was: Assigned)
Marking it as fixed.
►

Sign in to add a comment